CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 09:12:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
16,033 Commits 2 Branches 0 Tags
fa501696e59e90f511bcf18f9d96fa100aebace8
Commit Graph

444 Commits

Author SHA1 Message Date
Mateusz Konieczny
2ff01beba3 Better describe culvert in fix for waterway-road intersection warnings (#10783) 2025-02-17 18:59:29 +01:00
Justin Tracey
d6ee1bb4cd add crossing:markings tag when connecting crossing (#9586) 2025-02-17 12:57:25 +01:00
Kyℓe Hensel
8f9d7e01bf validate suspicious names using the user's language (#9522) 2025-02-17 11:42:04 +01:00
Kyℓe Hensel
4747ae253c refactor isOneWay to properly support bidirectional ways (#10730) 2025-02-12 14:22:09 +01:00
Martin Raifer
f3a985f78b ways with more than 2000 nodes: prevent lockup and provide validator-fix (#8808) 
* add validation & fix for way vertices limit imposed by OSM API (try to choose splitting locations at existing intersection vertices if possible)
* fix splitting of closed ways at two or more nodes:
  this bug resulted sometimes in one extra split point in the result, or one of the split  vertices to be left unsplit
 2025-02-11 20:08:38 +01:00
Kyle Hensel
f244e63661 validate crossing aeroways (#9315) 2025-02-05 14:42:32 +01:00
Avan2021
f44702e0b5 add oneway to list of attribute-only tag (#10706) 2025-02-04 11:00:51 +01:00
Kyle Hensel
50309005a1 fix erroneous mismatched_geometry warning for preset-less tags 2024-11-23 04:48:28 +14:00
Kyle Hensel
c3c0e23ba8 fix unsolvable validator error for presets with locationSet 2024-09-09 20:57:26 +10:00
Kyle Hensel
90c4241723 fix dependency cycle caused by utilDisplayLabel importing presetManager 2024-08-24 11:34:46 +10:00
Martin Raifer
12b0528175 Upgrade closed ways with traffic_calming=island to area:highway=traffic_calming 
addresses missing pieces for https://github.com/openstreetmap/id-tagging-schema/issues/1162
 2024-03-15 21:12:31 +01:00
Martin Raifer
cc920d3fba drop unused var 2024-03-02 15:43:56 +01:00
Martin Raifer
97442403cf drop validator which checks for old style multipolygons 
these have long been [fixed](https://blog.jochentopf.com/2017-08-28-polygon-fixing-effort-concluded.html) in OSM

see wiki: https://wiki.openstreetmap.org/wiki/Old_style_multipolygons
 2024-02-29 13:28:22 +01:00
marc tobias
277b5d4f45 new validator: mutually exclusive tags 2024-02-25 18:40:10 +01:00
Martin Raifer
bb5e9e063d don't trigger line-is-area warning for tags implemented as 2 geometry-dedicated presets 
e.g. `highway=elevator` in the "Elevator" and "Inclined Lift" presets
 2023-07-15 19:44:32 +02:00
Martin Raifer
140838f4b1 fix accidentally committed code, switch to different ford icon 2023-05-26 19:50:09 +02:00
Martin Raifer
f517b867de add tests for #9650 2023-05-25 15:24:52 +02:00
Martin Raifer
9517d06d11 use lodash for object comparison 2023-05-25 13:22:39 +02:00
Minh Nguyễn
e4641b581f Offer to connect sidewalk to service road without tagging crossing (#9650) 2023-05-25 13:17:34 +02:00
archpdx
81374c3735 Fix connect features with uncontrolled crossing (#9443) 2023-01-19 11:59:16 +01:00
Kamil Monicz
65da698886 Optimize oldTagIssues method by reordering the checks (#9434) 
The hasInterestingTags skips most entities and is light to run - in contrary to presetManager.match
 2022-12-20 18:53:09 +01:00
Martin Raifer
41aa127d23 reduce use of parseFloat 
as it silently strips non-numeric suffixes (e.g. a value of "123 foo" is transformed into a numeric value of 123 by `parseFloat`, which is typically not what we desire)
 2022-11-24 19:39:15 +01:00
Martin Raifer
5f1360ed0f don't suggest to "connect the ends" if a feature with area tags matches a line preset 
For example, when a feature tagged as `highway=primary` (line preset) and `man_made=bridge` (area preset) is mapped as an unclosed way, converting it to an area (by closing the way by connecting the endpoints) does not improve the situation, as then the other tag doesn't fit to the geometry anymore.

closes #7037
 2022-11-04 12:23:15 +01:00
Minh Nguyễn
3bf8d52ca9 Fixed undo text when deleting private tags 2022-09-23 11:08:14 -07:00
Martin Raifer
eb18de83a9 fix crash caused by wrongly set title of validation fix 2022-07-19 19:14:05 +02:00
Martin Raifer
0c1d4c7c44 Merge remote-tracking branch 'faebebin/fix/9176-connect-features-crossing-with-pedestrian-signals' into develop 2022-07-19 16:38:18 +02:00
faebebin
9dcc6d1e7d Fix connect features when crossing with pedestrian signals 2022-06-24 19:02:33 +02:00
Martin Raifer
8bb1d39431 refactor validation modules to not inject html 2022-06-24 13:25:56 +02:00
paulklie
ab96c3576f #8419 memorial stolperstein are ignored for close node check (#9089) 2022-06-06 16:50:45 +02:00
Martin Raifer
6a9e0997c7 Handle indoor features like buildings when checking for crossing ways 
see https://github.com/openstreetmap/iD/issues/8944#issuecomment-1029213558
 2022-02-03 19:11:27 +01:00
ᴄʜʀɪsᴛᴏᴘʜᴇʀ ᴍᴇɴɢ
eb82698fa5 Remove accidental mismatch of "PAMAP" (#8889) 2022-01-28 15:34:19 +01:00
Martin Raifer
4363bac574 document why code is commented out 2021-12-10 18:19:59 +01:00
Benjamin Clark
9bfcd56c35 Fix bug that was causing google validation warnings to appear over changesets with the approved google africa building dataset. 2021-12-09 12:33:27 -05:00
Martin Raifer
9f3f8e1366 rename method 2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588 replace raw html injection of localized texts 
by using d3 to insert the localized text spans directly into the DOM
 2021-11-26 18:51:45 +01:00
Martin Raifer
4f51ededfd fix eslint "no-implicit-coercion" warning 
See https://eslint.org/docs/rules/no-implicit-coercion for this warning. However the implicit type conversion is unnecessary here, since `Number.toFixed` already returns a string, see https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed.
 2021-11-16 11:20:01 +01:00
Milos Brzakovic (E-Search)
599d2df19b matchTags - don't calculcate valid locations unless needed 
mismatched_geometry - small optimization
 2021-10-20 09:49:00 +02:00
Milos Brzakovic
a018d276eb Merge pull request #8701 from openstreetmap/check_china_source 
Add warning for some commercial mapservice in China
 2021-09-30 12:06:36 +02:00
Milos Brzakovic
a00a9162e7 Merge branch 'develop' into tag_as_not 2021-09-27 19:03:46 +02:00
Bryan Housel
73f8737d17 Adjust the regex for matching Chinese map providers 2021-09-17 12:54:49 -04:00
Bryan Housel
defc87e455 Add warning for some commercial mapservice in China 
(closes #8700)
 2021-09-17 11:36:48 -04:00
Bryan Housel
1f172d5623 Make the crossing_ways hash less strict 
Previously it was including a lot of data about the edge, and a very specific
crossing location.  This meant that any tiny perturbation in the crossing ways
would generate a new issue hash, effectively "fixing" the old crossing issue and
creating a new one.
 2021-08-13 16:24:29 -04:00
Bryan Housel
b5d7cdb6fa Use utilHashcode to generate reasonable ids for crossing_ways issues 
The ones before were a giant blob of json
 2021-08-13 12:56:50 -04:00
Bryan Housel
0db99fe530 When adding not:* tag, remove the old wikipedia and wikidata tags 2021-08-07 00:42:07 -04:00
Bryan Housel
97ddf125d2 Adjust wording of "Tag as not the same thing" 2021-08-06 17:14:32 -04:00
Bryan Housel
52e8555a8f Add a validator fix option to tag as not: a matched item 
(re: #6577)
 2021-08-06 12:26:19 -04:00
Milos Brzakovic
750b4e023f crossing_ways fixing - specially handle crossing nodes 2021-08-05 14:50:38 +02:00
Milos Brzakovic (E-Search)
d2036996e3 Merge conflicts resolved 2021-07-05 10:26:44 +02:00
Bryan Housel
9f30ebf551 Adjust verbose utilDisplayLabel call, use for more validation messages 
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-794527259)
 2021-03-10 10:30:57 -05:00
Bryan Housel
c3e9e8c8ff Support a more verbose format for listing issues 
Includes the feature type in the label
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-791919134)
 2021-03-08 12:15:17 -05:00