CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 17:52:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,227 Commits 2 Branches 0 Tags
fcc7606089bdba9692611fd7ee8381bd2ae1cbd2
Commit Graph

72 Commits

Author SHA1 Message Date
Quincy Morgan
fcc7606089 Update crossing_ways fix to not use the context within the action 2019-01-29 11:47:24 -05:00
Quincy Morgan
2051dc4ca8 Update id of remove generic name fix 2019-01-29 10:45:48 -05:00
Quincy Morgan
f89c18e65d Added quick fix for tag_suggest_area validation to remove the suggesting tags 2019-01-29 10:40:08 -05:00
Quincy Morgan
62ac471808 Improve message and add tooltip to tag_suggeset_area validation 2019-01-25 14:24:53 -05:00
Quincy Morgan
6fff896169 Ignore uninteresting tags and type=multipolygon for missing tags validation 2019-01-25 13:27:49 -05:00
Quincy Morgan
3886ce2ba8 Update issue tooltips and messages 2019-01-25 12:49:02 -05:00
Quincy Morgan
b5a106eab7 Validate paths for edited nodes and relations for edited geometry 2019-01-25 11:29:57 -05:00
Quincy Morgan
6302975ed2 Re-add multipolygon crossing validation 2019-01-25 10:58:57 -05:00
Quincy Morgan
298a53562d Add issue display when selecting any feature, even if not edited 2019-01-24 17:22:34 -05:00
Quincy Morgan
ffe4aa09f4 Pass entity array into validators instead of changes object 2019-01-24 15:26:19 -05:00
Quincy Morgan
a259a9acf1 Add more deprecated tag data from https://wiki.openstreetmap.org/wiki/Deprecated_features 
Run deprecated_tag validation on modified as well as created features
 2019-01-24 15:09:02 -05:00
Quincy Morgan
b21dd1d5d6 Add tooltip and updated message to deprecated_tags validation issue 
Add a quick fix to upgrade deprecated tags
Add more deprecated tag data
 2019-01-24 14:09:12 -05:00
Quincy Morgan
33ae009936 Clarify wording of old_multipolygon issue and tooltip 
Add quick fix for old_multipolygon issue
 2019-01-24 11:01:41 -05:00
Quincy Morgan
981ed9ef8c Integrate the generic_name validation into the new validations framework 2019-01-24 09:28:59 -05:00
Quincy Morgan
01e2370cbd Add background color to the issue pane list 2019-01-24 08:37:46 -05:00
Quincy Morgan
7b288ef95d Add basic zoom-to-clicked-issue behavior 2019-01-23 15:25:55 -05:00
Xiaoming Gao
aa5f1aec5b add auto-fix for almost junction by creating connection nodes 2019-01-16 20:02:25 -05:00
Quincy Morgan
1bfb9ac0c0 Updated almost junction issue message and tooltip to be better aligned with other issues 
Added a quick fix for setting the almost junction node as noexit
 2019-01-16 10:02:05 -05:00
Quincy Morgan
11b2102761 Merge branch 'master' into validation 
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
#	modules/ui/commit_warnings.js
#	modules/ui/entity_editor.js
#	modules/util/index.js
#	modules/util/util.js
#	modules/validations/index.js
#	modules/validations/many_deletions.js
#	modules/validations/missing_tag.js
 2019-01-14 10:13:56 -05:00
Xiaoming Gao
ecacab3ffe add validation for almost junction 
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
 2019-01-08 15:44:55 -05:00
Bryan Housel
6c5ea96ab6 Adjust generic name validation to better check tag values 
e.g. "name=Fast Food" should match "amenity=fast_food"
 2019-01-08 13:43:40 -05:00
Bryan Housel
5f20218f1f Add validation warning for generic names 
(closes #5590)
 2019-01-08 02:15:28 -05:00
Quincy Morgan
70d5529a58 Added initial implementation of quick fix for connecting crossing features (still has some bugs) 2018-12-21 17:39:20 -05:00
Quincy Morgan
90bc7bf6a5 Changed crossing ways issue severity from error to warning 2018-12-21 17:21:29 -05:00
Andrew Wong
958d918bbe Merge pull request #5639 from wonga00/more_tests 
Added more validation tests
 2018-12-21 16:49:11 -05:00
Quincy Morgan
67e585e4c5 Crossing ways issues now use the relevant parent relation when the offending way itself does not have relevant tags 2018-12-21 16:10:48 -05:00
Quincy Morgan
c593bb3475 The issue id now accounts for all entities 2018-12-21 14:51:18 -05:00
Quincy Morgan
d9c6bd1f39 Added specialized issue messages for the common types of way crossing issues 
Fixed several linting issues involving crossing way validations
 2018-12-21 14:45:20 -05:00
Xiaoming Gao
5f333267f4 Merge pull request #5645 from gaoxm/improveCrossWayCheck 
Improve cross way check
 2018-12-21 14:16:47 -05:00
Quincy Morgan
dc3a42f33d Fixed validation-related linting errors 2018-12-21 14:08:35 -05:00
Xiaoming Gao
dee005e9aa Improve cross way check 
1. Add more way types and relation types to check
2. Add more legit crossing cases
3. Add tests for 1 and 2
 2018-12-21 14:00:31 -05:00
Quincy Morgan
627b4ee732 Fixed an bug where the wrong feature could be deleted from the untagged feature issue fix 2018-12-21 14:00:08 -05:00
Quincy Morgan
c9350c632e Add issue fixes UI 
Add two issue fixes for untagged feature
 2018-12-21 12:31:33 -05:00
Andrew Wong
67bab7aecf don't import all of d3 2018-12-20 16:31:32 -05:00
Andrew Wong
5971bbebb7 Added more validation tests 2018-12-20 15:39:26 -05:00
Quincy Morgan
d58867df7c Add entity display label util function 
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
 2018-12-20 14:04:15 -05:00
Quincy Morgan
d7ef2de073 Re-organizes issue messages and tooltips 2018-12-20 12:16:54 -05:00
Xiaoming Gao
a4e1012c91 add crossing_way validation 
Tests are also added and passed.

One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
 2018-12-19 19:23:35 -05:00
Andrew Wong
6e749c70ef listening to user generated history changes for validation 2018-12-19 17:28:34 -05:00
Quincy Morgan
490143d1a8 Added Issues section to the entity sidebar 
Fixed bug where stale issues would stick around in the issues pane
 2018-12-19 16:12:33 -05:00
Quincy Morgan
59b0252b0e Fixed several linting errors 2018-12-19 13:22:48 -05:00
Quincy Morgan
6a931f9be6 Added colors to issue list icons 
Corrected icon for warnings
Made disconnected_highway issue a warning instead of an error
 2018-12-19 13:07:47 -05:00
Quincy Morgan
ff95e6a337 Merge branch 'validationIssueDataModel' into validation 2018-12-19 10:59:45 -05:00
Quincy Morgan
903cb63efe Renamed validations to issues in relevant places 
Made the issue pane get the issues from the issue manager rather than validating itself
 2018-12-19 10:41:58 -05:00
Xiaoming Gao
07a53fe6ea Extend data model for validation issues 
Add the Issues pane

1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
  (1) add a severity level field (useful for identify save-blocking issues later)
  (2) replace single entity with an array of entities (useful for issues involving multiple entities)
  (3) add a coordinates field for highlighting the location of the issue on the map
  (4) add a fixes field for possible automatic fixes

3. Update existing validation modules to use the new data model
 2018-12-19 10:37:32 -05:00
Quincy Morgan
0d0521c936 Moved feature applicability into the issue manager class 2018-12-19 10:32:14 -05:00
Quincy Morgan
161311faa5 Merge pull request #5626 from wonga00/wonga_issue_manager 
added IssueManager
 2018-12-18 18:05:40 -05:00
Quincy Morgan
858a9606d5 Added entity display name or preset name to the disconnected highway message 2018-12-18 18:05:27 -05:00
Andrew Wong
30f25c6e8d added IssueManager 
- IssueManager performs validation on the current graph and also
   stores the issues and notifies listeners when the issues changed
 2018-12-18 17:52:23 -05:00
Bryan Housel
5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00