Commit Graph

1895 Commits

Author SHA1 Message Date
SilentSpike
51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
SilentSpike
03a097c847 Move Osmose translation link below details box 2020-02-04 21:44:20 +00:00
SilentSpike
377e99240f Add Osmose translations link to details footer
Improves structure of the details UI and introduces the use of flexboxes
for this. Does not break UI for other error services with shared classes.
2020-02-03 23:20:45 +00:00
SilentSpike
1dd65cb93e Correct Osmose UI element spacing 2020-02-03 23:20:45 +00:00
SilentSpike
ecadafb3e4 Use Osmose supplied hex colors 2020-02-03 23:20:45 +00:00
SilentSpike
e3c6f58624 Format markdown in Osmose strings appropriately 2020-02-03 23:20:44 +00:00
SilentSpike
5d93d3cace Prepare to use Osmose issue detail strings
- Remove translation description strings, will be using supplied
translations once the API is updated
- Change the way elements and details are presented since they can't be
easily integrated into the 3rd party description strings
2020-02-03 23:20:44 +00:00
SilentSpike
9fca611ec1 Add support for even more Osmose error types
- Conflicting tags
- Orthographic errors (excess whitespace and all capital names)
- Deprecated tagging
- Bad use of the "area" tag
2020-02-03 23:20:43 +00:00
SilentSpike
406264c37e Simplify structure of QA error data 2020-02-03 23:20:42 +00:00
SilentSpike
a53f1c0f67 Add support for Osmose unnecessary tag error type 2020-02-03 23:20:42 +00:00
SilentSpike
c13eb15691 Add support for more Osmose error types
- Unconnected level crossings
- Unconnected highway features/barries
- Unexpected punctuation/symbols in tag values
- Unbalanced parentheses/quotes in name values
- Invalid date formats
- Access tagging that permits all transport modes
- Elements with a "name" tag and no main tagging
- Relations missing a "type" value
2020-02-03 23:20:42 +00:00
SilentSpike
896ed762e0 Fix silent failure for some Osmose error types
When I added special handling for mapillary errors the code was trying
to access translation strings nested under the error category (which
doesn't exist for all error types). This code is now moved into it's own
function so that variable hoisting doesn't run it for non-applicable
error types and prevent them from working.

- Also adds support for error type 3040 (bad tag value)
- Updated the Osmose sidebar UI title
2020-02-03 23:20:41 +00:00
SilentSpike
d4723ec9e2 Read icons from qa_errors.json when building data
Also adds support for the following error types:
- Objects mapped as both node/area or way/area
- Power lines that lead to nowhere
- Extra nodes in power lines (which should only go from support to
support to endpoint)
- Power line supports with no power lines
2020-02-03 23:20:30 +00:00
SilentSpike
5afdfc527b Add support for more Osmose error types
- Missing parking access
- Malformed opening hours tagging
- Objects detected by Mapillary that aren't mapped
- Traffic sign information detected by Mapillary that isn't mapped

Mapillary errors add example code for special error type handling as
they don't need to request further details and can use piecewise
translation strings
2020-02-03 23:01:03 +00:00
SilentSpike
680fdb6b54 Allow Osmose errors to use category for UI strings
Some error types don't require unique strings and can share common
strings among the category. This makes that possible as well as adding
support for some other types of error for demonstrative purposes.
2020-02-03 23:01:02 +00:00
SilentSpike
09e7b23665 Add Osmose issues UI and filtering
Filters out errors not present in the data .json file to enable
selective support since Osmose has a wide variety of errors which may be
too advanced for iD.

Also added processing for the elements associated with an error for
forced visibility and highlighting.
2020-02-03 23:01:01 +00:00
SilentSpike
e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Quincy Morgan
4a5e988762 Leave a margin at the bottom of the inspector regardless of whether the relation membership section is shown 2020-02-03 10:47:23 -05:00
Quincy Morgan
af928e3dc1 Support radio fields during multiselections 2020-01-31 13:02:30 -05:00
Quincy Morgan
1b331bb678 Add mechanism for fields to support editing during multiselection (re: #7276)
Add `utilCombinedTags` method and use it for the raw tag editor as well as fields
Pass `entityIDs` array into fields instead of single `entity` object
Give field revertion its own path separate from `change`
Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
2020-01-30 13:53:29 -05:00
Quincy Morgan
d7e4575a7b Update to temaki 3.13.0 (close #7298)
Add new rail icons (close #7255)
Render "statused" railways with lighter colors
Don't render disused features with a dashed stroke
2020-01-28 11:42:53 -05:00
Quincy Morgan
3dc0361dc8 Add improved "zoom to" icon 2020-01-22 12:43:24 -05:00
Quincy Morgan
fd2b97331c Add label to "change feature type" button in inspector and make it a collapsible section (close #6811) 2020-01-22 09:19:54 -05:00
Quincy Morgan
75cd49e390 Fix preset button label height in Safari 2020-01-22 09:18:39 -05:00
Quincy Morgan
6bb2997306 Enable changing the preset of multiple selected features (re: #7276)
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Quincy Morgan
a364c52f47 Make "Multiple Values" placeholder italic 2020-01-20 13:55:38 -05:00
Quincy Morgan
512453d54c Add min-height to text tag editor 2020-01-20 13:08:50 -05:00
Quincy Morgan
48bda8ba67 Move selected feature list to a collapsible inspector section (close #7273) 2020-01-20 11:34:51 -05:00
Quincy Morgan
eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Quincy Morgan
b56076ca61 Remove usage of fixed CSS positioning 2020-01-14 19:32:19 -05:00
Quincy Morgan
9450387e05 Fix some CSS declarations 2020-01-09 14:47:26 -05:00
Quincy Morgan
20fd66630b Update semicombo reordering (re: #7024):
Don't try reordering multiCombo fields
Fix offset behavior for full-width semicombos
Use grab/grabbing cursor style
Keep dragged chip above others
2020-01-09 14:43:18 -05:00
Quincy Morgan
dd2ad8f70e Make brand preset subtitle normal weight 2020-01-03 12:32:23 -05:00
Quincy Morgan
b557461d0b Fix errant wetland area CSS 2019-12-24 10:05:11 -05:00
Quincy Morgan
acfd1af5b2 Fix errant CSS 2019-12-23 16:25:24 -05:00
Quincy Morgan
f6769238ed Revert references to the v3 UI in the Keyboard Shortcuts menu
Remove unused preset favoriting functionality
2019-12-20 12:05:04 -05:00
Bryan Housel
ada4fb5814 Add privacy policy version check to context and splash screen
(closes #7040)

A few other minor things in this commit
- migrated several ui modal files to ES6 syntax
- switched the splash link from ideditor.org -> ideditor.blog
2019-12-19 00:11:40 -05:00
Quincy Morgan
7f76e00bed Use constant width for unsquare building degree threshold input (re: #7126) 2019-12-18 12:38:15 -05:00
Quincy Morgan
e8d154a529 Remove old, unused implementations of favorite, recent, and search-to-add preset toolbar items 2019-12-18 11:25:31 -05:00
Bryan Housel
27f538b0cf Add Preferences Pane, Third Party Icon toggle, link to policy
(re: #7040)
2019-12-16 22:27:06 -05:00
Quincy Morgan
523a467836 2.x: Make toolbar horizontally scrollable when it overflows (re: #6755, re: 7545f67063b5e7007ef2d8367e3181e59c04a487)
Generalize tooltip into popover control
Use the same popover control for tooltip as the preset browser and tools list popovers
Smartly position the preset browser popover and menu bar tooltips to stay fully onscreen
Position most tooltips closer to their controls
Fix small gap that could appear between a tooltip and its arrow
Allow wider toolbar tooltips
2019-12-16 13:30:07 -05:00
Quincy Morgan
9ad59912be Fix issue where the raw member editor did not have the expected padding (close #7115) 2019-12-13 15:23:11 -05:00
Quincy Morgan
6cbdb41e2d 2.x: Use keyboard styling for shortcuts in tooltips (re: #6574, re: a579e35fcc51d76f55eca16c7524d95c59b66c26) 2019-12-13 14:07:59 -05:00
Quincy Morgan
7473d32e31 2.x: Highlight relation members in yellow when a relation is selected, including in a multi-selection (re: #5766, re: cf2935576511a1b9f5aac47407ed2b0ce803902a) 2019-12-13 11:20:40 -05:00
Quincy Morgan
df3b281d39 Fix mapillary detection selection rendering in Firefox and Safari (close #6804)
Fix mapillary feature detection tooltips (re: #7079)
2019-12-11 15:03:54 -05:00
Quincy Morgan
00e8a125e2 Make point markers more circular with larger icons (close #6163)
Tweak the grey style of points linked to wikidata
2019-12-09 17:21:33 -05:00
Bryan Housel
baca525117 User lighter green fill for golf=green
(closes #7101)

This also adds fill styles for the other light-green things like cemetaries
vineyards, etc.. For some reason they didn't have fill styles before so only
the strokes were being styled light green.
2019-12-09 10:10:03 -05:00
Quincy Morgan
b028a678f3 Fix checkbox alignment and padding (close #7091) 2019-12-06 10:26:23 -05:00
Quincy Morgan
c1f7721197 Reload API status automatically when a response indicates a probable change in status (close #6650)
Make API status messages more informative (close #7021)
Add manual Retry button to "unable to connect" API status message (close #5864)
2019-12-05 17:17:57 -05:00
Quincy Morgan
e83c0940bf Add field for ref:vatin (close #6880) 2019-12-04 11:50:10 -05:00