Commit Graph

480 Commits

Author SHA1 Message Date
SilentSpike
51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
SilentSpike
03a097c847 Move Osmose translation link below details box 2020-02-04 21:44:20 +00:00
SilentSpike
377e99240f Add Osmose translations link to details footer
Improves structure of the details UI and introduces the use of flexboxes
for this. Does not break UI for other error services with shared classes.
2020-02-03 23:20:45 +00:00
SilentSpike
1dd65cb93e Correct Osmose UI element spacing 2020-02-03 23:20:45 +00:00
SilentSpike
e3c6f58624 Format markdown in Osmose strings appropriately 2020-02-03 23:20:44 +00:00
SilentSpike
5d93d3cace Prepare to use Osmose issue detail strings
- Remove translation description strings, will be using supplied
translations once the API is updated
- Change the way elements and details are presented since they can't be
easily integrated into the 3rd party description strings
2020-02-03 23:20:44 +00:00
Quincy Morgan
4a5e988762 Leave a margin at the bottom of the inspector regardless of whether the relation membership section is shown 2020-02-03 10:47:23 -05:00
Quincy Morgan
af928e3dc1 Support radio fields during multiselections 2020-01-31 13:02:30 -05:00
Quincy Morgan
1b331bb678 Add mechanism for fields to support editing during multiselection (re: #7276)
Add `utilCombinedTags` method and use it for the raw tag editor as well as fields
Pass `entityIDs` array into fields instead of single `entity` object
Give field revertion its own path separate from `change`
Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
2020-01-30 13:53:29 -05:00
Quincy Morgan
3dc0361dc8 Add improved "zoom to" icon 2020-01-22 12:43:24 -05:00
Quincy Morgan
fd2b97331c Add label to "change feature type" button in inspector and make it a collapsible section (close #6811) 2020-01-22 09:19:54 -05:00
Quincy Morgan
75cd49e390 Fix preset button label height in Safari 2020-01-22 09:18:39 -05:00
Quincy Morgan
6bb2997306 Enable changing the preset of multiple selected features (re: #7276)
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Quincy Morgan
a364c52f47 Make "Multiple Values" placeholder italic 2020-01-20 13:55:38 -05:00
Quincy Morgan
512453d54c Add min-height to text tag editor 2020-01-20 13:08:50 -05:00
Quincy Morgan
48bda8ba67 Move selected feature list to a collapsible inspector section (close #7273) 2020-01-20 11:34:51 -05:00
Quincy Morgan
eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Quincy Morgan
b56076ca61 Remove usage of fixed CSS positioning 2020-01-14 19:32:19 -05:00
Quincy Morgan
9450387e05 Fix some CSS declarations 2020-01-09 14:47:26 -05:00
Quincy Morgan
20fd66630b Update semicombo reordering (re: #7024):
Don't try reordering multiCombo fields
Fix offset behavior for full-width semicombos
Use grab/grabbing cursor style
Keep dragged chip above others
2020-01-09 14:43:18 -05:00
Quincy Morgan
dd2ad8f70e Make brand preset subtitle normal weight 2020-01-03 12:32:23 -05:00
Quincy Morgan
f6769238ed Revert references to the v3 UI in the Keyboard Shortcuts menu
Remove unused preset favoriting functionality
2019-12-20 12:05:04 -05:00
Bryan Housel
ada4fb5814 Add privacy policy version check to context and splash screen
(closes #7040)

A few other minor things in this commit
- migrated several ui modal files to ES6 syntax
- switched the splash link from ideditor.org -> ideditor.blog
2019-12-19 00:11:40 -05:00
Quincy Morgan
7f76e00bed Use constant width for unsquare building degree threshold input (re: #7126) 2019-12-18 12:38:15 -05:00
Quincy Morgan
e8d154a529 Remove old, unused implementations of favorite, recent, and search-to-add preset toolbar items 2019-12-18 11:25:31 -05:00
Bryan Housel
27f538b0cf Add Preferences Pane, Third Party Icon toggle, link to policy
(re: #7040)
2019-12-16 22:27:06 -05:00
Quincy Morgan
523a467836 2.x: Make toolbar horizontally scrollable when it overflows (re: #6755, re: 7545f67063b5e7007ef2d8367e3181e59c04a487)
Generalize tooltip into popover control
Use the same popover control for tooltip as the preset browser and tools list popovers
Smartly position the preset browser popover and menu bar tooltips to stay fully onscreen
Position most tooltips closer to their controls
Fix small gap that could appear between a tooltip and its arrow
Allow wider toolbar tooltips
2019-12-16 13:30:07 -05:00
Quincy Morgan
9ad59912be Fix issue where the raw member editor did not have the expected padding (close #7115) 2019-12-13 15:23:11 -05:00
Quincy Morgan
6cbdb41e2d 2.x: Use keyboard styling for shortcuts in tooltips (re: #6574, re: a579e35fcc51d76f55eca16c7524d95c59b66c26) 2019-12-13 14:07:59 -05:00
Quincy Morgan
b028a678f3 Fix checkbox alignment and padding (close #7091) 2019-12-06 10:26:23 -05:00
Quincy Morgan
c1f7721197 Reload API status automatically when a response indicates a probable change in status (close #6650)
Make API status messages more informative (close #7021)
Add manual Retry button to "unable to connect" API status message (close #5864)
2019-12-05 17:17:57 -05:00
Quincy Morgan
e83c0940bf Add field for ref:vatin (close #6880) 2019-12-04 11:50:10 -05:00
Quincy Morgan
6c7d8b6150 Add identifier field for tags linking features to external databases
Add US-only field for `gnis:feature_id` (close #7086)
Add tooltip to wikipedia field link button
2019-12-03 20:47:10 -05:00
Quincy Morgan
9d367d133f Cherry pick preset image error fallback 2019-11-07 20:12:18 +01:00
Bryan Housel
86a5652b37 Add I for Issues pane to keyboard shortcut screen, improve spacing
(closes #6997)
2019-11-04 10:06:31 -05:00
Quincy Morgan
2aa7c3cbf2 Tweak bottom bar chip padding and update changelog 2019-10-14 17:40:28 +02:00
Quincy Morgan
949ec8afa0 Add issue count badges to the bottom info bar when validating Everything 2019-10-14 17:14:47 +02:00
Quincy Morgan
9a2f58d5ef Fix several right-to-left layout issues 2019-10-14 12:04:57 +02:00
Quincy Morgan
a97f05c9dc Disable zoom in/out buttons when at max or min zoom already (close #6847) 2019-09-18 15:56:32 -04:00
Matias Volpe
8e616d7384 feat: add Mapillary Map Features layer 2019-08-22 15:16:31 -03:00
Quincy Morgan
1a1cae06d4 Merge pull request #6701 from Kartkod/keyboard-access
Minor keyboard accessibility improvements
2019-08-22 12:27:15 -05:00
Quincy Morgan
d44d70847d Flexbox the background and map data layer lists 2019-08-03 12:24:56 -04:00
Albin Larsson
30e45413c7 align hover and focus styles 2019-07-31 08:25:02 +02:00
Bryan Housel
44349c8015 Swap wikidata/wikipedia for brand: tags if possible
(closes #6416)

This also ignores any features with an office tag, to avoid
changing a wikipedia/wikidata tag on a corporate office.
2019-05-24 14:24:10 -04:00
Bryan Housel
b4ebaaa01e Fix raw tag editor styling for custom data editor
(closes #6427)
2019-05-24 11:32:14 -04:00
Quincy Morgan
9d5783d507 Improve padding of chiplist 2019-05-23 15:51:11 -04:00
Quincy Morgan
35b3102006 Add Disable All and Enable All buttons for the Map Features list (close #5234) 2019-05-22 11:56:04 -04:00
Quincy Morgan
fa1cd78054 Adjust lock icon margin 2019-05-21 09:26:10 -04:00
Bryan Housel
e1331016d1 Merge pull request #6386 from openstreetmap/configurable-squareness
Allow user to adjust the threshold for the unsquare building warning
2019-05-20 21:04:30 -04:00
Bryan Housel
69a25fd6aa Move locking code from input and localized up to uiField
Also adjust styles some more for wikidata tagged items
2019-05-20 17:50:50 -04:00