Commit Graph

2092 Commits

Author SHA1 Message Date
Quincy Morgan
ffe4aa09f4 Pass entity array into validators instead of changes object 2019-01-24 15:26:19 -05:00
Quincy Morgan
a259a9acf1 Add more deprecated tag data from https://wiki.openstreetmap.org/wiki/Deprecated_features
Run deprecated_tag validation on modified as well as created features
2019-01-24 15:09:02 -05:00
Quincy Morgan
b21dd1d5d6 Add tooltip and updated message to deprecated_tags validation issue
Add a quick fix to upgrade deprecated tags
Add more deprecated tag data
2019-01-24 14:09:12 -05:00
Quincy Morgan
33ae009936 Clarify wording of old_multipolygon issue and tooltip
Add quick fix for old_multipolygon issue
2019-01-24 11:01:41 -05:00
Quincy Morgan
981ed9ef8c Integrate the generic_name validation into the new validations framework 2019-01-24 09:28:59 -05:00
Quincy Morgan
01e2370cbd Add background color to the issue pane list 2019-01-24 08:37:46 -05:00
Quincy Morgan
7b288ef95d Add basic zoom-to-clicked-issue behavior 2019-01-23 15:25:55 -05:00
Quincy Morgan
4389bd8741 Merge pull request #5723 from gaoxm/almostJunctAutoFix
add auto-fix for almost junction by creating connection nodes
2019-01-23 13:24:48 -05:00
Quincy Morgan
e69f2a0389 Merge branch 'master' into validation 2019-01-23 13:15:33 -05:00
Quincy Morgan
24b6e9aeec v2.13.0 2019-01-23 11:33:23 -05:00
Bryan Housel
a873c0f2ca Remove unused, add maprules documentation 2019-01-23 11:08:19 -05:00
Bryan Housel
fa1edc86a1 Another place where we should delimit name suggestion on en-dash
see 20bcfc573
2019-01-23 09:57:43 -05:00
Bryan Housel
20bcfc5730 Delimit name-suggestion-preset names on en-dash, not hyphen
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
2019-01-23 09:44:24 -05:00
Bryan Housel
b3953e4a31 Don't mix up inflight tile requests with inflight keepright updates
(closes #5748)
2019-01-22 23:20:17 -05:00
Bryan Housel
4583e2d4d7 Make sure all combo event listeners can handle accept/cancel w/o datum
(re: #5637, re: #5618)

This can happen if the user enters a value that is not matched to
one of the combo suggestions.

Also make sure to set `this` to the input field.  It might not be
already if the event was triggered from a keypress instead of a click.
2019-01-22 23:14:34 -05:00
Bryan Housel
0c7b9a631e Improve combobox event handling and avoid overwriting typed data
(closes #5722, re: #5637, re: #5618)

dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)

Fix for this coming in next commit.
2019-01-22 22:26:27 -05:00
Quincy Morgan
949337249b Improved performance of multipolygon line-as-area rendering check 2019-01-22 14:10:42 -05:00
Quincy Morgan
e83bdbb181 Fixed an issue where non-trivial line components of multipolygons were not rendered as lines 2019-01-22 13:51:44 -05:00
Quincy Morgan
0499a76443 Fixed an entity not found error when restoring new ways that reference unloaded nodes (closed #4108, closed #5194) 2019-01-22 12:56:37 -05:00
Quincy Morgan
1323ec3d5a Map Data and Background panes no longer reload hidden sections 2019-01-21 15:52:58 -05:00
Quincy Morgan
35ac247ff0 Fixes an issue where panel sections wouldn't render when toggled if hidden on page load (closes #5743) 2019-01-21 15:22:50 -05:00
Quincy Morgan
a7e713da15 Fixed an issue in the Areas walkthrough chapter where the user could not proceed after adding the Description field 2019-01-21 11:51:25 -05:00
Minh Nguyễn
9e3d49efb7 Replace wkid/w/s/n/e in WMS URL templates 2019-01-19 15:42:22 -08:00
Bryan Housel
2df39c1dc7 Escape all .s in imagery identifiers, not just the first one
(closes #5737)
2019-01-19 10:53:09 -05:00
Bryan Housel
1ec5b708fc Restore default click behaviors on mousedown of a combobox
(closes #5732)
2019-01-18 23:23:35 -05:00
Bryan Housel
087c38e8fd Avoid calling changeRole recursively
(closes #5731)
2019-01-18 18:20:47 -05:00
Bryan Housel
4e3def9ce8 Fix the width of the add-tag and add-relation buttons
(closes #5729)
2019-01-18 13:48:17 -05:00
Quincy Morgan
46beb31e74 Removed extra padding in comboboxes when the caret is hidden 2019-01-18 11:59:40 -05:00
Quincy Morgan
bf2574f4e3 Hide the dropdown arrow in combo fields if there are no suggestions from tagInfo (closes #5730) 2019-01-18 11:21:31 -05:00
Quincy Morgan
bc81a62a58 Made the value chips in the Destinations semiCombo field full-width to mimic the layout of highway signs (re: #4178)
The input and combobox caret elements in the multicombo field value list are now wrapped in a li element for consistency
2019-01-18 10:41:51 -05:00
Quincy Morgan
77cfde7913 combo, multiCombo, and semiCombo fields now correctly submit the typed value upon pressing enter/return without deselecting the feature (closes #5725) 2019-01-17 15:42:35 -05:00
Quincy Morgan
bb4d0a9282 Fixes false error when a preset inherits fields from a preset with no fields 2019-01-17 15:40:42 -05:00
Bryan Housel
e37dbbd3e1 Style preset icon fill with building if it has a building_area field
These are presets that default to `building=yes` so they should look like
buildings.
2019-01-17 14:28:57 -05:00
Bryan Housel
445b585b27 Use arrays instead of string concat for classparts
(less brittle than keeping track of spaces)
2019-01-17 14:01:50 -05:00
Quincy Morgan
90637bdcfa Fixed an issue where the cycleway field would throw an error when added from the "Add field:" dropdown 2019-01-17 12:32:14 -05:00
Bryan Housel
89e45225b8 Style multipolygon inner/outers as areas not lines 2019-01-17 12:32:45 -05:00
Quincy Morgan
9f7ef21e5c The additional fields dropdown now mixes universal and moreFields and is sorted alphabetically 2019-01-17 11:37:05 -05:00
Quincy Morgan
9ad217dce3 Fixed broken preset field inheritance 2019-01-17 09:49:48 -05:00
Bryan Housel
3e12a85fa1 Merge pull request #5717 from nyurik/wikilink
Add wiki links from tag description
2019-01-17 00:10:45 -05:00
Bryan Housel
a9ac1bda97 Fix issues causing mode/undo/save buttons to be missing disabled style 2019-01-17 00:06:57 -05:00
Bryan Housel
0773fedb8f Fix undefined fieldID.indexOf('{') > -1 causing tests to fail 2019-01-16 22:13:56 -05:00
Xiaoming Gao
aa5f1aec5b add auto-fix for almost junction by creating connection nodes 2019-01-16 20:02:25 -05:00
Yuri Astrakhan
3caf6eabed remove non local non en wiki links 2019-01-16 15:00:20 -05:00
Yuri Astrakhan
54b4a798b1 Localize language name 2019-01-16 14:35:47 -05:00
Bryan Housel
3fe6c0dbe7 Support more eased transitions, cleanup code
(re: #3967, #5169, #5407)
2019-01-16 13:42:32 -05:00
Quincy Morgan
1bfb9ac0c0 Updated almost junction issue message and tooltip to be better aligned with other issues
Added a quick fix for setting the almost junction node as noexit
2019-01-16 10:02:05 -05:00
Quincy Morgan
c1049b620b Merge branch 'master' into validation 2019-01-16 08:57:21 -05:00
Bryan Housel
460d144c66 Use centerZoomEase for smoother walkthrough transitions 2019-01-16 01:32:15 -05:00
Bryan Housel
91bfac5861 Add map.centerZoomEase and simplify internal center/zoom code
(closes #3967)
2019-01-16 01:31:26 -05:00
Yuri Astrakhan
9ed347534b Remove unused import 2019-01-15 21:59:05 -05:00