Autofix for ruff

docs/command_completion.md

@@ -8,7 +8,7 @@ To enable it, you need to manually register a special function with your shell,
 
 The following describes how to generate the command completion scripts and add them to your shell configuration. 
 
-> **Note: You will need to start a new shell for the changes to take effect.**
+`You will need to start a new shell for the changes to take effect.`
 
 ### For Bash
 
@@ -16,11 +16,8 @@ The following describes how to generate the command completion scripts and add t
 # Generates bash completion scripts
 echo "$(_MVT_IOS_COMPLETE=bash_source mvt-ios)" > ~/.mvt-ios-complete.bash &&
 echo "$(_MVT_ANDROID_COMPLETE=bash_source mvt-android)" > ~/.mvt-android-complete.bash
-```
 
-Add the following to `~/.bashrc`:
-```bash
-# source mvt completion scripts
+# Sources the scripts in ~/.bashrc.
 . ~/.mvt-ios-complete.bash && .  ~/.mvt-android-complete.bash
 ```
 
@@ -30,11 +27,8 @@ Add the following to `~/.bashrc`:
 # Generates zsh completion scripts
 echo "$(_MVT_IOS_COMPLETE=zsh_source mvt-ios)" >  ~/.mvt-ios-complete.zsh &&
 echo "$(_MVT_ANDROID_COMPLETE=zsh_source mvt-android)" > ~/.mvt-android-complete.zsh
-```
 
-Add the following to `~/.zshrc`:
-```bash
-# source mvt completion scripts
+# Sources the scripts in ~/.zshrc.
 .  ~/.mvt-ios-complete.zsh  && .  ~/.mvt-android-complete.zsh
 ```
 

docs/install.md

@@ -98,7 +98,3 @@ You now should have the `mvt-ios` and `mvt-android` utilities installed.
 **Notes:**
 1. The `--force` flag is necessary to force the reinstallation of the package.
 2. To revert to using a PyPI version, it will be necessary to `pipx uninstall mvt` first.
-
-## Setting up command completions
-
-See ["Command completions"](command_completion.md)

src/mvt/common/version.py

@@ -3,4 +3,4 @@
 # Use of this software is governed by the MVT License 1.1 that can be found at
 #   https://license.mvt.re/1.1/
 
-MVT_VERSION = "2.6.0"
+MVT_VERSION = "2.5.4"

src/mvt/ios/data/ios_versions.json

@@ -1095,9 +1095,5 @@
     {
         "version": "18.2",
         "build": "22C152"
-    },
-    {
-        "version": "18.2.1",
-        "build": "22C161"
     }
 ]

src/mvt/ios/modules/net_base.py

@@ -38,70 +38,44 @@ class NetBase(IOSExtraction):
 
     def _extract_net_data(self):
         conn = sqlite3.connect(self.file_path)
-        conn.row_factory = sqlite3.Row
         cur = conn.cursor()
-        try:
-            cur.execute(
-                """
-                SELECT
-                    ZPROCESS.ZFIRSTTIMESTAMP,
-                    ZPROCESS.ZTIMESTAMP,
-                    ZPROCESS.ZPROCNAME,
-                    ZPROCESS.ZBUNDLENAME,
-                    ZPROCESS.Z_PK AS ZPROCESS_PK,
-                    ZLIVEUSAGE.ZWIFIIN,
-                    ZLIVEUSAGE.ZWIFIOUT,
-                    ZLIVEUSAGE.ZWWANIN,
-                    ZLIVEUSAGE.ZWWANOUT,
-                    ZLIVEUSAGE.Z_PK AS ZLIVEUSAGE_PK,
-                    ZLIVEUSAGE.ZHASPROCESS,
-                    ZLIVEUSAGE.ZTIMESTAMP AS ZL_TIMESTAMP
-                FROM ZLIVEUSAGE
-                LEFT JOIN ZPROCESS ON ZLIVEUSAGE.ZHASPROCESS = ZPROCESS.Z_PK
-                UNION
-                SELECT ZFIRSTTIMESTAMP, ZTIMESTAMP, ZPROCNAME, ZBUNDLENAME, Z_PK,
-                    NULL, NULL, NULL, NULL, NULL, NULL, NULL
-                FROM ZPROCESS WHERE Z_PK NOT IN
-                    (SELECT ZHASPROCESS FROM ZLIVEUSAGE);
+        cur.execute(
             """
-            )
-        except sqlite3.OperationalError:
-            # Recent phones don't have ZWIFIIN and ZWIFIOUT columns
-            cur.execute(
-                """
-                SELECT
-                    ZPROCESS.ZFIRSTTIMESTAMP,
-                    ZPROCESS.ZTIMESTAMP,
-                    ZPROCESS.ZPROCNAME,
-                    ZPROCESS.ZBUNDLENAME,
-                    ZPROCESS.Z_PK AS ZPROCESS_PK,
-                    ZLIVEUSAGE.ZWWANIN,
-                    ZLIVEUSAGE.ZWWANOUT,
-                    ZLIVEUSAGE.Z_PK AS ZLIVEUSAGE_PK,
-                    ZLIVEUSAGE.ZHASPROCESS,
-                    ZLIVEUSAGE.ZTIMESTAMP AS ZL_TIMESTAMP
-                FROM ZLIVEUSAGE
-                LEFT JOIN ZPROCESS ON ZLIVEUSAGE.ZHASPROCESS = ZPROCESS.Z_PK
-                UNION
-                SELECT ZFIRSTTIMESTAMP, ZTIMESTAMP, ZPROCNAME, ZBUNDLENAME, Z_PK,
-                    NULL, NULL, NULL, NULL, NULL
-                FROM ZPROCESS WHERE Z_PK NOT IN
-                    (SELECT ZHASPROCESS FROM ZLIVEUSAGE);
-            """
-            )
+            SELECT
+                ZPROCESS.ZFIRSTTIMESTAMP,
+                ZPROCESS.ZTIMESTAMP,
+                ZPROCESS.ZPROCNAME,
+                ZPROCESS.ZBUNDLENAME,
+                ZPROCESS.Z_PK,
+                ZLIVEUSAGE.ZWIFIIN,
+                ZLIVEUSAGE.ZWIFIOUT,
+                ZLIVEUSAGE.ZWWANIN,
+                ZLIVEUSAGE.ZWWANOUT,
+                ZLIVEUSAGE.Z_PK,
+                ZLIVEUSAGE.ZHASPROCESS,
+                ZLIVEUSAGE.ZTIMESTAMP
+            FROM ZLIVEUSAGE
+            LEFT JOIN ZPROCESS ON ZLIVEUSAGE.ZHASPROCESS = ZPROCESS.Z_PK
+            UNION
+            SELECT ZFIRSTTIMESTAMP, ZTIMESTAMP, ZPROCNAME, ZBUNDLENAME, Z_PK,
+                   NULL, NULL, NULL, NULL, NULL, NULL, NULL
+            FROM ZPROCESS WHERE Z_PK NOT IN
+                (SELECT ZHASPROCESS FROM ZLIVEUSAGE);
+        """
+        )
 
         for row in cur:
             # ZPROCESS records can be missing after the JOIN.
             # Handle NULL timestamps.
-            if row["ZFIRSTTIMESTAMP"] and row["ZTIMESTAMP"]:
-                first_isodate = convert_mactime_to_iso(row["ZFIRSTTIMESTAMP"])
-                isodate = convert_mactime_to_iso(row["ZTIMESTAMP"])
+            if row[0] and row[1]:
+                first_isodate = convert_mactime_to_iso(row[0])
+                isodate = convert_mactime_to_iso(row[1])
             else:
-                first_isodate = row["ZFIRSTTIMESTAMP"]
-                isodate = row["ZTIMESTAMP"]
+                first_isodate = row[0]
+                isodate = row[1]
 
-            if row["ZL_TIMESTAMP"]:
-                live_timestamp = convert_mactime_to_iso(row["ZL_TIMESTAMP"])
+            if row[11]:
+                live_timestamp = convert_mactime_to_iso(row[11])
             else:
                 live_timestamp = ""
 
@@ -109,18 +83,16 @@ class NetBase(IOSExtraction):
                 {
                     "first_isodate": first_isodate,
                     "isodate": isodate,
-                    "proc_name": row["ZPROCNAME"],
-                    "bundle_id": row["ZBUNDLENAME"],
-                    "proc_id": row["ZPROCESS_PK"],
-                    "wifi_in": row["ZWIFIIN"] if "ZWIFIIN" in row.keys() else None,
-                    "wifi_out": row["ZWIFIOUT"] if "ZWIFIOUT" in row.keys() else None,
-                    "wwan_in": row["ZWWANIN"],
-                    "wwan_out": row["ZWWANOUT"],
-                    "live_id": row["ZLIVEUSAGE_PK"],
-                    "live_proc_id": row["ZHASPROCESS"],
-                    "live_isodate": live_timestamp
-                    if row["ZL_TIMESTAMP"]
-                    else first_isodate,
+                    "proc_name": row[2],
+                    "bundle_id": row[3],
+                    "proc_id": row[4],
+                    "wifi_in": row[5],
+                    "wifi_out": row[6],
+                    "wwan_in": row[7],
+                    "wwan_out": row[8],
+                    "live_id": row[9],
+                    "live_proc_id": row[10],
+                    "live_isodate": live_timestamp if row[11] else first_isodate,
                 }
             )
 
@@ -136,6 +108,8 @@ class NetBase(IOSExtraction):
         )
         record_data_usage = (
             record_data + " "
+            f"WIFI IN: {record['wifi_in']}, "
+            f"WIFI OUT: {record['wifi_out']} - "
             f"WWAN IN: {record['wwan_in']}, "
             f"WWAN OUT: {record['wwan_out']}"
         )