fix(editor): Fix Paired item error message (#15171)

This commit is contained in:
Raúl Gómez Morales authored and GitHub committed 2025-05-08 15:40:46 +02:00
1 parent abb8225944
commit be72f736ac
4 files changed
+8 -8

No files matched your search

+1 -5
View File
@@ -299,11 +299,7 @@ describe('Projects', { disableAutoLogin: true }, () => {
workflowPage.actions.saveWorkflowOnButtonClick();
workflowPage.actions.addNodeToCanvas('Execute Workflow', true, true);
cy.window().then((win) => {
cy.stub(win, 'open').callsFake((url) => {
cy.visit(url);
});
});
cy.window().then((win) => cy.stub(win, 'open').callsFake((url) => cy.visit(url)));
selectResourceLocatorItem('workflowId', 0, 'Create a');
// Need to wait for the trigger node to auto-open after a delay
+1 -1
View File
@@ -117,7 +117,7 @@ describe('NDV', () => {
.nodeRunErrorMessage()
.should(
'have.text',
"Using the item method doesn't work with pinned data in this scenario. Please unpin 'Break pairedItem chain' and try again.",
"Paired item data for item from node 'Break pairedItem chain' is unavailable. Ensure 'Break pairedItem chain' is providing the required output.",
);
ndv.getters
.nodeRunErrorDescription()
+5 -1
View File
@@ -792,7 +792,11 @@ export class WorkflowDataProxy {
nodeCause: string,
usedMethodName: 'itemMatching' | 'pairedItem' | 'item' | '$getPairedItem' = 'pairedItem',
) => {
const message = `Using the ${usedMethodName} method doesn't work with pinned data in this scenario. Please unpin '${nodeCause}' and try again.`;
const pinData = getPinDataIfManualExecution(that.workflow, nodeCause, that.mode);
const message = pinData
? `Using the ${usedMethodName} method doesn't work with pinned data in this scenario. Please unpin '${nodeCause}' and try again.`
: `Paired item data for ${usedMethodName} from node '${nodeCause}' is unavailable. Ensure '${nodeCause}' is providing the required output.`;
return new ExpressionError(message, {
runIndex: that.runIndex,
itemIndex: that.itemIndex,
@@ -339,7 +339,7 @@ describe('WorkflowDataProxy', () => {
expect(error).toBeInstanceOf(ExpressionError);
const exprError = error as ExpressionError;
expect(exprError.message).toEqual(
"Using the item method doesn't work with pinned data in this scenario. Please unpin 'Break pairedItem chain' and try again.",
"Paired item data for item from node 'Break pairedItem chain' is unavailable. Ensure 'Break pairedItem chain' is providing the required output.",
);
expect(exprError.context.type).toEqual('paired_item_no_info');
done();