CalvinBackup/neuralchen-SimSwap
1
0
Fork 0
Code Issues 288 Pull Requests 16 Actions Packages Projects Releases 2 Wiki Activity

fixed bug that was making parser pick up unkown args from the environ… #64

Open
kaswani29 wants to merge 1 commits from kaswani29/parsing_bug_fix into main
pull from: kaswani29/parsing_bug_fix
merge into: CalvinBackup:main
Conversation 0 Commits 1 Files Changed 2 +573 -574
kaswani29 commented 2021-07-24 09:11:06 +02:00 (Migrated from github.com)
Copy Link

Fixed the bug where Arg parser was picking up unknown args making it crash. Eg in colab it was picking up jupyter runtime dir in root location. Similary, in pycharm iteractive environment it was picking up "--port=55649". Now we don't need the dummy variable -f in colab file as well.

Fixed the bug where Arg parser was picking up unknown args making it crash. Eg in colab it was picking up jupyter runtime dir in root location. Similary, in pycharm iteractive environment it was picking up "--port=55649". Now we don't need the dummy variable -f in colab file as well.
This pull request has changes conflicting with the target branch.
  • SimSwap colab.ipynb
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin kaswani29/parsing_bug_fix:kaswani29/parsing_bug_fix
git checkout kaswani29/parsing_bug_fix
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
GIF
GUI
Increase inference time
A solution to increase inference time
 bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CalvinBackup
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CalvinBackup/neuralchen-SimSwap#64
Delete Branch "kaswani29/parsing_bug_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?