CalvinBackup/tauri-plugins-workspace
1
0
Fork 0
mirror of https://github.com/tauri-apps/plugins-workspace.git synced 2026-09-22 21:30:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(log)!: take u64 in Builder::max_file_size (#3611)

Browse Source 
* refactor(log)!: take u64 in Builder::max_file_size

* Apply suggestion from @amrbashir

---------

Co-authored-by: Amr Bashir <github@amrbashir.me>
This commit is contained in:
Lucas Fernandes Nogueira
2026-09-22 06:07:06 -03:00
committed by GitHub
co-authored by Amr Bashir
parent fdfb35e531
commit 1a43e4701d
2 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changes/log-max-file-size-u64.md
+6
View File
@@ -0,0 +1,6 @@
---
"log": major
"log-js": major
---
**Breaking:** `Builder::max_file_size` now takes a `u64` instead of a `u128`.
plugins/log/src/lib.rs
+6 -9
View File
@@ -418,7 +418,7 @@ pub struct Builder {
rotation_strategy: RotationStrategy,
timezone_strategy: TimezoneStrategy,
file_open_strategy: FileOpenStrategy,
max_file_size: u128,
max_file_size: u64,
targets: Vec<Target>,
is_skip_logger: bool,
}
@@ -446,7 +446,7 @@ impl Default for Builder {
rotation_strategy: DEFAULT_ROTATION_STRATEGY,
timezone_strategy: DEFAULT_TIMEZONE_STRATEGY,
file_open_strategy: DEFAULT_FILE_OPEN_STRATEGY,
max_file_size: DEFAULT_MAX_FILE_SIZE as u128,
max_file_size: DEFAULT_MAX_FILE_SIZE,
targets: DEFAULT_LOG_TARGETS.into(),
is_skip_logger: false,
}
@@ -496,12 +496,9 @@ impl Builder {
/// Sets the maximum file size in bytes for log rotation.
///
/// Values larger than [`u64::MAX`] will be clamped to [`u64::MAX`].
/// In v3, this parameter will be changed to `u64`.
///
/// Default is `40_000`
pub fn max_file_size(mut self, max_file_size: u128) -> Self {
self.max_file_size = max_file_size.min(u64::MAX as u128);
pub fn max_file_size(mut self, max_file_size: u64) -> Self {
self.max_file_size = max_file_size;
self
}
@@ -839,7 +836,7 @@ impl Builder {
self.rotation_strategy,
self.timezone_strategy,
self.file_open_strategy,
self.max_file_size as u64,
self.max_file_size,
self.targets,
)?;
@@ -856,7 +853,7 @@ impl Builder {
self.rotation_strategy,
self.timezone_strategy,
self.file_open_strategy,
self.max_file_size as u64,
self.max_file_size,
self.targets,
)?;
attach_logger(max_level, log)?;