refactor(fs)!: remove the unwatch permission (#3606)

There has been no `unwatch` command since v2.0 (`Watcher.close()` releases
the resource), so `allow-unwatch` and `deny-unwatch` never granted anything.

.changes/fs-remove-unwatch.md

@@ -0,0 +1,5 @@
+---
+"fs": major
+---
+
+**Breaking:** Removed the `allow-unwatch` and `deny-unwatch` permissions. There has been no `unwatch` command since v2.0 (`Watcher.close()` releases the resource instead), so they never granted anything.

plugins/fs/build.rs

@@ -97,8 +97,6 @@ const COMMANDS: &[&str] = &[
     "fstat",
     "exists",
     "watch",
-    // TODO: Remove this in v3
-    "unwatch",
     "size",
     "start_accessing_security_scoped_resource",
     "stop_accessing_security_scoped_resource",

plugins/fs/permissions/autogenerated/reference.md

@@ -564,32 +564,6 @@ Denies the truncate command without any pre-configured scope.
 <tr>
 <td>
 
-`fs:allow-unwatch`
-
-</td>
-<td>
-
-Enables the unwatch command without any pre-configured scope.
-
-</td>
-</tr>
-
-<tr>
-<td>
-
-`fs:deny-unwatch`
-
-</td>
-<td>
-
-Denies the unwatch command without any pre-configured scope.
-
-</td>
-</tr>
-
-<tr>
-<td>
-
 `fs:allow-watch`
 
 </td>

plugins/fs/permissions/read-all.toml

@@ -16,5 +16,4 @@ commands.allow = [
   "fstat",
   "exists",
   "watch",
-  "unwatch",
 ]