CalvinBackup/tauri
1
0
Fork 0
mirror of https://github.com/tauri-apps/tauri.git synced 2026-04-01 10:01:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): revert #6680, remove default notification sound on Windows (#7229)

Browse Source 
fix(core): revert #6680, remove default notification sound on Windows
This commit is contained in:
Amr Bashir
2023-06-17 15:18:16 +03:00
committed by GitHub
parent 066c09a6ea
commit 6afd34727f
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changes/core-revet-windows-notification-default-sound.md Normal file
View File

@@ -0,0 +1,5 @@
---
'tauri': 'patch:bug'
---
Revert [#6680](https://github.com/tauri-apps/tauri/pull/6680) which added a default sound for notifications on Windows. This introduced inconsistency with other platforms that has silent notifications by default. In the upcoming releases, we will add support for modifying the notification sound across all platforms.

3
core/tauri/src/api/notification.rs
View File

@@ -119,9 +119,6 @@ impl Notification {
{
notification.app_id(&self.identifier);
}
// will be parsed as a `::winrt_notification::Sound`
notification.sound_name("Default");
}
#[cfg(target_os = "macos")]
{