CalvinBackup/tauri
1
0
Fork 0
mirror of https://github.com/tauri-apps/tauri.git synced 2026-04-01 10:01:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat(cli): improve error message when dev runner command fails (#3447)

Browse Source
This commit is contained in:
Lucas Fernandes Nogueira
2022-02-13 19:13:31 -03:00
committed by GitHub
parent 8d0d4f290f
commit 759d1afb86
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changes/cli-runner-error-message.md Normal file
View File

@@ -0,0 +1,6 @@
---
"cli.rs": patch
"cli.js": patch
---
Improve error message when the dev runner command fails.

10
tooling/cli/src/dev.rs
View File

@@ -225,7 +225,7 @@ pub fn command(options: Options) -> Result<()> {
}
}
let mut process = start_app(&options, &runner, &cargo_features, child_wait_rx.clone());
let mut process = start_app(&options, &runner, &cargo_features, child_wait_rx.clone())?;
let (tx, rx) = channel();
@@ -268,7 +268,7 @@ pub fn command(options: Options) -> Result<()> {
break;
}
}
process = start_app(&options, &runner, &cargo_features, child_wait_rx.clone());
process = start_app(&options, &runner, &cargo_features, child_wait_rx.clone())?;
}
}
}
@@ -298,7 +298,7 @@ fn start_app(
runner: &str,
features: &[String],
child_wait_rx: Arc<Mutex<Receiver<()>>>,
) -> Arc<SharedChild> {
) -> Result<Arc<SharedChild>> {
let mut command = Command::new(runner);
command.args(&["run", "--no-default-features"]);
@@ -321,7 +321,7 @@ fn start_app(
command.pipe().unwrap();
let child =
SharedChild::spawn(&mut command).unwrap_or_else(|_| panic!("failed to run {}", runner));
SharedChild::spawn(&mut command).with_context(|| format!("failed to run {}", runner))?;
let child_arc = Arc::new(child);
let child_clone = child_arc.clone();
@@ -349,5 +349,5 @@ fn start_app(
}
});
child_arc
Ok(child_arc)
}