fix(cli): build freezing on Windows, closes #3399 (#3402)

This commit is contained in:
Lucas Fernandes Nogueira
2022-02-11 11:38:10 -03:00
committed by GitHub
parent def7684025
commit 8beab63634
3 changed files with 10 additions and 5 deletions

View File

@@ -0,0 +1,6 @@
---
"cli.rs": patch
"cli.js": patch
---
Fixes CLI freezing when running `light.exe` on Windows without the `--verbose` flag.

View File

@@ -8,7 +8,7 @@ use std::{
fs::{self, File},
io::{self, BufWriter, Write},
path::Path,
process::Command,
process::{Command, Stdio},
};
use termcolor::{Color, ColorChoice, ColorSpec, StandardStream, WriteColor};
@@ -198,6 +198,8 @@ pub fn print_info(message: &str) -> crate::Result<()> {
pub fn execute_with_verbosity(cmd: &mut Command, settings: &Settings) -> crate::Result<()> {
if settings.is_verbose() {
cmd.pipe()?;
} else {
cmd.stdout(Stdio::null()).stderr(Stdio::null());
}
let status = cmd.status().expect("failed to spawn command");

View File

@@ -343,10 +343,7 @@ fn run_light(
}
let mut cmd = Command::new(&light_exe);
cmd
.args(&args)
.stdout(Stdio::piped())
.current_dir(build_path);
cmd.args(&args).current_dir(build_path);
common::execute_with_verbosity(&mut cmd, settings).map_err(|_| {
crate::Error::ShellScriptError(format!(