CalvinBackup/tauri
1
0
Fork 0
mirror of https://github.com/tauri-apps/tauri.git synced 2026-04-01 10:01:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(bundler): Don't self-sign dmg (#12323)

Browse Source
This commit is contained in:
Fabian-Lars
2025-01-25 11:46:16 +01:00
committed by GitHub
parent 9a9d1205b0
commit 9dac2863af
2 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changes/dmg-no-selfsign.md Normal file
View File

@@ -0,0 +1,5 @@
---
tauri-bundler: 'patch:bug'
---
Skip signing the .dmg if self signing via `"signingIdentity": "-"` is used.

23
crates/tauri-bundler/src/bundle/macos/dmg/mod.rs
View File

@@ -194,16 +194,19 @@ pub fn bundle_project(settings: &Settings, bundles: &[Bundle]) -> crate::Result<
fs::rename(bundle_dir.join(dmg_name), dmg_path.clone())?;
// Sign DMG if needed
if let Some(keychain) = super::sign::keychain(settings.macos().signing_identity.as_deref())? {
super::sign::sign(
&keychain,
vec![super::sign::SignTarget {
path: dmg_path.clone(),
is_an_executable: false,
}],
settings,
)?;
// skipping self-signing DMGs https://github.com/tauri-apps/tauri/issues/12288
let identity = settings.macos().signing_identity.as_deref();
if identity != Some("-") {
if let Some(keychain) = super::sign::keychain(identity)? {
super::sign::sign(
&keychain,
vec![super::sign::SignTarget {
path: dmg_path.clone(),
is_an_executable: false,
}],
settings,
)?;
}
}
Ok(Bundled {