Compare commits

...

4 Commits

Author SHA1 Message Date
github-actions[bot]
b9a4410516 apply version updates (#10468)
Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
2024-08-03 10:22:38 -03:00
Lucas Fernandes Nogueira
fb1933f174 fix(cli): android dev --open failing due to adb not finding device (#10467) 2024-08-03 10:04:26 -03:00
deadmeu
699319d8a7 docs: Update tauri::app::Builder::setup example (#10463)
This resolves a warning emitted by following the example code: warning:
unused `Result` that must be used.
2024-08-03 09:50:27 -03:00
Lucas Fernandes Nogueira
206914fe8d fix(cli): adb reverse failing in Node.js (#10466) 2024-08-03 09:47:50 -03:00
16 changed files with 66 additions and 22 deletions

View File

@@ -0,0 +1,6 @@
---
"tauri-cli": patch:bug
"@tauri-apps/cli": patch:bug
---
Fixes running `android dev --open`.

6
.changes/fix-adb.md Normal file
View File

@@ -0,0 +1,6 @@
---
"tauri-cli": patch:bug
"@tauri-apps/cli": patch:bug
---
Fixes running `adb reverse` in Node.js context.

View File

@@ -1,11 +1,13 @@
{
"tag": "rc",
"changes": [
".changes/android-dev-open-adb-fix.md",
".changes/asset-resolver-dev-fallback.md",
".changes/change-pr-10435.md",
".changes/cli-desktop-port-exposure.md",
".changes/core-plugin-namespace.md",
".changes/dev-url-localhost-mobile.md",
".changes/fix-adb.md",
".changes/fix-conf-parsing-error-filepath.md",
".changes/fix-usage-without-compression.md",
".changes/ios-frameworks.md",

View File

@@ -1342,7 +1342,7 @@ use tauri::Manager;
tauri::Builder::default()
.setup(|app| {
let main_window = app.get_window("main").unwrap();
main_window.set_title("Tauri!");
main_window.set_title("Tauri!")?;
Ok(())
});
```

View File

@@ -1,5 +1,12 @@
# Changelog
## \[2.0.0-rc.1]
### Bug Fixes
- [`fb1933f17`](https://www.github.com/tauri-apps/tauri/commit/fb1933f17442674e53374578e57a8cad241ac3c6) ([#10467](https://www.github.com/tauri-apps/tauri/pull/10467) by [@lucasfernog](https://www.github.com/tauri-apps/tauri/../../lucasfernog)) Fixes running `android dev --open`.
- [`206914fe8`](https://www.github.com/tauri-apps/tauri/commit/206914fe8d97eb61a2ff2a80e94e65e7a42bcea5) ([#10466](https://www.github.com/tauri-apps/tauri/pull/10466) by [@lucasfernog](https://www.github.com/tauri-apps/tauri/../../lucasfernog)) Fixes running `adb reverse` in Node.js context.
## \[2.0.0-rc.0]
### New Features

View File

@@ -5117,7 +5117,7 @@ dependencies = [
[[package]]
name = "tauri-cli"
version = "2.0.0-rc.0"
version = "2.0.0-rc.1"
dependencies = [
"anyhow",
"axum",

View File

@@ -3,7 +3,7 @@ members = [ "node" ]
[package]
name = "tauri-cli"
version = "2.0.0-rc.0"
version = "2.0.0-rc.1"
authors = [ "Tauri Programme within The Commons Conservancy" ]
edition = "2021"
rust-version = "1.70"

View File

@@ -1,6 +1,6 @@
{
"cli.js": {
"version": "2.0.0-rc.0",
"version": "2.0.0-rc.1",
"node": ">= 10.0.0"
},
"tauri": "2.0.0-rc.0",

View File

@@ -1,5 +1,16 @@
# Changelog
## \[2.0.0-rc.1]
### Bug Fixes
- [`fb1933f17`](https://www.github.com/tauri-apps/tauri/commit/fb1933f17442674e53374578e57a8cad241ac3c6) ([#10467](https://www.github.com/tauri-apps/tauri/pull/10467) by [@lucasfernog](https://www.github.com/tauri-apps/tauri/../../lucasfernog)) Fixes running `android dev --open`.
- [`206914fe8`](https://www.github.com/tauri-apps/tauri/commit/206914fe8d97eb61a2ff2a80e94e65e7a42bcea5) ([#10466](https://www.github.com/tauri-apps/tauri/pull/10466) by [@lucasfernog](https://www.github.com/tauri-apps/tauri/../../lucasfernog)) Fixes running `adb reverse` in Node.js context.
### Dependencies
- Upgraded to `tauri-cli@2.0.0-rc.1`
## \[2.0.0-rc.0]
### New Features

View File

@@ -1,6 +1,6 @@
{
"name": "@tauri-apps/cli",
"version": "2.0.0-rc.0",
"version": "2.0.0-rc.1",
"description": "Command line interface for building Tauri apps",
"funding": {
"type": "opencollective",
@@ -67,4 +67,4 @@
"format": "prettier --write ./package.json ./tauri.js",
"format:check": "prettier --check ./package.json ./tauri.js"
}
}
}

View File

@@ -11,7 +11,7 @@ use crate::{
use clap::{ArgAction, Parser};
use cargo_mobile2::{
android::target::Target,
android::{adb, target::Target},
opts::Profile,
target::{call_for_targets_with_fallback, TargetTrait},
};
@@ -58,6 +58,26 @@ pub fn command(options: Options) -> Result<()> {
let env = env()?;
if cli_options.dev {
let dev_url = tauri_config
.lock()
.unwrap()
.as_ref()
.unwrap()
.build
.dev_url
.clone();
if let Some(port) = dev_url.and_then(|url| url.port_or_known_default()) {
let forward = format!("tcp:{port}");
// ignore errors in case we do not have a device available
let _ = adb::adb(&env, ["reverse", &forward, &forward])
.stdin_file(os_pipe::dup_stdin().unwrap())
.stdout_file(os_pipe::dup_stdout().unwrap())
.stderr_capture()
.run();
}
}
call_for_targets_with_fallback(
options.targets.unwrap_or_default().iter(),
&detect_target_ok,

View File

@@ -189,6 +189,7 @@ fn run_build(
let _lock = flock::open_rw(out_dir.join("lock").with_extension("android"), "Android")?;
let cli_options = CliOptions {
dev: false,
features: build_options.features.clone(),
args: build_options.args.clone(),
noise_level,

View File

@@ -22,7 +22,6 @@ use clap::{ArgAction, Parser};
use anyhow::Context;
use cargo_mobile2::{
android::{
adb,
config::{Config as AndroidConfig, Metadata as AndroidMetadata},
device::Device,
env::Env,
@@ -208,19 +207,6 @@ fn run_dev(
},
)?;
let dev_url = tauri_config
.lock()
.unwrap()
.as_ref()
.unwrap()
.build
.dev_url
.clone();
if let Some(port) = dev_url.and_then(|url| url.port_or_known_default()) {
let forward = format!("tcp:{port}");
adb::adb(&env, ["reverse", &forward, &forward]).run()?;
}
let open = options.open;
let exit_on_panic = options.exit_on_panic;
let no_watch = options.no_watch;
@@ -234,6 +220,7 @@ fn run_dev(
},
|options| {
let cli_options = CliOptions {
dev: true,
features: options.features.clone(),
args: options.args.clone(),
noise_level,

View File

@@ -270,6 +270,7 @@ fn run_build(
let _lock = flock::open_rw(out_dir.join("lock").with_extension("ios"), "iOS")?;
let cli_options = CliOptions {
dev: false,
features: build_options.features.clone(),
args: build_options.args.clone(),
noise_level,

View File

@@ -310,7 +310,7 @@ fn use_network_address_for_dev_url(
.host
.unwrap_or_default()
.unwrap_or_else(|| *local_ip_address(options.force_ip_prompt));
dev_options.host.replace(ip.clone());
dev_options.host.replace(ip);
Some(ip)
} else {
None
@@ -375,6 +375,7 @@ fn run_dev(
},
|options| {
let cli_options = CliOptions {
dev: true,
features: options.features.clone(),
args: options.args.clone(),
noise_level,

View File

@@ -131,6 +131,7 @@ impl Target {
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CliOptions {
pub dev: bool,
pub features: Option<Vec<String>>,
pub args: Vec<String>,
pub noise_level: NoiseLevel,
@@ -140,6 +141,7 @@ pub struct CliOptions {
impl Default for CliOptions {
fn default() -> Self {
Self {
dev: false,
features: None,
args: vec!["--lib".into()],
noise_level: Default::default(),