Rucha Mahabal
46456fdc19
Merge pull request #23095 from nextchamp-saqib/sr-no-selector-fix-hotfix
...
fix: val is not defined
2020-08-20 15:01:58 +05:30
Deepesh Garg
2aa23f91b1
Merge pull request #23092 from rohitwaghchaure/not-able-to-submit-dn-hotfix
...
fix: not able to submit delivery note
2020-08-20 13:35:40 +05:30
Saqib Ansari
2cc0ad51f5
fix: val is not defined
2020-08-20 12:54:36 +05:30
Rohit Waghchaure
5e32ee8457
fix: not able to submit delivery note
2020-08-20 12:21:09 +05:30
Suraj Shetty
bf7adb8b38
refactor: Format and sanitise user inputs to search queries. ( #23064 )
...
* refactor: Sanitize whitelisted method inputs
Co-authored-by: Prssanna Desai <prssud@gmail.com >
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com >
* refactor: Format and sanitize tax_account_query inputs
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
Co-authored-by: Prssanna Desai <prssud@gmail.com >
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com >
* refactor: Validate and sanitize search inputs via decorator
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
Co-authored-by: Prssanna Desai <prssud@gmail.com >
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com >
* style: Minor formatting fix
* refactor: Validate and sanitize search inputs using decorator
* fix: Typo
* fix: Remove unwanted import statement
* refactor: Repalce validate_and_sanitize_search_inputs() with validate_and_sanitize_search_inputs
Co-authored-by: Prssanna Desai <prssud@gmail.com >
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com >
Co-authored-by: Prssanna Desai <prssud@gmail.com >
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com >
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
2020-08-20 11:17:30 +05:30
Deepesh Garg
848288ed36
Merge pull request #23086 from deepeshgarg007/rcm_deduction
...
fix: Do not update total for RCM invvoices if net taxes are zero
2020-08-19 18:34:27 +05:30
Deepesh Garg
1c29da32fc
fix: Do not update total for RCM invvoices if net taxes are zero
2020-08-19 18:30:18 +05:30
Deepesh Garg
dae1fad1a6
fix: Total calculations for multicurrency RCM invoices ( #23070 )
2020-08-18 19:32:38 +05:30
Anupam Kumar
09b6628e53
fix: Leave application status ( #23043 )
...
* fix: leave application status update fix
* fix:adding patch
2020-08-18 14:43:34 +05:30
Deepesh Garg
693bf1309a
Merge pull request #23021 from prssanna/expense-claim-list-currency-v12
...
fix: add company in list fields to fetch for Expense Claim
2020-08-17 23:08:27 +05:30
Afshan
df42df5246
fix: handled condition if staffing isn't created ( #23057 )
...
Co-authored-by: Marica <maricadsouza221197@gmail.com >
2020-08-17 13:48:07 +05:30
Afshan
4b6d5ef6aa
fix: the JSON object must be str, bytes or bytearray, not "list" ( #23053 )
2020-08-17 12:25:34 +05:30
Rucha Mahabal
5e51a1fe9b
Merge pull request #23037 from aakvatech/patch-5
...
fix: AttributeError: 'ProgramFee' object has no attribute 'course'
2020-08-14 13:21:45 +05:30
aakvatech
2cdc0c3f2d
fix: AttributeError: 'ProgramFee' object has no attribute 'course'
...
Error occurs while program enrollment on new student.
This happens on version 12 and not on version 13.
Version 12 uses
course_list = [course.course for course in program.get_all_children()]
where as version 13 uses
course_list = [course.course for course in program.courses]
erpnext/erpnext/education/doctype/program_enrollment/program_enrollment.py
2020-08-14 10:26:54 +03:00
prssanna
c28e37781a
fix: add company in list fields to fetch for Expense Claim
2020-08-13 11:56:30 +05:30
Saqib
6c536bb6e0
fix: cannot change customer fields if credit exhausted ( #22838 )
...
* fix: cannot change customer fields if credit exhausted
* fix: order based on company
* fix: sort current limits w.r.t company before compare
* fix: CustomerCreditLimit Object is not subscriptable
2020-08-13 09:27:50 +05:30
Nabin Hait
af9d653fb4
Inclusive tax based on item quantity v12 ( #23015 )
...
* fix: Calculate taxes if tax is based on item quantity and inclusive on item price
* git commit -m "fix: Add missing semicolon"
* fix: Calculate taxes if tax is based on item quantity
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
2020-08-13 09:22:05 +05:30
Anupam Kumar
8969e19594
fix: Opportunity/Quotation Lost Reason Fix ( #23016 )
2020-08-13 09:19:53 +05:30
Deepesh Garg
a979fcc25b
fix: Project link not set in accounts other than profit and loss accounts ( #22049 )
...
* fix: project link not set in accounts other than profilt and loss accounts
* fix: cannot find get_allow_cost_center_in_entry_of_bs_account
* fix: remove enable_allow_cost_center_in_entry_of_bs_account
* chore: add tests and remove test based on allow_cost_center_for_bs_accounts
* fix: travis
* fix: Test Cases
* fix: Patch to remove Property Setter
* fix: Test Cases
* fix: Remove v13 patch
* fix: Procurement Tracker test case
* fix: Proccurement tracker report test
* fix: Codacy
* fix: Remove duplicate project field
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com >
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2020-08-12 21:06:25 +05:30
Rucha Mahabal
9bd041c14c
fix: don't set asset maintenance log status as Overdue when Completed or Cancelled ( #23012 )
...
* fix: don't set maintenance log status as Overdue when Completed or Cancelled
* fix: set draft indicators for Asset Maintenance Log listview
2020-08-12 19:34:54 +05:30
Deepesh Garg
1bb6ef3356
fix: Update state code and union territory for Daman and Diu ( #22989 )
...
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2020-08-12 19:34:23 +05:30
Deepesh Garg
5cc5bc246a
fix: Cancellation of accounting transactions within closed accounting period ( #22986 )
2020-08-12 17:56:57 +05:30
Rucha Mahabal
2a0ed798aa
fix: TypeError while setting transfer_qty in Stock Entry ( #22931 )
...
Co-authored-by: Marica <maricadsouza221197@gmail.com >
2020-08-12 14:32:23 +05:30
Marica
033d98cd68
Merge pull request #23002 from AfshanKhan/fix-duplicate-dropdown-PO-v12
...
fix: moved custom_make_buttons to PurchaseOrderController to avoid duplication of dropdown options
2020-08-11 20:57:11 +05:30
Afshan
ec3dc95e6e
fix: moved custom_make_buttons to PurchaseOrderController to avoid duplication of dropdown options
2020-08-11 20:42:16 +05:30
Deepesh Garg
57d86a3bc1
Merge pull request #22973 from marination/opportunity-from-email-fix
...
fix: Creating opportunity from email
2020-08-10 16:12:00 +05:30
marination
265916543d
fix: Creating opportunity from email
2020-08-10 14:42:30 +05:30
Deepesh Garg
f63182df5a
Merge pull request #22968 from deepeshgarg007/gst_export_wopay_v12
...
fix: GSTR 1 report for exports without payment of Tax
2020-08-10 11:29:56 +05:30
Deepesh Garg
9d455cf4a6
fix: GSTR 1 report for exports without payment of Tax
2020-08-10 09:57:28 +05:30
Deepesh Garg
ff9c40fde6
Merge pull request #22730 from deepeshgarg007/gstr3b_cess_v12_hotfix
...
fix: Multiple GST fixes
2020-08-08 22:15:25 +05:30
Deepesh Garg
f0f20bb434
fix: RCM taxable value in GSTR3b report
2020-08-08 20:58:01 +05:30
Deepesh Garg
bbfd5a4cc8
fix: Test Cases
2020-08-08 19:46:09 +05:30
Deepesh Garg
3ae4a83504
fix: Add print for debug
2020-08-08 17:52:45 +05:30
Deepesh Garg
1da33f4129
fix: Test case
2020-08-07 22:51:33 +05:30
Deepesh Garg
b8eff8d141
fix: Test case
2020-08-07 22:02:14 +05:30
Deepesh Garg
67e07b69dd
fix: More print statements for debugging
2020-08-07 15:59:03 +05:30
Deepesh Garg
7d262d1a08
Merge pull request #22928 from deepeshgarg007/paymemnt_reco_multi_v12
...
fix: Multi currency payment reconciliation
2020-08-07 15:36:37 +05:30
Deepesh Garg
5f8e8a3c29
fix: Add debug print statement
2020-08-07 10:05:22 +05:30
Deepesh Garg
2169bb7640
fix: Add print
2020-08-06 23:16:33 +05:30
Deepesh Garg
33754b9dc8
fix: add print for debug
2020-08-06 22:17:37 +05:30
Deepesh Garg
bb451360ba
Merge branch 'version-12-hotfix' of https://github.com/frappe/erpnext into gstr3b_cess_v12_hotfix
2020-08-06 21:50:27 +05:30
Afshan
2cf4168009
fix: show or hide section or attributes depending on other attributes… ( #22933 )
...
* fix: show or hide section or attributes depending on other attributes for better UI
* fix:depends on: batch_no for retain sample
Co-authored-by: Marica <maricadsouza221197@gmail.com >
2020-08-06 19:04:35 +05:30
Marica
e2e9633ee1
Merge pull request #22927 from deepeshgarg007/price_rule_fix_v12
...
fix: Error due to comma in Pricing rule name
2020-08-06 16:57:18 +05:30
Marica
74643c804d
Merge branch 'version-12-hotfix' into price_rule_fix_v12
2020-08-06 14:38:59 +05:30
Marica
e7162a86c6
Merge pull request #22930 from deepeshgarg007/payment_reco_cost_center_fix_v12
...
fix: Add default cost center in payment reconciliation JV
2020-08-06 14:31:52 +05:30
Deepesh Garg
b3cdd91d65
fix: Tests
2020-08-06 13:18:42 +05:30
Deepesh Garg
dd64cd1512
fix: Add default cost center in payment reconciliation JV
2020-08-06 11:46:25 +05:30
Deepesh Garg
024c78f522
fix: Hide currency link fields
2020-08-06 11:31:00 +05:30
Deepesh Garg
e6ec549c81
fix: Multi currency payment reconciliation
2020-08-06 11:30:46 +05:30
Deepesh Garg
579167d1de
fix: Remove print statement
2020-08-06 11:27:27 +05:30