mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-15 21:07:20 +01:00
fix: pre-landing review fixes (Step 12 names the no-write kept line exactly)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
626766e811
commit
0c66cc7862
7 files changed
+8
-7
No files matched your search
+1
-1
@@ -520,7 +520,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1.
|
||||
runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag
|
||||
(`--bump`, `--accept-incomplete`, `--version <v>`, `--keep-current`, `--answer`).
|
||||
|
||||
`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: <v> kept` ends Step 12 with
|
||||
`VERSION: skipped` (fragments) or `VERSION: <v> kept (…; no write)` ends Step 12 with
|
||||
`NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch.
|
||||
|
||||
1. **Classify state** — pure reader, never writes:
|
||||
|
||||
+1
-1
@@ -243,7 +243,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1.
|
||||
runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag
|
||||
(`--bump`, `--accept-incomplete`, `--version <v>`, `--keep-current`, `--answer`).
|
||||
|
||||
`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: <v> kept` ends Step 12 with
|
||||
`VERSION: skipped` (fragments) or `VERSION: <v> kept (…; no write)` ends Step 12 with
|
||||
`NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch.
|
||||
|
||||
1. **Classify state** — pure reader, never writes:
|
||||
|
||||
+1
-1
@@ -521,7 +521,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1.
|
||||
runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag
|
||||
(`--bump`, `--accept-incomplete`, `--version <v>`, `--keep-current`, `--answer`).
|
||||
|
||||
`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: <v> kept` ends Step 12 with
|
||||
`VERSION: skipped` (fragments) or `VERSION: <v> kept (…; no write)` ends Step 12 with
|
||||
`NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch.
|
||||
|
||||
1. **Classify state** — pure reader, never writes:
|
||||
|
||||
+1
-1
@@ -520,7 +520,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1.
|
||||
runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag
|
||||
(`--bump`, `--accept-incomplete`, `--version <v>`, `--keep-current`, `--answer`).
|
||||
|
||||
`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: <v> kept` ends Step 12 with
|
||||
`VERSION: skipped` (fragments) or `VERSION: <v> kept (…; no write)` ends Step 12 with
|
||||
`NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch.
|
||||
|
||||
1. **Classify state** — pure reader, never writes:
|
||||
|
||||
+1
-1
@@ -520,7 +520,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1.
|
||||
runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag
|
||||
(`--bump`, `--accept-incomplete`, `--version <v>`, `--keep-current`, `--answer`).
|
||||
|
||||
`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: <v> kept` ends Step 12 with
|
||||
`VERSION: skipped` (fragments) or `VERSION: <v> kept (…; no write)` ends Step 12 with
|
||||
`NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch.
|
||||
|
||||
1. **Classify state** — pure reader, never writes:
|
||||
|
||||
+1
-1
@@ -522,7 +522,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1.
|
||||
runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag
|
||||
(`--bump`, `--accept-incomplete`, `--version <v>`, `--keep-current`, `--answer`).
|
||||
|
||||
`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: <v> kept` ends Step 12 with
|
||||
`VERSION: skipped` (fragments) or `VERSION: <v> kept (…; no write)` ends Step 12 with
|
||||
`NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch.
|
||||
|
||||
1. **Classify state** — pure reader, never writes:
|
||||
|
||||
@@ -196,7 +196,8 @@ describe('ship/SKILL.md — Plan Completion gate invariants', () => {
|
||||
const version = entry.slice(entry.indexOf('## Step 12:'), entry.indexOf('1. **Classify state**')).replace(/\s+/g, ' ');
|
||||
expect(version).not.toContain('replaces items 1–4');
|
||||
expect(version).toContain('`VERSION: skipped`');
|
||||
expect(version).toContain('`VERSION: <v> kept` ends Step 12 with `NEW_VERSION` unset');
|
||||
expect(version).toContain('`VERSION: <v> kept (…; no write)` ends Step 12 with `NEW_VERSION` unset');
|
||||
expect(version).toContain('ALREADY_BUMPED derives it in item 1');
|
||||
expect(version).toContain("Steps 18 and 20 take NO_VERSION's branch");
|
||||
});
|
||||
|
||||
|
||||
Reference in new issue
Block a user