mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-14 12:27:18 +01:00
fix(review): design-review scope block prints SCOPE_FRONTEND
This commit is contained in:
1 parent
e42a479a46
commit
3b61d6acb4
5 files changed
+5
No files matched your search
@@ -33,6 +33,7 @@ This release closes the follow-ups filed by the v1.91.15.0 prompt cleanup. The c
|
||||
- /review's specialist header counted advisory findings in its total; the header's N is now defined as critical plus informational.
|
||||
- Free-lane shards failed with "browser ownership deadline exceeded" when a browse daemon took more than 5 seconds to exit after SIGINT. Reaching the force-kill point now ends the graceful phase instead of recording a cleanup failure; a probe cut off at that point still fails the shard.
|
||||
- `bun run audit:manifest` printed backslash paths on Windows.
|
||||
- /review and /ship's design-review scope check sourced `gstack-diff-scope` without printing `SCOPE_FRONTEND`, so the agent could not see the value and reran the helper by hand. The block now prints it.
|
||||
- Exploratory QA could publish its evidence before listing captures taken before an input change, which left the verdict inconclusive (materialize runs once). The probe loop now says to annotate every capture and mark older-snapshot ones `superseded`.
|
||||
|
||||
#### For contributors
|
||||
|
||||
@@ -33,6 +33,7 @@ Check if the diff touches frontend files using \`gstack-diff-scope\`:
|
||||
|
||||
\`\`\`bash
|
||||
source <(${ctx.paths.binDir}/gstack-diff-scope <base> 2>/dev/null)
|
||||
echo "SCOPE_FRONTEND=$SCOPE_FRONTEND"
|
||||
\`\`\`
|
||||
|
||||
**If \`SCOPE_FRONTEND=false\`:** Skip design review silently. No output.
|
||||
|
||||
@@ -94,6 +94,7 @@ Check if the diff touches frontend files using `gstack-diff-scope`:
|
||||
|
||||
```bash
|
||||
source <(~/.claude/skills/gstack/bin/gstack-diff-scope <base> 2>/dev/null)
|
||||
echo "SCOPE_FRONTEND=$SCOPE_FRONTEND"
|
||||
```
|
||||
|
||||
**If `SCOPE_FRONTEND=false`:** Skip design review silently. No output.
|
||||
|
||||
+1
@@ -1885,6 +1885,7 @@ Check if the diff touches frontend files using `gstack-diff-scope`:
|
||||
|
||||
```bash
|
||||
source <($GSTACK_BIN/gstack-diff-scope <base> 2>/dev/null)
|
||||
echo "SCOPE_FRONTEND=$SCOPE_FRONTEND"
|
||||
```
|
||||
|
||||
**If `SCOPE_FRONTEND=false`:** Skip design review silently. No output.
|
||||
|
||||
+1
@@ -1893,6 +1893,7 @@ Check if the diff touches frontend files using `gstack-diff-scope`:
|
||||
|
||||
```bash
|
||||
source <($GSTACK_BIN/gstack-diff-scope <base> 2>/dev/null)
|
||||
echo "SCOPE_FRONTEND=$SCOPE_FRONTEND"
|
||||
```
|
||||
|
||||
**If `SCOPE_FRONTEND=false`:** Skip design review silently. No output.
|
||||
|
||||
Reference in new issue
Block a user