mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-03 23:37:53 +01:00
fix: pre-landing review fixes
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
3e44a5af3c
commit
7672a4f07e
4 files changed
+4
-4
No files matched your search
@@ -244,7 +244,7 @@ export function generateQAReview(ctx: TemplateContext): string {
|
||||
|
||||
Only the parent runs report-only discovery.
|
||||
Never overwrite another run's reports. Batch only independent Reads.
|
||||
${ship ? `Without a caller REPORT_DIR, use the \`reportDir\` that \`bun ${quoteSafePath(ctx.paths.binDir)}/gstack-qa-evidence report-dir\` prints: git-excluded, so QA never changes the reviewed tree.\n` : ''}
|
||||
${ship ? `Without a caller REPORT_DIR, use the \`reportDir\` that \`${quoteSafePath(ctx.paths.binDir)}/gstack-qa-evidence report-dir\` prints: git-excluded, so QA never changes the reviewed tree.\n` : ''}
|
||||
${ship ? `**1. Load methods before any QA or explicit-verification probe.**
|
||||
|
||||
${generateQAReviewPreflight(ctx)}` : `**1. Set the charter and isolation.**
|
||||
|
||||
@@ -594,7 +594,7 @@ If the Red Team fails or times out, confirm it stopped and record its review as
|
||||
|
||||
Only the parent runs report-only discovery.
|
||||
Never overwrite another run's reports. Batch only independent Reads.
|
||||
Without a caller REPORT_DIR, use the `reportDir` that `bun $HOME/.claude/skills/gstack/bin/gstack-qa-evidence report-dir` prints: git-excluded, so QA never changes the reviewed tree.
|
||||
Without a caller REPORT_DIR, use the `reportDir` that `$HOME/.claude/skills/gstack/bin/gstack-qa-evidence report-dir` prints: git-excluded, so QA never changes the reviewed tree.
|
||||
|
||||
**1. Load methods before any QA or explicit-verification probe.**
|
||||
|
||||
|
||||
@@ -71,7 +71,7 @@ test('report-dir refuses outside a git work tree instead of guessing a location'
|
||||
|
||||
test('/ship Step 9.2.1 resolves REPORT_DIR through report-dir, not the product tree', () => {
|
||||
const ctx: TemplateContext = { host: 'claude', skillName: 'ship', tmplPath: '', paths: HOST_PATHS.claude };
|
||||
expect(RESOLVERS.QA_REVIEW(ctx)).toContain('/gstack/bin/gstack-qa-evidence report-dir` prints: git-excluded');
|
||||
expect(RESOLVERS.QA_REVIEW(ctx)).toContain('that `$HOME/.claude/skills/gstack/bin/gstack-qa-evidence report-dir` prints: git-excluded');
|
||||
const rendered = fs.readFileSync(path.resolve(import.meta.dir, '../ship/sections/review-army.md'), 'utf8');
|
||||
expect(rendered).toContain('gstack-qa-evidence report-dir` prints: git-excluded');
|
||||
});
|
||||
@@ -1,4 +1,4 @@
|
||||
{
|
||||
"bytes": 183,
|
||||
"bytes": 179,
|
||||
"why": "GST-969: /ship Step 9.2.1 QA writes its reports under gstack-qa-evidence report-dir (git-excluded .gstack/tmp), not the product tree"
|
||||
}
|
||||
Reference in new issue
Block a user