mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-31 22:14:25 +01:00
docs(review): one sentence after the floor in ship-policy; review-floor comment names only the reviewers that carry it
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
c61a182eb2
commit
939790f1f0
2 files changed
+5
-4
No files matched your search
+3
-2
@@ -986,8 +986,9 @@ construction:
|
||||
context; `outside`: anything else), a `kind`, `blocking` and a `scope`.
|
||||
`blocking` is a CRITICAL defect. CRITICAL is the blocking floor: a finding that
|
||||
would fail a test, break production, lose data or secrets, or open a security hole
|
||||
(injection, auth bypass, secret exposure). Everything else is INFORMATIONAL. Everything else (an advisory, an informational
|
||||
item, a test gap, a wording note) is below the floor. Pass 1 fixes findings in
|
||||
(injection, auth bypass, secret exposure). Everything else is INFORMATIONAL.
|
||||
An advisory, an informational item, a test gap or a wording note is below the
|
||||
floor. Pass 1 fixes findings in
|
||||
the diff (`scope: fix`). A blocking finding in code the PR did not change is
|
||||
`scope: defer`: `gstack-review-scope defer` files it as a GitHub issue (reusing
|
||||
an open issue that carries the same `<!-- gstack-deferred-finding: <fingerprint> -->`
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
/**
|
||||
* The blocking floor every gstack reviewer prompt carries (docs/review-policy.md#the-blocking-floor).
|
||||
* One sentence, so the core checklist, each specialist, the Red Team and the fix-check rate
|
||||
* severity the same way. test/review-severity-floor.test.ts keeps the markdown copies in step.
|
||||
* One sentence, so the core checklist, each specialist and the fix-check rate severity the
|
||||
* same way. test/review-severity-floor.test.ts keeps the markdown copies in step.
|
||||
*/
|
||||
export const BLOCKING_FLOOR = 'CRITICAL is the blocking floor: a finding that would fail a test, break production, lose data or secrets, or open a security hole (injection, auth bypass, secret exposure). Everything else is INFORMATIONAL.';
|
||||
Reference in new issue
Block a user