fix(review,ship): plan checks publish a checkpoint before each probe; only the smoke expiry stop is skipped

This commit is contained in:
garrytan committed 2026-09-30 12:45:55 +00:00
1 parent 3e6074b452
commit d2c9c8fa6d
5 files changed
+5 -5

No files matched your search

+1 -1
View File
@@ -827,7 +827,7 @@ Never install, import cookies or bootstrap tests. Functional-only skips browser
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.
+1 -1
View File
@@ -257,7 +257,7 @@ Never install, import cookies or bootstrap tests. Functional-only skips browser
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the \`G status D\` expiry stop and use \`--timeout-ms\`, not \`--deadline D\`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the \`G status D\` expiry stop and use \`--timeout-ms\`, not \`--deadline D\`. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.
+1 -1
View File
@@ -504,7 +504,7 @@ Run the shared preflight; start its smoke guard once. Guard every smoke probe. F
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.
+1 -1
View File
@@ -2109,7 +2109,7 @@ Run the shared preflight; start its smoke guard once. Guard every smoke probe. F
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.
+1 -1
View File
@@ -2368,7 +2368,7 @@ Run the shared preflight; start its smoke guard once. Guard every smoke probe. F
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.