Commit Graph
539 Commits
Author SHA1 Message Date
garrytan 27dac76763 test(W7c): match document-release spawned-dispatch contract on meaning
W7c conversion (t04 F3; W7a run-in-background-guidance.test.ts:472,474, named
by the Eng W7c gate as anti-injection and VERSION invariants that stay as
case-insensitive meaning checks). The run_in_background flag pins, structural
scanner and inverted-phrasing ban are unchanged.

Removed assertion groups (invariant -> remaining protection):
- 'NEVER trigger it on their own' (caps literal): prompt/file/tool claims do
  not enable spawned mode (anti-injection) -> kept free: /claims never
  trigger it on their own/i in the generated skill and template.
- 'The NEVER-do invariants below do' (short form of a wrapped sentence that
  names the caps headings s10 rewrites): spawned auto-pick still never
  rewrites CHANGELOG or changes VERSION -> kept free: /skip any
  recommendation that rewrites CHANGELOG or changes VERSION/i
  (whitespace-normalized) in both files; gate E2E document-release.
- 'A spawned run must never change VERSION': same rule, now /i.

Mutation pass (scratch worktree; document-release skill, template and
release-body section, ship/sections/documentation.md): 7/7 as expected;
deleting the anti-injection clause, the CHANGELOG/VERSION carve-out, the
spawned VERSION line, the run_in_background flag or the dispatch heading
goes red; lowering NEVER and rewording 'NEVER-do invariants' stays green.
Log: .context/mutation-run-in-background-guidance.md.
2026-10-03 01:17:01 +00:00
garrytan 5b2bb3a1a5 test(W7c): match plan-scope-selection scope-gate stop lines case-insensitively
W7c conversion, scope-gate caps pins only (t06 #14). The scope classifiers
(nativeSeededPlanSelection, isScopeGateAutoSelectVisible,
isScopeGateQuestionVisible), the consumed announcement and A/B/C menu bytes,
and every non-caps assertion are unchanged.

Removed assertion groups (invariant -> remaining protection):
- 'Reply with A, B, or C. STOP and wait' order anchors (design, template and
  every host expansion): menu precedes bootstrap -> kept free: the consumed
  prefix 'Reply with A, B, or C' (pty/classify.ts, pty/judge.ts), now also
  required to exist after '## Scope gate' so a missing menu cannot pass the
  order check with indexOf -1.
- 'call AskUserQuestion FIRST and wait.', 'does NOT count as the mode signal',
  'If the user explicitly named a DIFFERENT target' (design and eng), 'STOP
  and wait for the answer — only after the user picks', 'STOP and wait for the
  answer' (toContain and indexOf before the first ```bash on every host):
  ask first, pasted text is not a mode signal, explicit targets win, stop
  until answered -> kept free: the same rules as case-insensitive meaning
  checks, including the per-host ordering (search /stop and wait for the
  answer/i before the first ```bash, with a presence check).

Mutation pass (scratch worktree; plan-design-review and plan-eng-review
templates): 12/12 as expected; gate-after-preamble, removed design menu
prefix, removed stop lines (design, eng), removed mode-signal, ask-first and
explicit-target rules go red; lowering STOP/FIRST/NOT/DIFFERENT stays green.
The eng menu prefix is not pinned here (eng-scope-entry-ap.test.ts M1 covers
it). Log: .context/mutation-plan-scope-selection.md.
2026-10-03 01:16:18 +00:00
garrytan 7cb97e61b3 test(W7c): shrink autoplan-phase-order to structural and meaning checks
W7c conversion (t06 #13; W7c list item 'Eng runs LAST, always', 'ONLY/FINAL').
Pin lines 203 -> 166. autoplan has only periodic E2Es (autoplan-dual-voice,
autoplan-journal-drift: E2E_TIERS periodic), so every invariant keeps one
free check: sentence pins collapse to short /i meaning checks; commands, CLI
signatures, placeholders, tool parameters, report fields, packet outputs
(code-generated) and stale-string bans stay exact.

Removed assertion groups (invariant -> remaining protection):
- 'Eng runs LAST, always' (caps sentence): Eng is the terminal phase -> kept
  free: /CEO → Design.*→ DX.*→ Eng/s, heading order 1 < 2 < 2.5 < 3 and the
  'CEO → Design → Eng → DX' ban.
- Final-gate sentences ('...Use Decision Classification; ask once at Final
  Approval Gate, never mid-run', 'Queue clearly-wrong/challenged premises',
  'The user decides there; never stop mid-pipeline'): premises queue for the
  single final gate -> kept free: /never auto-decide user challenges/i, /ask
  once at final approval gate, never mid-run/i, 'as User Challenges for Phase
  4', /never stop mid-pipeline/i, the two old-gate bans.
- Generated setup sentences ('Resolve this phase', 'Run all applicable skills
  and lazy sections fully', 'log successful ranges/total to EOF'): phases load
  at their own boundary -> kept free: /never prefetch future phases/i,
  /missing skill: report phase and setup repair/i, per-phase methodology CLI
  and Read-before-create order, no in-full-now Reads.
- Intake load sentence ("Resolve this phase's source to absolute
  `<REVIEW_SKILL>`; load via its checkpoint") -> kept free: `<REVIEW_SKILL>`
  token and /never prefetch future phases/i; section load keeps
  `readRanges`/EOF/skip-listed checks.
- Native dispatch sentences ("ONLY/FINAL tool call", 'Keep native Reads
  enabled', 'all criteria + plan', 'if its schema exposes it', 'Claude Code:
  end response immediately', 'Other hosts await that ID', "Then outside →
  this phase's review ONLY", 'No inline substitute; apply failure policy'):
  the native review blocks and completes before outside review -> kept free:
  native < outside order, run_in_background: false, isAsync: true, /final
  tool call/i, /end response immediately/i, /no further tool calls\/review
  until/i, `nativePromptPath` to EOF, INPUT-hash match, /retry invalid input
  once/i, /no inline substitute/i, 720000ms timeout, provenance placeholder,
  N/A and CONFIRMED status tokens, /primary cannot replace/i.
- Sequential Execution sentences (Keep ONE phase active, compaction reload,
  'reconcile saved artifacts and sent conversation messages separately',
  'Publication is a separate operation', 'an earlier Read is not this close',
  "Then continue to the next phase's tool calls in the same turn", 'record
  verbatim into fenced history', 'retaining its original source SHA',
  'compaction resumes the existing invocation', the full LOG/amend-input
  sentence): one phase at a time, publish before advancing -> kept free:
  /keep one phase active/i, /never draft future-phase reviews/i, compaction
  reload (/i), two ordered chains (load < snapshot < dispatch < consume <
  remaining sections; phase-close < parent message < driver advance < after
  Eng), skip/resume/step 6 (Publish) routes, open-gate, uptake, pending,
  never-skip and raw-transcript lines (/i), rerun fields
  `baselineEdits.record`/`sourceSha256`, `amend-input`.
- Amendment-binding sentences ('load the shared close steps afresh, even if
  read earlier', 'Keep this checkpoint for this invocation; review exports do
  not replace it') -> kept free: checkpoint field per phase, `methodologyPath`,
  /afresh/i, /review exports do not replace it/i.
- Shared-close sentences (~20: completion prerequisites, readRanges Read
  choreography, 'A Read of only the edited tail does not satisfy...', 'If a
  result is truncated...', 'If a Read fails...', 'regenerate the packet...',
  'Retention checks prove bytes; counts, hashes...', 'Review history stays in
  Review record', 'Taste remains provisional', 'Apply the phase's failure
  policy...'): read the whole packet, verify, then publish -> kept free: the
  seven-step order, terminal-results/INPUT/pending/no-credit/User
  Challenges/None/fixed-checkpoint lines (/i), prepare-close CLI,
  `readRanges` with exact `offset` and `limit`, /through EOF/i, no advance
  without a result, step-3 return, verification compare/recheck/keep-open,
  stale ban, generated copy contains the template.
- Publication sentences ('After sending the actual parent report', 'using
  actual findings and voice statuses', "The sent conversation message is step
  6's output", 'This message is the next operation...', the duplicated driver
  pins) -> kept free: publish < report < return order, /send the filled
  report ... visible parent assistant text/i, /before any next-phase tool
  call/i, both-voices rule, same-turn/driver-alone/no-continue-wait/skip
  lines (/i), Bash-is-not-publication (/i), stale ban.
- Report-format sentences ("the actual host's reviewer names", 'Include the DX
  metrics line only when ...', "Resolve `report.next` using the driver's
  applicable scope/skip rules") -> kept free: every report field line,
  `report.includeDxMetrics`, `report.next`, and the code-generated packet
  checks.
- Intake/DX-scope/call-site sentences ('without losing requirements', 'Use
  returned paths/`scope`', 'false and neither semantic trigger applies',
  'checks exact retention', the 'for both voices' tail) -> kept free: ACTIVE_PLAN
  field, save-to-ACTIVE_PLAN, conversation approval, backup-exactly, stop on
  helper error, `## Review record` (all /i where prose), init/scope/create/
  prepare-close CLIs, `dxRequired`, 2+ threshold, enabling flags, no-negation
  rule, snapshot/verbatim dispatch/outside-inline lines, stale path bans.

Mutation pass (scratch worktree; autoplan template, sections and generated
phase-close): 23/23 as expected; 16 reorder/old-order/tool-param/placeholder/
numeric/consent/stop/safety mutations go red, 7 rewordings and lowered caps
(ONLY/FINAL, Keep ONE phase) stay green. Log:
.context/mutation-autoplan-phase-order.md.
2026-10-03 01:13:42 +00:00
garrytan 227ec905a7 test(W7c): loosen auq-format-always-loaded per-skill rule pins
W7c conversion (t01 F10-F12; W7c list item auq-format-always-loaded:61-72).
The MANDATORY format list (machine-read Recommendation:/(recommended) and the
AUQ format labels, W7 keep list) is unchanged.

Removed assertion groups (invariant -> remaining protection):
- plan-ceo-review /Do NOT batch/i (t01 F10): one decision per question ->
  kept free: /One decision unit = one AskUserQuestion call/i in the same rule
  list.
- plan-eng-review full-sentence regexes 'Send `AskUserQuestion({ questions:
  [currentDecision] })` only after the pending-record checkpoint passes. Send
  one question object for one choice; other IDs wait' and 'If you discover
  another independent choice, separate it and rebuild this comparison before
  saving or sending the question' (t01 F11): one question object per
  independent choice survives the carve -> kept free: /one\s+question object
  for one choice/i and /independently selectable changes separate IDs/i; the
  checkpoint-before-send order stays pinned in eng-review-routing.test.ts.
- codex /Synthesis recommendation \(REQUIRED\)/i (t01 F12, caps marker):
  codex keeps its synthesis rule always loaded -> kept free: /Synthesis
  recommendation/i and the machine format /Recommendation\s*:\s*<action>\s*
  because/i.

Mutation pass (scratch worktree, generated SKILL.md and sections): 8/8 as
expected; removing Recommendation: <action> because, the synthesis rule, or
the CEO/eng/design decision-unit rules goes red; dropping (REQUIRED) and
rewording the two dropped eng sentences stays green. Log:
.context/mutation-auq-format-always-loaded.md.
2026-10-03 01:10:42 +00:00
garrytan 7dac647939 test(W7c): drop coverage-audit checklist tool-call prose pins
W7c conversion (t05 F11; unblocks s06 L9). Pin lines 17 -> 14.

Removed assertion group (invariant -> remaining protection):
- review/specialists/testing.md prose pins 'If the caller explicitly asks
  for an ASCII coverage diagram', 'dedicated tool call' and /Read diffs,
  package files, configs, or other context in separate tool calls\./ (tool-use
  choreography): the agent reads the named source and test files before
  drawing the diagram -> kept free: the same test still extracts the
  checklist's example diagram and requires coverageAuditVerdict to accept it
  (sourceRead/testsRead/diagram/passed), plus the kept [OK]/[GAP] row and
  legend pins; gate-tier E2Es review-coverage-audit, plan-eng-coverage-audit
  and ship-coverage-audit (E2E_TIERS: gate) grade the reads from transcript
  evidence with the same oracle.

Mutation pass (scratch worktree, review/specialists/testing.md): 6/6 as
expected; reordered diagram rows, deleted legend, deleted [OK] marker and a
removed text fence go red; two rewordings of the dropped tool-call sentences
stay green. Log: .context/mutation-coverage-audit.md.
2026-10-03 01:09:27 +00:00
garrytan 5aad90bc3f test(W7c): shrink eng-scope-entry-ap to structural and meaning checks
W7c conversion (t05 F1-F4; W7a s04 F15/F18 pins). Pin lines 97 -> 69
(toContain|toMatch|indexOf|includes|ordered). The AskUserQuestion-format
byte-equivalence test (t05 Kept) is unchanged. eng scope-gate E2Es are
periodic (plan-eng-review-plan-mode), so every scope-gate invariant keeps a
free check; duplicates of eng-review-routing cite that file.

Removed assertion groups (invariant -> remaining protection):
- 'Reply with A, B, or C. STOP and wait' order anchors (t05 F1): menu before
  bootstrap -> kept free: the consumed prefix 'Reply with A, B, or C'
  (pty/classify.ts, pty/judge.ts) before {{PREAMBLE}}, {{GBRAIN_CONTEXT_LOAD}}
  and the first ```bash; new presence checks for the announcement and menu
  after '## Scope gate' (an indexOf of -1 used to pass the order check).
- Preamble 'starting from the Scope gate...' exact pin: kept as /i meaning.
- Scope entry sentences ('Before discovery tools or preamble, check provided
  messages...', 'Do not probe for session state', 'When no exception above
  applied:', 'Announce an auto-selected plan in one line...', 'A fresh
  announcement made before skill loading...', 'Step 0 below still verifies or
  sends the public auto-selection line...') (t05 F4): target bound before
  bootstrap and announced -> kept free: announcement/menu-before-bootstrap
  order checks above, /first tool call = AskUserQuestion/i, /clarify
  ambiguous, conflicting, quoted or stale targets/i; periodic E2E
  plan-eng-review-plan-mode.
- Startup step sentences ('3. Check web-research readiness at ...', '4. Run
  **Design Doc Check**, then ...', 'Keep the reviewed target fixed', 'Continue
  at ...'): startup order -> kept free: ordered startup anchors (now including
  Prerequisite Skill Offer), '**Engineering review → Step 0**' pointer, the
  stale-path ban; 'Keep the reviewed target fixed' stays pinned (/i) in
  eng-review-routing.test.ts.
- Entry anchors 'Before Step 0, require resolved scope' and '**Complexity
  gate:** while a Scope Challenge complexity question' -> shortened anchors
  'require resolved scope' and '**Complexity gate:**', same order check.
- Plan-selection exception sentences and 'If the tool is unavailable,
  disallowed (`--disallowedTools`) ... send the menu as plain prose and STOP'
  (t05 F4): pasted text is not a mode signal; ambiguity and named targets ask;
  unavailable tool stops -> kept as /i meaning checks for each (safety and
  consent lines); A/B/C menu body kept exact (consumed by the PTY classifier).
- 'Reply with A, B, or C. STOP and wait for the answer.' exact: kept as the
  exact prefix plus /reply with A, B, or C\. stop and wait for the answer/i.
- Judge-bundle sentences ('format/transport rules apply throughout', 'Follow
  the blocks below in order after startup', 'It may be the selected plan or a
  separate file', 'Save permitted auxiliary artifacts under the write policy'):
  ordering and write permission -> kept free: stage order, write-policy table
  rows exact, /permission for one path authorizes no other/i, /defer ...
  telemetry and plan status footer to finish/i, forbidden-log Blocked outcome
  route (/i), section Read paths, log exit-code tails.
- Complexity-path duplicates of eng-review-routing (t05 F2: 'Complete these
  checks before...', 'After verification, apply only accepted scope changes',
  'Run C whether B...', 'Always ask the structure question...', post-answer
  summary/Read-back sentences, 'A failed save or Read blocks advancement',
  'Findings and scope answers approve no remedies', 'Continue to Section 1
  only when...', 'Send one question object for one choice', 'Compare every
  native field...', 'Repair any difference and repeat the complete Read
  before asking', 'Read the selected saved label...', 'Check the save result,
  then Read the entire resolution block', '**STOP until the actual answer
  arrives.**', the Paused question / Blocked outcome lines): the same
  invariants -> kept free in eng-review-routing.test.ts (order of
  Send/AskUserQuestion/Record, /stop until the actual answer arrives/i, failed
  save blocks, approve-no-remedies, Paused/Blocked recovery checks) and
  auq-format-always-loaded.test.ts (one question object per choice); here:
  A/B/C stage order and the 8-file / 2-class thresholds (/i, no caps STOP
  literal), Recovery routing pointer for unreadable records. The Read-back
  choreography is the dated text s04 F18 flags; judge
  'plan-eng-review/SKILL.md sections' (gate) grades the procedure.
- Calibration note exact sentences and the one-line formatting pin (t05 F3,
  W7a s04 F15): no shipped source enables BRAIN_CALIBRATION_WRITEBACK ->
  kept free: {{BRAIN_WRITE_BACK}} once after {{LEARNINGS_LOG}}, /never set it
  yourself/i, and a new code check that no file in bin/, lib/ or scripts/
  assigns or exports BRAIN_CALIBRATION_WRITEBACK (only the gbrain resolver
  names it).

Mutation pass (scratch worktree; plan-eng-review templates, generated
plan-eng-review skill, bin/gstack-config): 21/21 as expected; 14
reorder/marker/table/stop/safety/consent/code/numeric mutations go red, 7
rewordings and lowered-register lines stay green. Log:
.context/mutation-eng-scope-entry-ap.md.
2026-10-03 01:08:38 +00:00
garrytan 64dcd18df4 test(W7c): shrink eng-review-routing to structural and meaning checks
W7c conversion (t02 #4-#10, W7a s04 F15 pin). Pin lines 88 -> 74 (toContain|toMatch|indexOf|includes|ordered); ~50
full-sentence pins become order checks, field/marker checks and short
case-insensitive meaning checks. Remaining gate-tier judge for the plan-eng
prose: 'plan-eng-review/SKILL.md sections' (judge input is ENG_REVIEW_EXCERPT,
which the first test proves contains review-sections and Recovery routing).

Removed assertion groups (invariant -> remaining protection):
- Preparation sentences ('Follow the blocks below in order after startup',
  'Confidence Calibration and Decision procedure are reference rules'): blocks
  run in order -> kept free: heading order check now starts at
  '## Review preparation'; judge 'plan-eng-review/SKILL.md sections'.
- Priority/compression sentences ('Shorten only optional commentary', 'never
  Scope Challenge, Sections 1-4...', 'Never condense, abbreviate or skip a
  section'): compression cannot drop required stages -> kept free:
  /complete every required stage, decision gate and output/i and the
  'Everything else' stale ban; judge.
- Exact seven-label toEqual on Scope Challenge assessments (t02 #8): all
  seven checks present -> kept free: arrayContaining on the same labels plus
  the A/B/C heading toEqual (excerpt anchors).
- 'Complete these checks before the complexity decision in B': A runs before
  B -> kept free: heading order A < B < C.
- Below-threshold / findings sentences (numbered step full sentences): C
  always runs, findings approve nothing -> kept free: step-number order,
  /fewer than 8 files AND fewer than 2 new classes/i, /run C whether B was
  completed or skipped/i, /approve no remedies/i, '"No issues found"'.
- '... STOP before Section 1' exact caps (t02 #4): high complexity halts ->
  kept free: /at 8\+ files or 2\+ new classes\/services, stop before
  section 1/i.
- High-complexity sentences ('With no proposed cuts...', 'Both retain the same
  approved feature list...', 'Initial scope selectors need no grid...'): cuts
  and structure asked separately -> kept free: step order with short anchors,
  'Pending remedies not decided here: <ids>' field; judge.
- Smaller-arrangement sentences ('offer confirmation of the original
  arrangement or a pause', 'then return to this structure selector'): a pause
  authorizes no cut -> kept free: order + /do not continue to C until it is
  settled/i + /investigate only the agreed question/i.
- Selector summary sentences ('post-answer scope summary, not a remedy's pending
  ledger record', 'Do not invent a pre-answer record afterward', 'Scope
  Challenge B also uses its own selectors'): answers saved before applying ->
  kept free: field template order, /a failed save or read blocks
  advancement/i, '**not persisted**', /these selections approve no
  engineering remedy/i.
- Decision-procedure Read-choreography anchors ('use Read to fetch the entire
  saved record', 'Read the entire resolution block, including State') and the
  bold '**STOP until the actual answer arrives.**' anchor (t02 #5/#6, s04 F18):
  ask once, wait, record before the next choice -> kept free: Compare <
  Pending-record checkpoint < Send once < AskUserQuestion call < Record < next
  choice, /stop until the actual answer arrives/i located between Send and
  Record, /do not apply a remedy ... while the choice awaits an answer/i,
  /approves no implementation/i; AUQ completeness and kind-note strings kept
  exact (plan-tune reads them).
- 'An Investigate/Defer option must bound the investigation', 'Apply the
  preamble's Completeness scores or kind-note accordingly': judge only (gate).
- Research/outside-voice sentences ('If Aside is unavailable, use host
  WebSearch', 'Record the actual coverage...'): unavailable research is
  recorded, not hidden -> kept free: exact 'Search unavailable' output string,
  'Outside voice: recorded provider, completed / unavailable / disabled /
  skipped (reason)' field, /only completed reviews enter cross-model tension/i,
  TODO < Approval readiness < Required outputs order.
- Recovery sentences: kept as /i meaning checks (ExitPlanMode/telemetry wait,
  do not resend, stop before dependent output, no chat-only success, skip
  forbidden writes); 'If no recovery is specified or it fails' full sentence
  -> kept free: 'follow **Blocked outcome**' routing; OUTCOME=error kept.
- Late-change sentences ('Refresh affected tests, tasks, dependencies and
  parallelization', 'Unchanged saved outputs may reuse their successful Review
  Log'): rerun affected outputs before navigation -> kept free: order of
  return/Decision procedure/Approval readiness/Required outputs/navigation and
  the stale-evidence Blocked outcome route; judge.
- Final sequence anchor 'Run Learning hooks, including gated Brain Calibration
  Write-Back; then return to the entrypoint's Section self-check' -> kept
  free: 'Section self-check' as the last ordered anchor.
- Coverage-audit sentences ('For each existing or proposed component in the
  selected target', 'the selected target. For each existing or proposed
  feature', 'dedicated tool call before drawing the diagram' (s06 L9
  choreography)): plan diagrams cover proposed paths, ship covers changed code
  -> kept free: /existing or proposed (component|function\/method)/,
  /future paths remain proposals/i, the four 'Every ...' obligations,
  /no skipping regression coverage/i, ship has no 'existing or proposed';
  gate E2E plan-eng-coverage-audit.
- Brain write-back ordered prose list ('reserved default-off gate', 'this
  runtime does not set it', 'not an instruction to write now', t02 #9 / W7a
  s04 F15): no gbrain write without the default-off gate and trust policy ->
  kept free: 'Skip unless `BRAIN_CALIBRATION_WRITEBACK` is set' precedes both
  write tools, eng prefix says /skip this section/i and /do not enable it or
  infer permission/i, trust-policy key, /if unknown, skip/i, no env
  interpolation, other skills carry no eng-only skip prefix.

Mutation pass (scratch worktree; plan-eng-review templates and
scripts/resolvers/gbrain.ts): 21/21 as expected; 14 reorder/marker/stop/
approval/consent/numeric mutations go red, 7 rewordings of dropped sentences
and lowered-register STOP lines stay green. Log:
.context/mutation-eng-review-routing.md.
2026-10-03 01:06:43 +00:00
garrytan 03a4521dda test(W7c): shrink ceo-workflow-clarity to structural and meaning checks
W7c conversion (t05 F5-F8). Pin lines 48 -> 29 (toContain|toMatch|indexOf|includes|ordered); sentence pins
collapse to one case-insensitive meaning check per invariant. Per the Eng
"Retirements" item, CEO invariants count as periodic-only once
plan-ceo-review-benefits retires, so every invariant below keeps a free check.

Removed assertion groups (invariant -> remaining protection):
- Required/Pending/Settled status sentences (4 pins): pending work stays
  unapproved; only exact authority settles a choice -> kept free: label order
  plus /Pending: unapproved/i and /Settled: ... a recommendation does not/i.
- Admin-route sentences (Skip steps 1-4, 0E/0H ownership, admin answer that
  requests a plan change, 0G proposals use this route, mode-change pointer):
  admin menus approve nothing and return locally -> kept free: Admin < Plan
  decision < steps 1-4 < checkpoints order, /this approves no plan changes/i,
  /0D returns to its caller, not to mode selection/i.
- not.toContain('0D never restarts mode selection') and
  not.toContain('using the Step 0E mode-handoff format') (t05 F8, bans of
  retired phrasings): same invariants -> kept free: the positive route checks.
- '**STOP for the actual answer, even for a lone option.**' exact bold pin:
  wait for the answer before recording -> kept free: /stop for the actual
  answer/i, located between step 4 and the post-answer checkpoint.
- Mode-change sentences (repeat handoff record, complete newly applicable
  Step 0 work, resume the paused step): a mode change waits for an answer ->
  kept free: /pause and ask ... keep the mode until answered/i and
  /selecting a mode does not approve changes/i; routing table rows kept exact.
- Scope-count sentences: reuse counts against limits, mode recommendation
  excludes unchanged reuse, neither approves -> kept free: three short
  case-insensitive meaning checks plus the >15 / 8-file / 2-class numbers and
  the route order.
- Completion-fraction sentences (select answered questions, exclude unscored,
  Y/X definitions): fraction definition -> kept free: 10/7/3 scale, reopened
  choice counted once, 'Report X/Y, or `N/A` when Y is zero' (output field).
- Section-gate sentences ('0D's Plan decision route through its post-answer
  save', 'Resolve critical risks now') and the literal Decision gate count 11
  (t05 F7): one gate per section -> kept free: path order, /no path selects
  the mode again/i, gate count derived from '### Section N:' headings.
- Section 1 opening sentences (retain mode/rationale, governing row ID): Section
  1 publishes current dispositions, not a mode handoff -> kept free:
  **Current scope** present, the four disposition names, /not another mode
  handoff; do not ask or log the mode again/i.
Gate-tier judge that also grades this prose: 'plan-ceo-review/SKILL.md modes'.

Mutation pass (scratch worktree, generated plan-ceo-review skill): 16/16 as
expected; 11 kept-step/marker/safety/numeric mutations go red, 5 rewordings of
dropped sentences (and a lowered-register STOP line) stay green. Log:
.context/mutation-ceo-workflow-clarity.md.
2026-10-03 01:06:43 +00:00
garrytan 23a0be82d7 chore: regenerate SKILL.md, goldens and context-budget fixture for the Opus 5.5 prompt cleanup 2026-10-03 00:53:58 +00:00
garrytan 841a766eec Merge remote-tracking branch 'origin/garrytan/opus55-wip-D' into garrytan/opus-5-5-prompt-audit 2026-10-03 00:52:54 +00:00
garrytan 737bf478d9 test: dedicated-tools overlay case pinned to claude-opus-5-5 (E2) 2026-10-03 00:49:02 +00:00
garrytan b54b1e4d97 docs: overlay benchmark contract v3 (dedicated-tools gate = correct output + 20% fewer Bash) 2026-10-03 00:46:58 +00:00
garrytan 522e300d4e Merge remote-tracking branch 'origin/garrytan/opus55-wip-B' into garrytan/opus-5-5-prompt-audit 2026-10-03 00:46:40 +00:00
garrytan 806dda8fa3 Merge remote-tracking branch 'origin/garrytan/opus55-wip-C' into garrytan/opus-5-5-prompt-audit
# Conflicts:
#	test/skill-e2e-plan-ceo-plan-mode.test.ts
2026-10-03 00:46:40 +00:00
garrytan 0355b91c89 Merge remote-tracking branch 'origin/garrytan/opus55-wip-E' into garrytan/opus-5-5-prompt-audit 2026-10-03 00:46:21 +00:00
garrytan 52064e6883 Merge remote-tracking branch 'origin/garrytan/opus55-wip-A' into garrytan/opus-5-5-prompt-audit 2026-10-03 00:46:21 +00:00
garrytan e28ef17040 test: plan-design SDK fixture pins its harness prompt once, by ordered properties (W7e plan-design-sdk-fixture.test.ts:91-120; t01 F13)
The prompt was pinned three ways (sha256, ~20 sentences, an order check).
Kept: the skill and lazy-section paths, the plan path, the ordered
read -> review -> edit -> Write -> read-back -> summary steps, and the
no-browsing rule (case-insensitive). Dropped the hash and sentence pins.
Negative control: removing the read-back step turns it red.
2026-10-03 00:44:13 +00:00
garrytan c2d3182f24 test: shared-libs revalidation prompt keeps its machine-shaped checks, not ~69 phrase pins (W7e shared-libs-revalidation-prompt; t11 #3, #8; t05 F17)
reviewRevalidationPrompt and reviewPrompt are test-owned harness prompts
(non-test callers: 0); the paid shared-libs E2Es measure whether they work.
Kept: the three exact receipt commands, base-prompt prefix and resumed suffix
identity, branch selection (actor / default / resumed coverage), the state
path and turn-budget interpolations, read-record-before-diff and
first-response-before-start ordering, no embedded token, no supplied Skip
answer, reusable:true before reusable:false, the captured R59 stage boundaries
in the exclusion list, asset roots and interfaces, and the stale step-6
reference ban. The review template's Step 4.7/4.8 completion rule is matched
by step number on one line, not by sentence. Negative control: reordering the
diff-read instruction turns the test red.
2026-10-03 00:44:13 +00:00
garrytan a31c0a7ece test: docsync lifecycle interface drops pins on its own helper prompt (W7e docsync-lifecycle-interface.test.ts; t02 #17)
docsNativeInterface is the test helper's own prompt, so its sentence pins
only checked that the helper says what it says. Kept: owned skill path, the
two extracted lifecycle commands (exact), the scripts-list interpolation, the
repo path and Git read examples, and every docsCommandAllowed /
docsToolFailures behavior check that enforces the interface.
2026-10-03 00:44:12 +00:00
garrytan 744e5a2392 test: office-hours review-preservation judge test keeps its schema and untrusted-data checks, not its wording (W7e office-hours-completion.test.ts:416-429; t09 F10)
Drops 13 phrase pins on the judge prompt. Kept: both inputs carried as JSON,
the response schema (wire format), and the separate untrusted-DATA test. The
validator behavior tests already use stub judges. Negative control: changing
the schema string in the prompt builder turns the test red.
2026-10-03 00:44:12 +00:00
garrytan 8962715176 test: section-capture native tools checks harness prompt properties, not a copied golden (W7e section-capture-native-tools.test.ts:467; t04 F4)
Asserts the absolute skill path is the only SKILL.md named, the scenario,
AskUserQuestion unavailable, the section Read rule (case-insensitive, also at
:308), no git/gh/mutation, and the REPORT.md path. argv/tool-list checks are
unchanged. Negative control: dropping the no-mutation rule turns it red.
2026-10-03 00:44:12 +00:00
garrytan 903c46f3d4 test: session-runner-tools checks harness prompt properties, not a byte-for-byte copy (W7e session-runner-tools.test.ts:544; t09 F7, F8)
The ship capture prompt test asserts its purpose (no CEO-only writing
guidance) plus the functional rules: one allowed skill path, AskUserQuestion
unavailable, the section Read rule, no git/gh/mutation, and the REPORT.md
path. The two 'MUST actually Read' pins match the Read rule case-insensitively.
Negative control: dropping the no-mutation rule from the harness prompt turns
the test red.
2026-10-03 00:44:12 +00:00
garrytan d1e3eadff8 test: plan-eng artifact case binds to the hermetic state root and requires the artifact; report case drops its shouted requirement (W7g plan-artifact fixture binding; W7g skill-e2e-plan.test.ts:479,720)
- plan-eng-review-artifact: actor, observer and cleanup use one isolated
  GSTACK_HOME (the hermetic run's, or a seeded temporary one when hermetic
  mode is off) and the slug gstack-slug resolves for the fixture, instead of
  os.homedir()/.gstack/projects/test-project. A guard refuses a state root
  under the real home, and cleanup removes only the fixture's project
  directory. The 'IMPORTANT … you MUST write the test-plan artifact' line is
  replaced by the environment fact (state root and slug). The soft warning
  becomes an assertion: exactly one new *eng-review-test-plan-*.md about the
  reviewed dashboard change.
- plan-review-report: removes 'CRITICAL REQUIREMENT … MOST IMPORTANT
  deliverable' and the restated report contract; keeps 'plan.md is the plan
  file'. The existing assertions (report present, last, rows, unresolved
  status) now measure the skill's own report prose.
2026-10-03 00:44:12 +00:00
garrytan f43fe0de13 test: eval-kinds drops the exact 22 behavior / 25 judge census (W7d exact count in eval-kinds; t12 F6)
The kind contract is already asserted: every live case has one kind, kinds
are rule/behavior/judge, every LLM judge is judge-kind, every behavior case
has a literal registration and a BEHAVIOR_WHY, and the named contract-shaped
cases stay rule. The census count only broke on adding or retiring a case.
2026-10-03 00:44:12 +00:00
garrytan 0725d99d99 test: browse reference judge gates on its stated floors; the baseline comparison is recorded, not a ratchet (W7d browse judge baseline ratchet; t08 F7)
expect(regressions).toEqual([]) compared a noisy three-sample mean against
eval-baselines.json (clarity 4), silently raising the stated clarity floor of
3. The comparison stays in judge_reasoning; pass and assertions use
BROWSE_JUDGE_FLOORS (clarity 3, completeness 4, actionability 4). Judge
prompt and schema are unchanged. Stored panel means: three known-good (two the
ratchet rejected) pass; three below-floor panels fail.
2026-10-03 00:44:12 +00:00
garrytan 99720e744e test: CEO plan-mode failure message names the current rule, not the '## CRITICAL RULE' heading (t13 F20) 2026-10-03 00:44:12 +00:00
garrytan 833a35de8a test: plan-design judge selection check anchors on the question-procedure heading (W7a judge-anchor move; touchfiles.test.ts:219)
Same structural anchor as the other judge-anchor moves; selects the same text
on the current templates and after the '## How to ask questions' rename.
2026-10-03 00:44:12 +00:00
garrytan ea116a16d1 test: plan-mode smokes check the targeted plan, not the scope-gate announcement, and reject plan-file ## Decisions (W7d exact scope-gate line; W7g plan-mode ## Decisions)
- Seeded eng/design plan-mode cases keep 'no scope menu' and replace the
  exact 'Scope gate: plan mode — auto-selected B' requirement with
  seededPlanTargeted(): the announcement or native seeded-plan selection, or
  seed-only plan names appearing in the review output after the slash command
  (trackTokens). The announcement is logged.
- The AskUserQuestion format forbids writing a decision to the plan file as a
  substitute for asking. assertNoPlanFileDecisions() fails any plan_ready run
  whose plan carries ## Decisions (eng, design, devex, office-hours
  auto-mode). The AUQ-blocked cases (eng seeded, devex, office-hours) now
  require outcome 'asked' (AskUserQuestion variant or prose fallback).
- plan-mode-evidence registration controls keep their verdicts; the
  missing-decisions control now fails on 'without a question'.
- plan-mode-targeting.test.ts stores known-good (announcement; paraphrase plus
  seed content) and known-bad (neither; an untracked token) observations and
  plan files with and without ## Decisions.
2026-10-03 00:44:12 +00:00
garrytan 0420a06e91 test: plan-format accepts any statement that kind-differentiated options are not comparable on coverage (W7d 'options differ in kind' phrase)
The outcome, no fabricated Completeness: N/10, stays asserted. The required
note now matches any brief wording of the same fact (KIND_NOTE_RE in
helpers/plan-format-kind-note.ts). The format-compliance suite that pins the
declared kind-note string is unchanged. Stored lines: four known-good pass,
three known-bad (a completeness score, a recommendation, 'kind to the user')
fail.
2026-10-03 00:44:12 +00:00
garrytan 93ef6f69be test: test-value review accepts any caller search, not only the literal 'git grep' (W7d literal git grep in test-value)
recordsNonTestCallerSearch keeps the value-card contract (non_test_callers
recorded) and accepts git grep, rg, grep or the Grep tool as the search.
Severity checks and the golden exclusion are unchanged. Stored evidence:
four known-good (three the old check rejected) pass; three known-bad (no
search, no caller count, prose only) fail.
2026-10-03 00:44:12 +00:00
garrytan e0f30196a7 test: shared-libs PR coverage checks the stated page budget, not per-PR ceilings from one run (W7d shared-libs per-endpoint page caps)
prCoverageRequestViolations keeps the skill's stated older-open-PR budget
(five metadata pages, fifty file-list pages plus recent PR 7) and the coverage
outcome (PR 42's file list read from page 1 through page 2). It drops the PR 42
three/four-page and single-first-page ceilings, which were tuned to one
observed capture with a truncated first view. The judge criteria are
unchanged. Stored endpoint lists: three known-good (including a re-read first
page the old ceilings rejected) pass; four known-bad plus an over-budget
file-list run fail. incompleteFirstFileView is no longer used by the paid case.
2026-10-03 00:44:12 +00:00
garrytan fae9a05c12 test: CEO split-overflow call floor is two, the minimum for five options at four per call (W7d split-overflow 4-call floor)
The regression is a candidate silently dropped to fit the four-option cap.
The scope validator already requires an offered Include/Defer/Cut disposition
for all five candidates; the extra N-1 call floor failed agents that batch
compatible candidates, which the test header calls legitimate. FLOOR now comes
from CEO_SPLIT_CALL_FLOOR = 2. Stored shapes (ceo-split-floor.test.ts): five
sequential, 2-call and 3-call batches pass; a dropped candidate fails with
'missing target decisions'. The registration controls keep their verdicts;
the 3-call plan_ready scenario still fails, now on missing decisions.
2026-10-03 00:44:12 +00:00
garrytan e30fcf732a test: investigate boundary grader checks the verified fix, not one Edit and one verify (W7d investigate exactly-one ritual)
Completion now needs at least one allowed Edit, the correction in place, at
least one verifier run whose final status is 0, and no edit after the final
verification. The ending-error case still requires a single verifier run
(status 69), because that fixture's error tells the actor to stop without
retrying. Ownership acquisition/release checks are unchanged. New free
protocol controls: a passing re-verification passes (the old grader failed
it); a failing final re-verification and a retry after the ending error both
fail, as they did before.
2026-10-03 00:44:12 +00:00
garrytan 5701c3d903 test: disabled outside-plan grader reads the run's own coverage self-report (W7d disabled-plan-review-evidence)
The false-completion oracle kept being patched to tell historical review-log
mentions from current claims. The E2E prompt now asks for a closing JSON line
{"outside_review_this_run": ...}. When present, the coverage claim is that
report ('completed' fails) plus any undenied 'both reviewers agree';
'disabled' also satisfies attribution. Runs without it keep the existing
prose oracle, so all stored captures and mutation rows keep their verdicts.
Dispatch, CLI execution, preflight and persisted-disabled checks are
unchanged. Stored outputs: three known-good pass (the old grader rejected
the table form); four known-bad fail.
2026-10-03 00:44:12 +00:00
garrytan a6b0240971 test: coverage audit grades a closing tested/untested summary before the diagram grammar (W7d coverage-audit-evidence)
The diagram grammar grew through four waves of capture patches to accept
correct-but-different diagrams. The E2E prompt now asks for one closing JSON
line {"tested": [...], "untested": [...]}; coverageAuditVerdict passes the
outcome when processPayment is only in tested and refundPayment only in
untested (last summary wins; quoted or example summaries ignored). The legacy
grammar stays as a fallback, so every stored capture keeps its verdict
(all existing rows unchanged). Read evidence and capture success are still
required. Stored summaries: three known-good (which the old grader rejected)
pass; seven known-bad fail.
2026-10-03 00:44:12 +00:00
garrytan dbff2527b0 test: AUQ matrix fails only on the format fields software reads (W7d AUQ matrix emoji check)
auqMachineFormatProblems() fails a first-question run when the
Recommendation: line is missing or empty, or when the brief does not label
exactly one option (recommended); recommendation substance >= 4 is unchanged.
ELI10, Pros / cons, ✅/❌ and Net: are still scored and logged but no longer
fail a paid case. scoreAuqFormat and the consistency suite are unchanged.
Stored briefs: three known-good (including one without emoji or Net) pass;
four known-bad (no or empty Recommendation, zero or two (recommended)) fail.
2026-10-03 00:44:12 +00:00
garrytan b1083a52a6 test: docsync observer accepts harmless read wrappers (W7d docsync observer)
docsCommandAllowed now unwraps, on read-only commands only (pwd, ls, cat,
stat, sha256sum, Git reads): a leading 'cd <fixture repo> &&', '2>/dev/null',
a trailing '|| true', '--no-pager', '-C <fixture repo>' and '-c' with
core.pager=cat / core.quotepath / color.* settings. Lifecycle and script calls
stay literal so their failures cannot be suppressed. Writes, other repos,
--git-dir/--work-tree, config that can execute code, real composition and
redirects stay rejected.

Stored commands (fixtures/docsync-observer-commands.json): 11 known-good read
forms, which the old observer rejected, now pass; all 17 known-bad forms still
fail under the new and old observers. docsync-command-grammar moves its three
harmless rows to an accept test and keeps unsafe variants of them as rejects.
2026-10-03 00:44:12 +00:00
garrytan b96e5f5d1a test: CEO HOLD preservation grader checks the decision, not its phrasing (W7d CEO mode-routing regex judge, ceo-mode-option.ts:410-440)
Drops the exact 'Keep <x> in scope' / 'Defer <x> to TODOS' labels, the
'D<n> — Keep … in scope, or defer' title, the '<plan>.md lists' phrase and the
2-of-5 keyword quota. Keeps the evidence bindings (native answer, session,
timestamps, source read, mode context, later withdrawal) and now requires: one
keep option and one defer option, the answer selects keep, a word of the kept
label names a listed plan requirement, no expansion language, and an ELI10 +
Stakes rationale of at least 20 words (so a bare mode label still fails).
Stored captures: both retained known-good runs pass; every existing known-bad
mutation still fails; four rewordings the old grader rejected now pass; three
new known-bad cases fail. The Net/Note single-brief checks (t02 #3) are
unchanged: the 'second sentence after Net' row adds scope ('Also add shared
views'), so it stays a known-bad.
2026-10-03 00:16:37 +00:00
garrytan 77506e8891 test: design-review-fix asserts a fixed design issue, not only the Aside ritual (W7b design-review-fix)
Keeps the engine-routing checks (Aside driven, retired binary unused) and adds
the outcome: design-audit.md exists, names a seeded defect, and index.html or
style.css differs from the initial fixture commit. The style(design) commit
prefix is not required. This case still cannot gate the design-review
stop-condition rewrite (it self-skips without Aside and caps fixes in its
prompt), per the Eng item.
2026-10-03 00:16:37 +00:00
garrytan 2860095bf2 test: ship triage asserts each failure's in-branch/pre-existing label (W7b ship triage)
The old check passed if the words 'in-branch', 'pre-existing', 'math' and
'string' appeared anywhere in the final message, in any pairing. The prompt
now asks for a closing JSON map; helpers/ship-triage-labels.ts reads it (or
unambiguous per-failure lines) and the test requires truncate/string ->
in-branch and divide/math -> pre-existing, plus a Bash call that ran the
suite. Stored outputs show swapped, words-only and one-label runs fail.
Drops the untyped recordE2E extras (typecheck baseline shrinks by one).
2026-10-03 00:16:37 +00:00
garrytan d48ba12c2e test: land-and-deploy E2Es state environment facts instead of scripting the skill (W7b deploy prompts)
The workflow, first-run and review-gate prompts drop the 'IMPORTANT … simulate:
1. Detect … 2. Infer … 3. Note …' scripts and the answers they supplied
(platform, app, URL, merge method, 'Eng Review should be NOT RUN'). They keep
the facts the fixture cannot provide (no remote, no PR, gh/fly unavailable,
gstack-review-read output, report directory). Assertions now check the outcome:
the artifacts name Fly and test-app, and the readiness report records the
missing review. Canary, benchmark and setup-deploy prompts are unchanged.
2026-10-03 00:16:37 +00:00
garrytan 27e962b2b8 test: skillify E2E stops scripting the skill and routes with the shipped section (W7b skillify prompt + routing fixture; W7d skillify narration ban)
- CLAUDE.md fixture: the shipped ## Skill routing section replaces 'ALWAYS
  invoke it via the Skill tool as your FIRST action' and its hand-written rules.
- scrape-match-path: prompt is 'Run /scrape latest hacker news stories'; the
  'You MUST follow … 1. Run skill list … Do NOT enter the prototype phase'
  script is gone. Asserts the outcome: the bundled skill ran, no goto
  prototyping, no new skill or skillify staging written. Listing is logged.
- scrape-prototype-path: drops the five-step script and the self-fulfilling
  'Suggest /skillify'; keeps the user's JSON shape request.
- skillify-provenance-refusal: prompt no longer dictates the refusal.
- Narration grader moves to helpers/skill-body-narration.ts: line-start
  'I '/'I'll '/'Let me ' plus mid-sentence 'let me <verb>', so 'let me know'
  is legal. Stored known-good/known-bad bodies show it still rejects every
  known-bad case the old /Let me /i ban caught.
2026-10-03 00:16:37 +00:00
garrytan af041beee1 test: context-skills E2E routes with the shipped ## Skill routing section (W7b routing fixture)
Replaces the shouted 'ALWAYS invoke it … FIRST action' fixture and its
hand-written context-save/restore rules with the section gstack appends to
CLAUDE.md, which already routes save/resume to those skills.
2026-10-03 00:16:37 +00:00
garrytan 4e80e41a4c test: routing E2E uses the routing instruction gstack ships (W7b routing fixture; skill-routing-e2e.test.ts:113)
readShippedSkillRouting() parses the '## Skill routing' section from the
routing-injection heredoc in bin/gstack-skill-start at test time. The journey
fixture now carries that instruction instead of 'ALWAYS invoke … FIRST action.
Do NOT answer directly', and still withholds the per-skill rule list so a
regressed description can fail. bin/gstack-skill-start and the helper join the
journey, context-skills and skillify touchfiles. A free check catches heredoc
drift. Runs on unchanged templates set the new baseline.
2026-10-03 00:16:37 +00:00
garrytan e77cebf718 test: document-release E2E stops coaching the rules it measures (W7b; UC2 gate eval for NEVER CLOBBER / NEVER BUMP)
Drops the IMPORTANT block at skill-e2e-workflow.test.ts:76-83, including
'auto-approve everything' and the CHANGELOG/VERSION instructions; keeps only
the environment facts (non-interactive, no remote). Asserts the outcome: the
original CHANGELOG entries remain, VERSION still reads 1.1.1, no commit after
the fixture head touches VERSION, and README mentions Feature C.
2026-10-03 00:16:37 +00:00
garrytan 0b282e610f test: dedicated-tools overlay gates on correct output plus 20% fewer Bash calls (Eng W7 overlay predicate; replaces overlay-nudges.ts:213 taskCorrect)
Every ON trial must pass the fixture's verify (already a valid-measurement
requirement) and lowerIsBetter20Pct must hold; when the OFF median is 0, every
ON trial must also be 0. assessOverlayArms enforces both through a new
fixture.gate. Overlay contract bumps to v3 so v2 records are never
reinterpreted. overlay-measurement gains rows for correct+worse (fails),
20%+incorrect (fails) and the zero baseline (passes only at 0). The prose
comment follows the s01 M1 claude.md wording.
2026-10-03 00:16:37 +00:00
garrytan 9c7995857e test: CEO governing-stage order anchors on the question-procedure heading (W7a judge-anchor move; skill-ceo-section-ordering.test.ts:938) 2026-10-03 00:16:37 +00:00
garrytan 2569c918f8 test: plan-design workflow judge ends its slice at the question-procedure heading (W7a judge-anchor move; skill-llm-eval.test.ts:638)
Judge input is byte-identical on the current templates; judge prompts and
schemas are unchanged.
2026-10-03 00:16:37 +00:00
garrytan c4d133128c test: plan-design judge-input case anchors on the question-procedure heading (W7a judge-anchor move; workflow-judge-input.test.ts:366,373) 2026-10-03 00:16:37 +00:00
garrytan 7a80bab143 test: anchor plan-design excerpts on the question-procedure heading, not '## CRITICAL RULE' (W7a judge-anchor move; workflow-excerpt.test.ts:109,296)
The end marker now accepts a RegExp. ASK_QUESTIONS_HEADING matches the heading
with or without its 'CRITICAL RULE — ' prefix, so the excerpt is byte-identical
on the current templates and survives the s04 F9 / s05 L3 rename.
2026-10-03 00:16:37 +00:00