Garry Tan and capy-ai[bot]
910093087d
Stop the secrets check flagging code that reads an environment variable (GST-1894) ( #4157 )
...
* Stop the secrets check flagging code that reads an environment variable (GST-1894)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* Keep the new secrets test rows out of the line-start credential shape
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* Give the fixture-label exemption only to files named like tests
A production file such as ab-test.ts or load-test.ts matched the test-file pattern, so a weak real password in it stopped being flagged. The pattern now matches only the documented forms: *.test.*, *.spec.*, *_test.* and test_*.py.
Review-Finding: p1/red-team#1 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* Keep flagging a hardcoded fallback in backticks or on the next line
The env-read exemption only looked for a quoted fallback on the same line, so token = opts?.env?.API_TOKEN ?? followed by a backtick literal, or by a literal wrapped onto the next line, passed the secrets check. Backtick literals now count, and the next line is read when the expression continues there. The changelog now says plainly that an ALL-CAPS literal used as the variable name still passes.
Review-Finding: voices/outside-voice#1 reader=outside-voice
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* Exempt an env read only when its line has no fallback, and stop reading the next line
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* Say in the changelog that quoted lowercase env names now fail the secrets check
Review-Finding: p1/red-team#1 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
---------
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-08 06:56:02 +00:00
..
2026-10-01 11:57:48 -07:00
2026-10-31 18:12:53 +00:00
2026-11-08 02:18:23 +00:00
2026-10-26 10:44:36 +00:00
2026-11-03 10:52:35 +00:00
2026-11-07 11:44:50 +00:00
2026-11-05 00:43:21 +00:00
2026-10-30 12:03:08 +00:00
2026-11-08 00:59:38 +00:00
2026-11-02 01:35:47 +00:00
2026-10-17 03:32:16 +00:00
2026-11-07 09:53:38 +00:00
2026-11-07 16:53:52 +00:00
2026-10-14 17:36:39 +00:00
2026-11-02 14:49:46 +00:00
2026-11-04 03:03:39 +00:00
2026-11-02 14:49:46 +00:00
2026-11-02 05:13:19 +00:00
2026-11-02 01:35:47 +00:00
2026-11-02 05:13:19 +00:00
2026-11-03 02:08:50 +00:00
2026-11-07 19:18:08 +00:00
2026-11-04 00:31:14 +00:00
2026-10-13 15:17:39 +00:00
2026-11-04 03:42:16 +00:00
2026-09-22 14:57:52 -04:00
2026-10-16 23:09:23 +00:00
2026-11-03 02:08:50 +00:00
2026-11-04 03:42:16 +00:00
2026-11-02 01:35:47 +00:00
2026-11-04 03:03:39 +00:00
2026-11-07 08:39:20 +00:00
2026-11-07 08:39:20 +00:00
2026-11-02 14:49:46 +00:00
2026-11-02 14:49:46 +00:00
2026-11-03 02:08:50 +00:00
2026-11-07 18:43:11 +00:00
2026-10-10 23:26:08 +00:00
2026-10-11 03:10:06 +00:00
2026-10-31 16:31:27 +00:00
2026-11-01 05:57:18 +00:00
2026-10-26 04:32:27 +00:00
2026-11-03 02:08:50 +00:00
2026-11-06 12:33:37 +00:00
2026-11-07 06:52:04 +00:00
2026-10-30 21:28:02 +00:00
2026-11-06 17:16:24 +00:00
2026-11-02 09:26:46 +00:00
2026-11-07 15:44:35 +00:00
2026-11-07 05:51:12 +00:00
2026-10-30 12:03:08 +00:00
2026-09-14 14:32:45 -07:00
2026-10-08 08:00:08 +00:00
2026-10-16 22:00:32 +00:00
2026-10-11 18:16:33 +00:00
2026-10-07 23:29:05 +00:00
2026-10-29 10:29:23 +00:00
2026-10-26 10:57:52 +00:00
2026-10-11 03:10:06 +00:00
2026-11-08 00:59:38 +00:00
2026-10-29 09:58:34 +00:00
2026-11-03 01:40:07 +00:00
2026-11-08 02:18:23 +00:00
2026-10-27 11:03:59 +00:00
2026-09-08 22:40:22 -07:00
2026-10-01 13:55:16 -07:00
2026-11-07 06:52:04 +00:00
2026-09-08 22:40:22 -07:00
2026-09-08 22:40:22 -07:00
2026-10-17 02:10:12 +00:00
2026-11-02 01:35:47 +00:00
2026-10-01 11:57:48 -07:00
2026-10-19 07:26:49 +00:00
2026-10-17 02:40:45 +00:00
2026-10-31 22:41:36 +00:00
2026-11-03 17:08:30 +00:00
2026-10-11 03:10:06 +00:00
2026-11-02 21:28:30 +00:00
2026-11-07 06:01:30 +00:00
2026-11-02 17:44:00 +00:00
2026-11-07 08:39:20 +00:00
2026-09-14 15:14:58 -07:00
2026-10-30 03:14:00 +00:00
2026-10-18 19:26:19 +00:00
2026-11-07 19:18:08 +00:00
2026-11-07 22:12:57 +00:00
2026-10-16 22:00:32 +00:00
2026-10-25 06:51:16 +00:00
2026-11-03 00:39:09 +00:00
2026-11-03 00:39:09 +00:00
2026-10-25 05:06:30 +00:00
2026-10-04 07:58:41 -07:00
2026-11-07 05:51:12 +00:00
2026-11-07 05:51:12 +00:00
2026-10-01 11:57:48 -07:00
2026-10-02 11:11:00 -07:00
2026-11-08 03:23:53 +00:00
2026-10-28 10:16:23 +00:00
2026-11-07 22:18:18 +00:00
2026-11-03 15:41:57 +00:00
2026-11-07 06:39:20 +00:00
2026-11-01 09:19:25 +00:00
2026-11-03 22:58:53 +00:00
2026-11-05 00:53:58 +00:00
2026-10-27 01:45:08 +00:00
2026-11-02 17:44:00 +00:00
2026-11-05 09:21:26 +00:00
2026-10-11 03:10:06 +00:00
2026-11-07 07:39:51 +00:00
2026-10-20 23:55:41 +00:00
2026-10-04 07:58:41 -07:00
2026-10-11 19:09:12 +00:00
2026-11-02 14:49:46 +00:00
2026-11-04 01:31:37 +00:00
2026-10-08 08:00:08 +00:00
2026-10-08 08:00:08 +00:00
2026-10-08 08:00:08 +00:00
2026-10-25 01:25:19 +00:00
2026-10-08 08:00:08 +00:00
2026-10-08 08:00:08 +00:00
2026-10-08 08:00:08 +00:00
2026-10-27 03:04:06 +00:00
2026-10-27 03:04:06 +00:00
2026-11-04 03:03:39 +00:00
2026-11-01 06:11:17 +00:00
2026-11-01 06:11:17 +00:00
2026-10-11 19:09:12 +00:00
2026-11-07 22:12:57 +00:00
2026-11-02 14:49:46 +00:00
2026-11-03 03:24:35 +00:00
2026-11-03 02:08:50 +00:00
2026-11-04 01:22:38 +00:00
2026-10-11 16:48:11 +00:00
2026-11-08 00:59:38 +00:00
2026-11-01 06:11:17 +00:00
2026-10-16 23:09:23 +00:00
2026-11-08 00:59:38 +00:00
2026-11-03 10:52:35 +00:00
2026-11-07 05:51:12 +00:00
2026-11-07 05:51:12 +00:00
2026-11-03 02:18:33 +00:00
2026-10-27 10:16:08 +00:00
2026-10-31 04:53:38 +00:00
2026-11-03 03:14:57 +00:00
2026-11-02 17:44:00 +00:00
2026-10-01 11:57:48 -07:00
2026-11-03 01:40:07 +00:00
2026-11-08 06:56:02 +00:00
2026-10-29 04:37:43 +00:00
2026-11-04 01:22:38 +00:00
2026-11-07 05:51:12 +00:00
2026-11-08 00:59:38 +00:00
2026-11-06 23:55:54 +00:00
2026-10-02 11:11:00 -07:00
2026-11-02 14:49:46 +00:00
2026-11-04 03:38:56 +00:00
2026-11-04 03:38:56 +00:00
2026-11-04 03:42:16 +00:00
2026-11-02 14:49:46 +00:00
2026-11-06 18:14:51 +00:00
2026-11-07 18:02:40 +00:00
2026-11-02 14:49:46 +00:00
2026-11-03 17:08:30 +00:00
2026-11-08 00:59:38 +00:00
2026-11-01 06:11:17 +00:00
2026-11-08 01:46:06 +00:00
2026-11-08 00:59:38 +00:00
2026-11-01 13:28:21 +00:00
2026-11-03 01:40:07 +00:00
2026-11-05 19:27:19 +00:00
2026-11-08 01:46:06 +00:00
2026-11-06 21:58:23 +00:00
2026-11-06 02:08:16 +00:00
2026-11-05 19:27:19 +00:00
2026-11-04 23:46:23 +00:00
2026-11-06 18:07:57 +00:00
2026-11-05 22:23:20 +00:00
2026-11-03 18:22:59 +00:00
2026-11-04 23:53:55 +00:00
2026-11-07 11:44:50 +00:00
2026-11-05 19:27:19 +00:00
2026-11-05 22:23:20 +00:00
2026-11-07 06:01:30 +00:00
2026-11-06 23:37:33 +00:00
2026-11-04 23:53:55 +00:00
2026-11-06 02:08:16 +00:00
2026-11-07 05:51:12 +00:00
2026-11-06 13:40:49 +00:00
2026-10-17 00:41:41 +00:00
2026-10-16 22:00:32 +00:00
2026-10-31 11:15:23 +00:00
2026-11-02 14:39:24 +00:00
2026-11-02 11:36:03 +00:00
2026-11-06 15:42:00 +00:00
2026-11-07 09:53:38 +00:00
2026-11-07 15:44:35 +00:00
2026-10-31 01:09:31 +00:00
2026-11-06 18:14:51 +00:00
2026-11-06 18:14:51 +00:00
2026-11-06 08:47:50 +00:00
2026-11-04 02:59:50 +00:00
2026-11-07 22:27:38 +00:00
2026-11-01 20:45:39 +00:00
2026-11-06 13:52:51 +00:00
2026-11-04 23:50:18 +00:00
2026-11-06 13:52:51 +00:00
2026-11-03 01:40:07 +00:00
2026-11-05 04:16:06 +00:00
2026-11-07 09:53:38 +00:00
2026-11-06 04:33:54 +00:00
2026-11-04 23:46:23 +00:00
2026-11-03 18:22:59 +00:00
2026-11-03 14:06:33 +00:00
2026-11-07 18:02:40 +00:00
2026-11-07 06:39:20 +00:00
2026-11-07 05:51:12 +00:00
2026-10-25 03:56:50 +00:00
2026-11-08 00:59:38 +00:00
2026-11-04 23:35:57 +00:00
2026-11-08 00:59:38 +00:00
2026-11-07 05:51:12 +00:00
2026-11-03 18:44:36 +00:00
2026-10-27 02:48:59 +00:00
2026-11-02 03:23:35 +00:00
2026-10-27 02:48:59 +00:00
2026-11-08 00:59:38 +00:00
2026-10-30 19:23:01 +00:00
2026-10-31 21:46:33 +00:00
2026-11-08 00:59:38 +00:00
2026-11-07 09:53:38 +00:00
2026-11-07 09:53:38 +00:00
2026-11-05 08:42:30 +00:00
2026-10-31 21:46:33 +00:00
2026-11-02 16:32:10 +00:00
2026-11-07 05:51:12 +00:00
2026-11-07 05:51:12 +00:00
2026-11-08 00:59:38 +00:00
2026-11-07 09:53:38 +00:00
2026-11-07 06:39:20 +00:00
2026-11-06 15:04:30 +00:00
2026-11-06 10:16:00 +00:00
2026-11-08 03:23:53 +00:00
2026-11-06 07:02:54 +00:00
2026-11-08 00:59:38 +00:00
2026-11-06 13:52:51 +00:00
2026-11-03 17:08:30 +00:00
2026-11-06 15:42:00 +00:00
2026-11-07 18:43:11 +00:00
2026-11-07 06:52:04 +00:00
2026-10-29 13:28:08 +00:00
2026-10-13 15:17:39 +00:00
2026-10-11 00:32:15 +00:00
2026-10-17 02:40:45 +00:00
2026-11-06 17:13:48 +00:00
2026-11-04 01:28:17 +00:00
2026-10-17 03:32:16 +00:00
2026-10-03 18:49:34 -07:00
2026-11-01 06:11:17 +00:00
2026-11-06 10:16:00 +00:00
2026-10-03 18:49:34 -07:00
2026-11-05 08:42:30 +00:00
2026-11-04 03:38:56 +00:00
2026-10-04 07:58:41 -07:00