Faster string building, do not change value if not different. Fixes #390

2026-05-20 23:44:47 +02:00 · 2013-01-12 01:12:19 -05:00
parent 11db79d37b
commit 165aa9d488
1 changed files with 8 additions and 4 deletions
@@ -12,16 +12,20 @@ iD.svg.TagClasses = function() {

            classes = value.trim().split(/\s+/).filter(function(name) {
                return name.length && !tagClassRe.test(name);
-            });
+            }).join(' ');

            var tags = d.tags;
            for (var k in tags) {
                if (!keys[k]) continue;
-                classes.push('tag-' + k);
-                classes.push('tag-' + k + '-' + tags[k]);
+                classes += ' tag-' + k + ' ' +
+                    'tag-' + k + '-' + tags[k];
            }

-            return d3.select(this).attr('class', classes.join(' '));
+            classes = classes.trim();
+
+            if (classes !== value) {
+                d3.select(this).attr('class', classes);
+            }
        });
    };
 };