CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 09:42:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't skip other validations even if there are missing tag issues

Browse Source
This commit is contained in:
Quincy Morgan
2019-05-02 11:51:01 -07:00
parent b4dacdad2a
commit 424f6ca72d
1 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
modules/core/validator.js
View File

@@ -240,6 +240,8 @@ export function coreValidator(context) {
return !detected.length;
}
// run some validations manually to control the order and to skip some
runValidation('missing_role');
if (entity.type === 'relation') {
@@ -249,26 +251,22 @@ export function coreValidator(context) {
}
}
// other _rules require feature to be tagged
if (!runValidation('missing_tag')) return entityIssues;
runValidation('missing_tag');
// run outdated_tags early
runValidation('outdated_tags');
if (entity.type === 'way') {
runValidation('crossing_ways');
runValidation('almost_junction');
runValidation('crossing_ways');
runValidation('almost_junction');
// only check impossible_oneway if no disconnected_way issues
if (runValidation('disconnected_way')) {
runValidation('impossible_oneway');
} else {
ran.impossible_oneway = true;
}
runValidation('tag_suggests_area');
// only check impossible_oneway if no disconnected_way issues
if (runValidation('disconnected_way')) {
runValidation('impossible_oneway');
} else {
ran.impossible_oneway = true;
}
runValidation('tag_suggests_area');
// run all rules not yet run
Object.keys(_rules).forEach(runValidation);