54 Commits

Author SHA1 Message Date
Martin Raifer
97442403cf drop validator which checks for old style multipolygons
these have long been [fixed](https://blog.jochentopf.com/2017-08-28-polygon-fixing-effort-concluded.html) in OSM

see wiki: https://wiki.openstreetmap.org/wiki/Old_style_multipolygons
2024-02-29 13:28:22 +01:00
Quincy Morgan
e391edcc5c Namespace various internal SVG ids under ideditor (re: #7445) 2020-03-22 14:39:40 -07:00
Quincy Morgan
18a2c6c320 Fix issue where false edited segment indicators could appear 2019-10-10 18:28:43 +02:00
Quincy Morgan
c7186e2ee6 Replace usage of lodash isEqual (re: #6843) 2019-10-08 20:42:58 +02:00
Quincy Morgan
7d31c76546 Unify visual diff styles for lines and areas (re: #6843)
Render tag-only diffs in yellow instead of translucent orange
Don't use target colors for vertex diff styling
2019-10-08 20:25:09 +02:00
Quincy Morgan
909079e454 Replace uses of lodash omit (re: #6843)
Fix lint warnings
2019-10-07 11:43:40 +02:00
Quincy Morgan
c031f2dd33 Merge branch '2.15' into 215_highlight_edits
# Conflicts:
#	modules/svg/areas.js
2019-10-07 10:49:52 +02:00
Quincy Morgan
2ccdc438f4 Render area fill patterns in preset icons (close #6900) 2019-09-30 12:27:33 +02:00
Benjamin Clark
ad5025de3e Add support for area diffs. 2019-09-11 14:14:06 -04:00
Quincy Morgan
fa0c05f8f7 Don't render deprecated basin and reservoir features the same as their modern counterparts 2019-05-16 12:35:19 -04:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
d5abe468b9 Remove rest of the lodash iterators: map, reduce, forEach
(re: #6087)
2019-03-29 15:14:21 -04:00
Bryan Housel
11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values
(re: #6087)
2019-03-22 17:14:41 -04:00
Quincy Morgan
9785021f44 Rename simpleMultipolygon functions to oldMultipolygon
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
RudyTheDev
743be30a76 Use water fill pattern for fountain area 2018-12-15 16:33:06 +02:00
RudyTheDev
89a128f14c Allow directly specified fill pattern for entire tag (not using for anything as of yet) 2018-12-15 15:58:39 +02:00
RudyTheDev
b92592b6b4 Add fill pattern for reservoir 2018-12-15 15:32:48 +02:00
Bryan Housel
e5aa8a7058 Simplify setPattern 2018-12-14 12:57:28 -05:00
RudyTheDev
34cdb129c6 Add grass surface rendering for traffic calming areas 2018-12-10 17:41:53 +02:00
RudyTheDev
ff8723e194 Add water waves fill pattern and pond-specific pattern 2018-11-18 22:12:40 +02:00
RudyTheDev
b18dfb4030 Add landfill fill pattern, farmyard pattern (and remove farm pattern), implement vineyard fill pattern 2018-11-18 21:39:09 +02:00
RudyTheDev
46f762c0a6 Add quarry fill pattern 2018-11-18 20:52:33 +02:00
RudyTheDev
f41bb055f2 Add fill patterns for cemetery most common religions 2018-11-18 20:41:58 +02:00
RudyTheDev
3e2eaa6635 Allow fill pattern definitions to have short-hand syntax when there's only one pattern "rule" 2018-11-16 13:34:23 +02:00
RudyTheDev
1e51d5ff23 Add new wetland fill patterns; clean up pattern selection code 2018-11-16 12:51:31 +02:00
RudyTheDev
99ace5c791 Expand fill pattern definitions with optional tag-value pair requirement; add forest/wood broadleaved, needleleaved and leafless patterns using the new rules 2018-11-16 02:22:18 +02:00
RudyTheDev
1f6828a24f Further change fill pattern definitions to allow iterating over "rules" 2018-11-16 01:37:58 +02:00
RudyTheDev
b22dfb7ebb Change the fill pattern definition to have strict tag-value pairs 2018-11-16 00:14:54 +02:00
RudyTheDev
473cd60986 Add a new pattern "forest" for forest/wood; use dots for grass; use bushes (wetlands) for scrub 2018-11-15 16:40:40 +02:00
Bryan Housel
3bc841e95b Adjust layer ordering to draw touch targets above data layers 2018-11-09 21:48:45 -05:00
Bryan Housel
7714e88f3d Support data area filling (full/partial/wireframe), shadow strokes 2018-08-24 14:07:00 -04:00
Bryan Housel
cc79e2170b Only draw targets for lines and areas that have a valid path
Before, it was drawing svg path elements for all the segments,
even those that were clipped out of view (getPath returns null).
This was putting a lot of junk into the DOM.
2018-03-01 22:49:56 -05:00
Bryan Housel
6881205d43 All touch targets are GeoJSON now
This makes the code a bit more consistent and lets us avoid some
hacky and probably non-performant things:
- abusing CSS classes in the draw/drag datum functions (classed `.target`)
  (is this thing target? just check d.properties)
- regexing the id for `-nope$`
  (is this thing a nope target? just check d.properties)
- using context.hasEntity to get a the real entity
  (is this thing a real osmEntity? just check d.properties)
- fixes code like the restriction editor which uses fake ids for split ways
2018-01-01 22:37:10 -05:00
Bryan Housel
7851c49e80 Fix nopefilters by testing the original id for the filter 2017-12-22 00:26:39 -05:00
Bryan Housel
6d7659b3bb Refactor common helper code to svg/helpers.js, add area nopes 2017-12-21 10:36:02 -05:00
Bryan Housel
7994baae23 WIP: trying singular activeID and smarter target drawing code
The goal here is that the code that draws the targets should know better
what parts of the lines/vertices are targetable, rather than just
relying on CSS to ignore the pointer events on the whole line.

e.g. when drawing a line, it's ok for it to loop back and connect
to itself, just not on a segment or vertex adjacent to the active
node.
2017-12-19 11:23:35 -05:00
Bryan Housel
7a8f50c74e More fixes for drawing/snapping, don't draw touch targets for activeIDs 2017-12-18 22:54:49 -05:00
Bryan Housel
aa68b21d7a Add touch targets for line/area 2017-12-17 22:53:58 -05:00
Bryan Housel
9edae82673 Convert lodah-es and d3 to named imports for svg 2017-09-25 23:16:24 -04:00
Bryan Housel
0c9fb7c407 Improve military presets
(closes #3663)

* Add Nuclear Explosion Site and Military Office presets
* Add Bunker Type field
* Improve styling rules for preset icons
* Improve search terms for all military presets
* Nest military presets under `landuse=military`
* Add ref, iata, icao fields to Military Airfield
* Don't set area pattern fills on buildings
2016-12-27 01:19:13 -05:00
Bryan Housel
0e2cd589d4 Add styling for natural=bare_rock, natural=sand 2016-12-26 16:00:02 -05:00
Bryan Housel
fbe9cf3afd Clip polygons and clippaths to padded viewport
(closes #3529)
2016-10-29 21:50:30 -04:00
Bryan Housel
f50e80d0b5 Refactor Intersection, Multipolygon from geo to osm 2016-10-11 23:09:27 -04:00
Bryan Housel
07fa5fcc34 Refactor Entity, Node, Relation, Tags, Way from core to osm 2016-10-11 22:41:24 -04:00
Bryan Housel
3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel
afb88f2ae6 Fix rendering selections for all the OSM layers
This includes some renames for clarity.. "surface" -> "selection"
to make it clearer that rendering functions take a selection, and
don't necessarily render to the literal `#surface` node anymore.
2016-09-08 22:37:06 -04:00
Tom MacWright
0931da1591 Fix areas 2016-09-06 17:28:20 -04:00
Tom MacWright
20962074ba Fix vertices areas midlines 2016-09-06 10:58:07 -04:00
Tom MacWright
4fcbcddc5b Fix eslint 2016-09-06 10:18:05 -04:00
Tom MacWright
aebf0c14e1 Fix area redrawing 2016-09-03 18:42:17 -04:00