2444 Commits

Author SHA1 Message Date
Quincy Morgan
5d6a9c278c Update validation rules section upon revalidation 2020-02-24 12:14:05 -08:00
Quincy Morgan
6782947f5b Make inspector sections inherit from uiSection (re: #7368) 2020-02-21 15:22:54 -08:00
Bryan Housel
b12c30461b Don't bundle the locales anymore, load first in context init
(re: #4994)
2020-02-21 12:24:08 -05:00
Bryan Housel
e8f4452d49 Don't bundle the en.json strings anymore, Promisify locale loading
(re: #4994)
2020-02-21 11:09:59 -05:00
Bryan Housel
61c86a3527 Don't rely on the dataEn export for checking if a string exists
Instead use the special `default` key for supplying a fallback string
2020-02-20 17:11:47 -05:00
Quincy Morgan
1f4fe57d8b Use d3-style API for section contents 2020-02-20 13:47:11 -08:00
Quincy Morgan
4fe9057eb7 Move remaining issues pane sections to their own objects 2020-02-20 13:02:09 -08:00
Bryan Housel
3ccf0e6ccb Preload intro graph data while the user is viewing the splash screen 2020-02-20 08:52:05 -05:00
Quincy Morgan
e42bc34e4b Move validation warnings and errors to their own section objects
Allow function parameters for disclosure titles
2020-02-19 17:28:51 -08:00
Quincy Morgan
68c2b9f1a8 Move the data layers section to its own object (re: #7368) 2020-02-19 14:31:32 -08:00
Quincy Morgan
ff4ac253da Make photo overlays its own section object (re: #7368) 2020-02-19 12:08:13 -08:00
Quincy Morgan
c6129a0493 Remove unused autohidden errors code path 2020-02-19 11:28:11 -08:00
Quincy Morgan
b921ca3cb4 Move map features and map style options to their own pane section objects (re: #7368)
Handle area fill and change highlighting logic in the rendererMap object and issue change events
2020-02-19 11:23:02 -08:00
Quincy Morgan
5c04ad3eb5 Add uiSection class as standard component for pane sections
Move validation rules and privacy preferences to their own section objects
2020-02-18 20:02:55 -08:00
Quincy Morgan
d8a0f030cc Add "pane" prefix to pane UI objects
Move background and overlay layer lists to their own files
2020-02-18 13:33:12 -08:00
Quincy Morgan
5c150718a3 Make all panes inherit from a standard uiPane class (re: #7368) 2020-02-18 10:40:27 -08:00
SilentSpike
753ae3bdd2 Use marked for Osmose strings markdown
- More reliable method of handling markdown
- Change external links in the strings within the details code
2020-02-16 22:38:34 +00:00
SilentSpike
18287284c6 Remove translations link from Osmose UI
- Not useful to majority of users and clutters the UI
- Anyone interested in translation will already be looking at the iD
project and we can direct them from there
2020-02-16 12:47:38 +00:00
SilentSpike
1e544f64fb Add rel=noopener to external QA links 2020-02-15 12:39:23 +00:00
SilentSpike
af0e37f7c5 Add "view on osmose" link to UI footer 2020-02-15 11:48:01 +00:00
SilentSpike
d200d0fce2 Use Promise for improveOSM comments 2020-02-14 17:31:10 +00:00
Quincy Morgan
05925b15f2 Use standard hover-highlighting mechanism in feature search results list 2020-02-13 10:20:32 -08:00
Quincy Morgan
614ee3f68e Use standard hover-highlighting mechanism for feature links in Q/A inspectors 2020-02-13 10:07:18 -08:00
Quincy Morgan
32d773caa7 Standardize some Q/A CSS 2020-02-12 16:00:29 -08:00
Quincy Morgan
5674f75a11 Make the icons larger and centered on ImproveOSM and Osmose issue markers 2020-02-12 14:52:49 -08:00
SilentSpike
9364b1d637 Fix missing semi-colon 2020-02-12 21:27:37 +00:00
Quincy Morgan
c82c57f8cb Update feature names in the selection list while typing in the name field (close #7334) 2020-02-11 15:21:28 -08:00
Bryan Housel
3608659d21 Restore field inheritance 2020-02-10 16:22:13 -05:00
SilentSpike
7d76e0ac5c Fix Osmose request resolving after UI moves on
- Previously caused minor unexpected renderer behaviour by forcing elements
visible when the user had moved on (potentially interfering with
whatever they're currently doing)
2020-02-07 10:43:44 +00:00
SilentSpike
51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
Quincy Morgan
0e14241fcf Move some upload code from modeSave to new coreUploader object (re: #7247) 2020-02-05 15:28:23 -05:00
SilentSpike
03a097c847 Move Osmose translation link below details box 2020-02-04 21:44:20 +00:00
SilentSpike
3745c06d62 Hide Osmose issue description if no string 2020-02-04 21:22:44 +00:00
SilentSpike
087867d5c8 Use Promises for Osmose issue detail requests
Also ES6ify the details script
2020-02-04 21:08:02 +00:00
SilentSpike
377e99240f Add Osmose translations link to details footer
Improves structure of the details UI and introduces the use of flexboxes
for this. Does not break UI for other error services with shared classes.
2020-02-03 23:20:45 +00:00
SilentSpike
1dd65cb93e Correct Osmose UI element spacing 2020-02-03 23:20:45 +00:00
SilentSpike
ecadafb3e4 Use Osmose supplied hex colors 2020-02-03 23:20:45 +00:00
SilentSpike
06ac02f89f Use Osmose dynamic subtitile string
Providing a `langs` param that's currently not implemented so these will
all be English until that is done.
2020-02-03 23:20:45 +00:00
SilentSpike
e3c6f58624 Format markdown in Osmose strings appropriately 2020-02-03 23:20:44 +00:00
SilentSpike
010ca30999 Show more Osmose strings in the UI
Also only add sections where appropriate
2020-02-03 23:20:44 +00:00
SilentSpike
7a00c0a974 Use Osmose locale filter and detail strings 2020-02-03 23:20:44 +00:00
SilentSpike
5d93d3cace Prepare to use Osmose issue detail strings
- Remove translation description strings, will be using supplied
translations once the API is updated
- Change the way elements and details are presented since they can't be
easily integrated into the 3rd party description strings
2020-02-03 23:20:44 +00:00
SilentSpike
7d76950d55 Use Osmose translation strings for issue titles
This is just step one in the process while we wait for the API to supply
further strings and filtering to reduce the amount of string data
requested (since we don't need it all).

Strings are requested when the layer is first enabled and cached for the
current language (plus English as a backup).
2020-02-03 23:20:43 +00:00
SilentSpike
d2f9278fe2 Port changeset tag improvement to ImproveOSM QA
Also marked the `closed:` tags as readonly since these are filled in
automatically.

- Gives a count of each error type closed instead of making a list of
joined coordinates which quickly fills the maximum value length.
- This is more useful since a changeset already gives the area worked
on while these counts give insight into the type of changes made.
- Similar to iD own validation tags
2020-02-03 23:20:43 +00:00
SilentSpike
406264c37e Simplify structure of QA error data 2020-02-03 23:20:42 +00:00
SilentSpike
12206c68e6 Convert Osmsoe service to ES6 syntax 2020-02-03 23:20:41 +00:00
SilentSpike
a068cdfc59 Tag changeset with Osmose issue closed counts
This seems more useful than tagging with a list of joined coordinates
which quickly becomes truncated due to tag value length.

Adds a tag per issue type similar to iDs own validation.
2020-02-03 23:20:41 +00:00
SilentSpike
b24b041335 Add Osmose issue detail fetching for UI
Must fetch details per-issue to get the associated OSM elements for
highlighting and use in the error description.

Also fixes URL for error closure.
2020-02-03 23:01:03 +00:00
SilentSpike
ebd206595a Use Osmose tiles API endpoint instead of issues
- Simplifies our code a little bit
- Quick to provide and gives us the `item` + `class` without requesting
all other information (the two things needed to know the error type)
- Removed handling of associated elements for now, need to implement
fetching for that data on a per-issue basis when the UI loads
- Set things up for the possibility of using the provided translation
strings (need to determine if desirable)

See: https://github.com/osm-fr/osmose-frontend/issues/193
2020-02-03 23:01:03 +00:00
SilentSpike
680fdb6b54 Allow Osmose errors to use category for UI strings
Some error types don't require unique strings and can share common
strings among the category. This makes that possible as well as adding
support for some other types of error for demonstrative purposes.
2020-02-03 23:01:02 +00:00