2444 Commits

Author SHA1 Message Date
SilentSpike
d9ba63aa3f Fix leftover errors and unused definitions 2020-02-03 23:01:02 +00:00
SilentSpike
947f9657db Port minor QoL tweaks to other QA services
Use of MouseEnter and MouseLeave is nicer for SVGs since it won't fire
multiple times (shouldn't happen hear anyway as only one element).

Triggering redraw after forcing related elements visible causes them to
render without having to pan manually.
2020-02-03 23:01:01 +00:00
SilentSpike
09e7b23665 Add Osmose issues UI and filtering
Filters out errors not present in the data .json file to enable
selective support since Osmose has a wide variety of errors which may be
too advanced for iD.

Also added processing for the elements associated with an error for
forced visibility and highlighting.
2020-02-03 23:01:01 +00:00
SilentSpike
e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Quincy Morgan
13d8c078b4 Fix weak preset check 2020-02-03 13:58:34 -05:00
Bryan Housel
4aa4686e7f Fix test failures in localized and suspicious_names 2020-02-03 12:38:17 -05:00
Quincy Morgan
b4bc5305a1 Enable the issues section for multiple selected features (close #7324) 2020-02-03 12:17:14 -05:00
Quincy Morgan
e7c3ba0fd7 Show the same fields for the same features in multiselection regardless of what order they were selected in 2020-02-03 11:13:29 -05:00
Quincy Morgan
1c7a150854 Fix issue with fields in commit UI 2020-01-31 14:26:33 -05:00
Quincy Morgan
2783408fc3 Add tooltips to mixed values in semicombo, multicombo, and radio fields 2020-01-31 14:07:16 -05:00
Quincy Morgan
af928e3dc1 Support radio fields during multiselections 2020-01-31 13:02:30 -05:00
Quincy Morgan
8d9adbd902 Lock the name field if any of the selected features should be locked (re: #7306) 2020-01-31 11:23:42 -05:00
Quincy Morgan
b3262a71dc Use newlines instead of semicolons to separate mutliselection tag values in tooltips (re: #7306) 2020-01-31 10:49:31 -05:00
Quincy Morgan
512d8974a6 Merge branch '2.x' into multiselection-field-editing 2020-01-30 17:20:04 -05:00
Bryan Housel
6e5cb45c17 Don't bundle the imagery anymore, fetch from dist/data at runtime
(re: #4994)
2020-01-30 17:10:41 -05:00
Quincy Morgan
15e9599ff7 Support editing the Name and Multilingual Name fields during multiselection 2020-01-30 17:09:19 -05:00
Quincy Morgan
1b331bb678 Add mechanism for fields to support editing during multiselection (re: #7276)
Add `utilCombinedTags` method and use it for the raw tag editor as well as fields
Pass `entityIDs` array into fields instead of single `entity` object
Give field revertion its own path separate from `change`
Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
2020-01-30 13:53:29 -05:00
Bryan Housel
33a2dafc10 Fetch wmf-sitematrix from CDN.. No need to depend on it anymore. 2020-01-30 09:48:37 -05:00
Bryan Housel
fb4d658860 Don't bundle the community index anymore, fetch from CDN instead
Start fetching and preparing it just before the changeset gets sent
2020-01-29 15:24:26 -05:00
Bryan Housel
c481f90e7d Stop bundling wmf-sitematrix, move it extern
This also includes a bunch of tweaks to make the tests work
in both PhantomJS and modern browsers like Chrome.

Basically - introduce some more async into the test code so that
the coreData.get promise is guaranteed to settle.  Because in
PhantomJS the promise is polyfilled, and Chrome it's native, they
work slightly differently.
2020-01-29 12:30:11 -05:00
Bryan Housel
567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Quincy Morgan
89ce98f510 Don't require services/osm in order to get max OSM character lengths 2020-01-28 09:28:23 -05:00
Bryan Housel
d69cf532e0 Merge branch 'dataloader' into 2.x 2020-01-27 17:17:46 -05:00
Bryan Housel
31e007fc83 Create a data loader and move the intro graph into dist/data
(re: #3403)
2020-01-27 17:15:00 -05:00
Quincy Morgan
6dc02d7f22 Properly hide the input field on semicombos when there aren't enough characters remaining to add another value (re: #6817) 2020-01-27 16:35:15 -05:00
Quincy Morgan
17ae12b3d7 Address most common places where tag keys or values could exceed the 255 character API limit (close #6817) 2020-01-27 15:57:55 -05:00
Bryan Housel
2a2668b01b Can't use ES6 fat-arrow functions with arguments
see buble bug https://github.com/bublejs/buble/issues/208
2020-01-24 17:22:03 -05:00
Quincy Morgan
7c5cbb121f Fix "Add field" label 2020-01-24 10:59:10 -05:00
Quincy Morgan
3dc0361dc8 Add improved "zoom to" icon 2020-01-22 12:43:24 -05:00
Quincy Morgan
c477950556 Re-add "zoom to this" button 2020-01-22 10:44:40 -05:00
Quincy Morgan
fd2b97331c Add label to "change feature type" button in inspector and make it a collapsible section (close #6811) 2020-01-22 09:19:54 -05:00
Quincy Morgan
6bb2997306 Enable changing the preset of multiple selected features (re: #7276)
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Quincy Morgan
a364c52f47 Make "Multiple Values" placeholder italic 2020-01-20 13:55:38 -05:00
Quincy Morgan
14dba080b0 Fix inspector keytrap behavior 2020-01-20 13:55:06 -05:00
Quincy Morgan
d4dd92bc78 Don't append new line to raw tag text if the text is empty 2020-01-20 13:00:44 -05:00
Quincy Morgan
667406c6e0 Remove "all" from the inspector section names 2020-01-20 11:51:00 -05:00
Quincy Morgan
48bda8ba67 Move selected feature list to a collapsible inspector section (close #7273) 2020-01-20 11:34:51 -05:00
Quincy Morgan
bb593c5ccc Add "deselect" tooltip to X buttons in selected features list 2020-01-20 10:22:49 -05:00
Quincy Morgan
232375cfc0 Fix sidebar state issues with adding and removing features from multiselection 2020-01-18 14:30:14 -05:00
Quincy Morgan
be8ccf01c4 Fix issue with showing the preset list programmatically 2020-01-18 13:56:59 -05:00
Quincy Morgan
8ca40ac056 Support the raw tag text editor during multiselection 2020-01-18 13:38:21 -05:00
Quincy Morgan
6f2938b35e Add "key=value" placeholder to text tag editor textarea 2020-01-18 13:36:36 -05:00
Quincy Morgan
874acf8ccc Make raw tag editor display option tooltips translatable 2020-01-18 13:35:31 -05:00
Quincy Morgan
721ee0e95f Prevent unnecessary reloading of raw tag editor (close #7248) 2020-01-18 12:30:35 -05:00
Quincy Morgan
eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Quincy Morgan
9376fa1870 Merge branch '2.x' of https://github.com/openstreetmap/iD into 2.x 2020-01-16 11:03:19 -05:00
Quincy Morgan
145d6aef4f Add class to operation button icons 2020-01-16 10:58:04 -05:00
Bryan Housel
a45b4133c5 indent 2020-01-16 10:37:24 -05:00
Quincy Morgan
2495aa8041 Add additional safety check to uiAccount 2020-01-16 10:34:47 -05:00
Bryan Housel
1c998d186a Correctly gather the community index resources
- old code assumed that each resource had a link back to a single geojson featureId
- this isn't the case anymore so we need to link them in data/index.js
2020-01-16 10:06:35 -05:00