5051 Commits

Author SHA1 Message Date
Bryan Housel d3058983c3 Merge pull request #8768 from openstreetmap/matchTags_improveIndex
matchTags - improve indexing data structure
2021-10-25 10:42:44 -04:00
Milos Brzakovic (E-Search) 18f7e91b50 matchTags - improve indexing data structure 2021-10-25 12:10:20 +02:00
John Firebaugh 053b652548 More typos 2021-10-24 11:06:26 -07:00
John Firebaugh 3e082bb20e Fix typos 2021-10-24 11:01:44 -07:00
Milos Brzakovic 869eebf510 Merge branch 'develop' into local-storage-full 2021-10-21 16:50:50 +02:00
Milos Brzakovic (E-Search) dee8cdfe07 matchTags- don't do locationsAt if locID is +Q2 2021-10-21 11:03:44 +02:00
Milos Brzakovic (E-Search) 599d2df19b matchTags - don't calculcate valid locations unless needed
mismatched_geometry - small optimization
2021-10-20 09:49:00 +02:00
John Firebaugh d5edd6f6c1 Merge pull request #8753 from openstreetmap/1ec5-follow-errors-8671
Copyedit error messages for Follow operation
2021-10-17 14:56:04 -07:00
John Firebaugh 19c9524870 Merge pull request #8741 from Georeactor/rtl-unfix
Turn off RTL text patch on Chromium >=96
2021-10-17 14:53:51 -07:00
Minh Nguyễn 3e42e6adfa Copyedited error messages for Follow operation 2021-10-14 15:29:47 -07:00
Milos Brzakovic 76990349bd Merge pull request #8708 from k-yle/keep-oldest-feature-in-merge
keep the oldest Way when merging
2021-10-13 12:10:29 +02:00
Nick Doiron 2d97f8414d turn off svg text path patch on Chromium >=96 2021-10-08 00:36:18 -04:00
Kyle Hensel c9faf072e6 create 'follow' feature for drawing ways 2021-10-05 13:42:42 +13:00
Kyle Hensel 3f12dd5107 keep the oldest Way when merging 2021-10-01 10:31:21 +13:00
Milos Brzakovic a018d276eb Merge pull request #8701 from openstreetmap/check_china_source
Add warning for some commercial mapservice in China
2021-09-30 12:06:36 +02:00
Kyle Hensel d08c09f5ee show an error if local storage is full 2021-09-30 19:41:15 +13:00
Milos Brzakovic 021107cb81 Merge pull request #8642 from openstreetmap/testing_data
Test improvements
2021-09-28 11:08:31 +02:00
Milos Brzakovic a00a9162e7 Merge branch 'develop' into tag_as_not 2021-09-27 19:03:46 +02:00
Bryan Housel 73f8737d17 Adjust the regex for matching Chinese map providers 2021-09-17 12:54:49 -04:00
Bryan Housel defc87e455 Add warning for some commercial mapservice in China
(closes #8700)
2021-09-17 11:36:48 -04:00
Milos Brzakovic bc75430528 Merge pull request #8288 from jleedev/preset-debounce
Debounce input events in the preset list.
2021-09-15 11:49:40 +02:00
Milos Brzakovic e495c99102 Merge pull request #8685 from openstreetmap/mapControl-scroll
MapControl scroll
2021-09-14 11:35:42 +02:00
Milos Brzakovic f08b89f4c3 Merge pull request #8663 from openstreetmap/issue_key_8655
More validator fixes
2021-09-14 11:34:58 +02:00
Milos Brzakovic 7e31120ec6 added scrol to mapControl 2021-09-10 15:26:37 +02:00
John Firebaugh 1457759994 Add support for connectivity relations 2021-09-08 20:30:38 -07:00
John Firebaugh a14cf49710 Disable merge operation when it would damage relations
The operation is disabled when attempting to join ways which don't belong to identical sets of relations. Restriction relations are excluded, because they are already handled with slightly different logic.

Fixes #8674
Fixes #8645
Fixes #3825
Fixes #1512
2021-09-04 15:42:07 -07:00
Bryan Housel 78961072a7 We do need to actually validate the head entities, can't skip them
re: the fix for #8632 - we can't actually skip validation on these.
The better solution is to move the check to getIssues() so the user isn't
credited for causing the issues unless it's something they actually touched
2021-08-27 17:43:49 -04:00
Bryan Housel 113f079449 Uncache the entity before starting the work
This fixes a situation where several entities in the queue are involved in a
disconnected crossing, and the first one detects the disconnection, but a
later one clears out that first detection from the cache.  Now we clear
caches one time before starting the validation work.
2021-08-27 17:24:45 -04:00
Bryan Housel b94151396d Expand set of entities to validate to include _related_ to issues
This will catch the situation where an edit or undo affects something related without
actually touching the item - for example an undo can cause a connected way to disconnect
from the main graph.
2021-08-27 17:20:32 -04:00
Bryan Housel 1b5bd4d9c3 Actions performed (e.g. adding midpoint) must trigger validation
(re: #8655)
2021-08-27 17:14:06 -04:00
Bryan Housel 9e3df2c4aa Create an issue key property that changes when data needs refresh
(closes #8655)
2021-08-27 17:13:36 -04:00
Kyle Hensel 416c1af372 add link button next to website tag 2021-08-19 15:17:45 +12:00
Milos Brzakovic (E-Search) 81b7e282c3 Set development version number 2021-08-17 17:14:48 +02:00
Milos Brzakovic (E-Search) fc5d790b0e v2.20.1 2021-08-17 16:52:28 +02:00
Milos Brzakovic 8eb2de93be Merge pull request #8637 from openstreetmap/validation_8632_etc
More validator fixes
2021-08-16 23:44:43 +02:00
Bryan Housel 1282d3b059 Don't use a util function for a thing that exists 1x in the code 2021-08-16 14:23:24 -04:00
Bryan Housel bb84962e5d Only insert sources into the fileMap if not already there
This allows us to setup the fileMap correctly for testing so
that it never tries to fetch assets from the CDN.
2021-08-16 13:28:55 -04:00
Bryan Housel a962c6f96c Can't redraw while transformed 2021-08-13 17:36:45 -04:00
Bryan Housel 1f172d5623 Make the crossing_ways hash less strict
Previously it was including a lot of data about the edge, and a very specific
crossing location.  This meant that any tiny perturbation in the crossing ways
would generate a new issue hash, effectively "fixing" the old crossing issue and
creating a new one.
2021-08-13 16:24:29 -04:00
Bryan Housel 34c3ea472d Credit user with a fix if they touched any involved entity
This can occur if there are several ways disconnected from the graph and
the user fixes these, but then partially undoes their fixes.

The current diff might not contain the entity that fixed the issue
(reconnected the disconnected graph), but they did fix the issue elsewhere.
2021-08-13 15:56:08 -04:00
Bryan Housel 93b868d95f Fix how resolved issues are counted across undo, simplify code
(re: #8632)
2021-08-13 14:47:38 -04:00
Bryan Housel b5d7cdb6fa Use utilHashcode to generate reasonable ids for crossing_ways issues
The ones before were a giant blob of json
2021-08-13 12:56:50 -04:00
Bryan Housel f58ddb21fb Remove old entityIDsToValidate() code 2021-08-13 12:32:13 -04:00
Bryan Housel bb0b5786d9 Use context.graph()/context.hasEntity() here, not cache.graph,
because that is the graph that the calling code will be using.
2021-08-13 12:02:38 -04:00
Bryan Housel 2434e5edaa In the head cache, only validate features that the user is responsible for
(closes #8632)

For example, a user can undo some work and an issue will still present in the
head graph, but we don't want to credit the user for causing that issue.
2021-08-13 11:25:36 -04:00
Milos Brzakovic 1fb42bc852 Merge pull request #8636 from openstreetmap/togeojson_package_switch
Switch to more maintained @tmcw/togeojson
2021-08-13 17:13:45 +02:00
Bryan Housel 3e8d33a668 Use coreDifference.complete() instead of entityIDsToValidate()
From what I can tell, this code is nearly the same as what the "complete"
difference already gives us - combined nodes from both previous and current,
multipolygon members, parents of nodes/relations
2021-08-13 10:53:57 -04:00
Milos Brzakovic 2270b5dd9c fixes mac os firefox scroll. closes #8595 2021-08-13 16:51:02 +02:00
Bryan Housel 96c5dd1c7c Store graph with validation cache, give them names, es6 some things 2021-08-12 11:37:57 -04:00
Milos Brzakovic 25e2050bcb switched to more maintained @tmcw/togeojson
Solves few security issues
2021-08-12 13:38:56 +02:00