1328054b08
Allow for multiple invalid sources
2019-04-05 18:49:14 +01:00
78acd999c8
WIP: switch from validating everything to validating differences
2019-04-05 13:29:57 -04:00
17f2c5c0f4
Add Zip Line preset
2019-04-05 09:40:35 -07:00
af45dbce10
Trying to avoid one-off validations when history changes will trigger it
2019-04-05 11:37:02 -04:00
f17ebee402
Use Set, simplify util functions to collect entities with children
2019-04-05 11:05:04 -04:00
6508edf820
Avoid anonymous functions as validators
...
Givnig them names makes it easier to understand in the profiler
2019-04-05 09:50:22 -04:00
8b1c0551cc
WIP: understand state held by the validator, avoid translations
...
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
(graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
2019-04-05 09:28:36 -04:00
550a4df435
Prevent stale results when first searching presets
2019-04-04 18:24:05 -07:00
a054db6472
Fix issue where hover-highlighting wouldn't disappear upon removing a relation from a member or a member from a relation ( close #5612 )
2019-04-04 17:56:01 -07:00
35c7cbd92b
Ensure that undo/redo buttons look disabled when the map is not editable ( close #6105 )
2019-04-04 17:34:20 -07:00
65e04acb2f
Flag features that mention Google in the "source" tag ( close #6135 )
2019-04-04 08:32:03 -07:00
d5e427289f
Avoid delete/reinsert on the coreTree when not needed
...
(re: #6140 )
2019-04-04 10:02:15 -04:00
68ed6da159
Merge branch 'master' into validation_and_change_perf
2019-04-04 09:30:30 -04:00
87e3b928d0
Reduce drawing during history changes
...
(closes #6086 )
2019-04-03 23:26:26 -04:00
e71b139171
Simplify almost junction validation
2019-04-03 16:41:26 -07:00
6641f62685
Reduce duplicate code in almost junction validation
2019-04-03 15:44:45 -07:00
86de378de5
Add didChange object to track what kind of things changed in the diff
2019-04-03 17:43:04 -04:00
765d765477
Pick a fake loc value where equality tests actually work
2019-04-03 17:25:10 -04:00
cbae090f08
Fix crash in almost junction validation
2019-04-03 14:23:21 -07:00
167824a530
Make sure all nodes have an actual loc property
...
- This is to make difference comparisons easier
- The only nodes that didn't have a `loc` were fake nodes we made for testing
- So this commit also fixes the `osmIntersection` code and tests.
2019-04-03 16:20:45 -04:00
34792d7fbf
Don't add field defaults when upgrading tags to a specific replacement
2019-04-03 10:57:42 -07:00
d65298f383
Fix issue where generic vertex icon wouldn't show ( close #6138 )
2019-04-03 09:29:14 -07:00
561ffc402a
Remove annotatedChange events (we'll replace with something else)
2019-04-03 11:56:56 -04:00
bf391c997a
Fix issue where Points walkthrough could not be completed in some cases due to downgrade operation (re: #6103 )
2019-04-02 20:23:27 -07:00
8779e1a6dc
Add Downgrade operation to remove most tags from features but retain address and building tags instead of immediate deletion
2019-04-02 11:09:08 -04:00
d5a2ca131d
Fix issue with loading brand documentation ( close #6134 )
2019-04-02 07:21:30 -04:00
cf6e6c7970
Always display the wikidata label and description in the user's language, if available
2019-04-01 13:04:33 -04:00
d5d4323c02
Replace "Use different layers" non-actionable quick fix with actionable quick fixes for setting a higher or lower layer ( close #5943 )
2019-04-01 11:52:04 -04:00
2e7a47d0f2
Update the wikipedia tag when setting the wikidata tag via the field ( close #5543 )
2019-03-31 15:49:35 -04:00
b2831ffbd9
Don't export coreValidator here, as it's already exported by core *
2019-03-30 09:58:42 -04:00
05f0e9f76f
Remove lodash isMatch
...
(re: #6087 )
2019-03-30 09:36:24 -04:00
7c01e63efa
Remove unnecessary cloning from history walkthrough stuff
...
(re: #6087 )
2019-03-30 09:09:33 -04:00
cda8f657ac
Swap fast-deep-equal for lodash isEqual
...
(re: #6087 )
2019-03-29 22:17:29 -04:00
3673a7c7e7
Remove lodash cloneDeep
...
(re #6087 )
- some were able to do a different approach
(validations/almost_junction, and settings/*)
- some were replaced with custom speedy cloners
(in orthogonalize clonePoints and osm.js cloneNoteCache)
- some just replaced with JSON.parse(JSON.stringify()))
2019-03-29 17:18:40 -04:00
d5abe468b9
Remove rest of the lodash iterators: map, reduce, forEach
...
(re: #6087 )
2019-03-29 15:14:21 -04:00
0d79e3e616
Remove lodash cloneDeep and forOwn from context.js
...
(re: #6087 )
Tests in Phantom run twice as fast now!
2019-03-29 12:57:37 -04:00
ba6283af98
Fix point averaging code in improveOSM service
...
re: https://github.com/openstreetmap/iD/commit/4a8c20c56e4549da94555958acd34f649ca18fe9#r32961438
2019-03-29 09:06:27 -04:00
4a8c20c56e
Remove lodash forEach
...
(re: 6087)
2019-03-28 19:50:20 -04:00
5a0f8b3453
Autocomplete labels in the Wikidata field ( close #5544 )
2019-03-28 19:34:47 -04:00
3d4c5c6087
Display logos for name-suggestion-index brands in the sidebar ( close #5167 )
2019-03-28 14:20:46 -04:00
b12e7277df
Add countryCodes property to preset schema
...
Copy countryCodes from name suggestion index
Use countryCodes to filter the preset search results (close #6124 )
2019-03-28 11:44:05 -04:00
d18b951c67
Remove lodash flatten and flattenDeep
...
(re: #6087 )
2019-03-28 10:04:46 -04:00
f4367f96c0
Add ignored warning counts to the changeset tags ( close #6123 )
2019-03-28 09:46:59 -04:00
3896b2282f
Remove lodash isNaN, isNumber, isString, bind, uniqBy
...
(re: 6087)
2019-03-27 23:11:45 -04:00
6fb8fcb86b
Make map pan to the location of the undone edit when undoing instead of the location of the edit before that ( close #5831 )
2019-03-27 18:02:21 -04:00
53625a9364
Fix issues with the walkthrough
2019-03-27 17:41:15 -04:00
748c9c9598
Filter out deprecated tag values from combobox suggestions ( close #6084 )
2019-03-27 17:15:10 -04:00
3d80e6505f
Remove lodash chunk, groupBy
...
(re: #6087 )
2019-03-27 16:18:41 -04:00
4cc8d796a6
Prevent deleting features with Wikidata tags ( close #5853 )
2019-03-27 16:02:02 -04:00
56cf7542be
Fix error when trying to add a feature to a relation ( close #6095 )
2019-03-27 15:03:33 -04:00
J Guthrie