1779 Commits

Author SHA1 Message Date
Bryan Housel
d82d5dc3d0 Add skipID to geoChooseEdge, to ignore dragging node 2017-12-21 17:30:50 -05:00
Bryan Housel
fcacdb4400 Fix hover test (requires context.hasEntity stub) 2017-12-21 11:18:06 -05:00
Bryan Housel
2e2b037e36 Move a bunch of commonly used vector and projection math functions into geo
- geoVecAdd
- geoVecSubtract
- geoVecScale
- geoZoomToScale
- geoScaleToZoom
2017-12-18 15:05:42 -05:00
Bryan Housel
18c97d52c8 Extract viewport nudging code from several places to geoViewportEdge 2017-12-18 09:50:17 -05:00
Bryan Housel
6644c9db6b Fix context.js and vertices.js tests 2017-12-15 18:17:12 -05:00
Bryan Housel
89d8d37576 Drawing all the correct vertices now where I want them, simplify classes
Some highlights
- `getSiblingAndChildVertices` are expensive, so they're saved and called less frequently
- draw touch targets for all the visible vertices
- remove redundant css classes and `setClass` function
2017-12-15 17:28:20 -05:00
Bryan Housel
b9e48d1682 WIP: Move layer-hit to layer-points with explict sublayers, update tests
This is more work to further isolate the layers that entities draw to.
It makes it easier to debug what is going on, and can eventually lead to
deferred drawing, if each draw function is in its own place and not dependant
on anything else.

I've started to replace the vertex-hover with an explicit layer for touch
targets.

Also had to change a lot of the svg tests, which are really brittle.
Things would happen like - the surface would be created, it would kick of a
deferred redraw, which would notice that the zoom was 0 and call
editOff, which would remove the osm layers that were just created and
that the tests were trying to draw to. These tests need proper zoom and
projection otherwise nothing works.
2017-12-14 17:38:43 -05:00
Bryan Housel
bfaf17538e Move text to single group with subgroups for halo,label,debug 2017-12-14 12:32:28 -05:00
Bryan Housel
a5bbc21728 Remove unnecessary zoom parameter 2017-12-11 17:34:01 -05:00
Bryan Housel
6b9ccdb45a Add tests for osmNode#direction 2017-12-11 14:33:22 -05:00
Bryan Housel
6cfe7a2e71 When reversing a way, reverse traffic_signals:direction on child nodes
(closes #4595)
2017-12-06 20:48:21 -05:00
Bryan Housel
f247bd1e66 Move icon code into uiFlash, default flash icon to icon-no
Previously it was up to the caller to draw whatever they want into the
footer flash.  With this change, uiFlash creates an icon and a text, so
the caller doesn't need to do as much work.
2017-12-05 23:41:34 -05:00
Bryan Housel
9b705a6375 Don't call async callbacks after connection resets/switches
(closes #4288)
2017-11-14 21:30:01 -05:00
Bryan Housel
1dd437a1f2 Hide mapillary-js attribution and just handle it in iD
(closes #4526)

What we were doing before was d3.selecting the attribution line and
inserting the capture date into it. This was confusing the viewer
(which updates asynchronously) so that the sitelink would never update.
To make things easier, we'll just hide the viewer's built in attribution
and construct the attribution line the way we want it.
2017-11-14 11:32:42 -05:00
Bryan Housel
4571fd0563 Highlight selected/hovered streetview tracks, fade unselected
Also some code cleanups and nitpicky variable renames
More consistency in Mapillary/OpenStreetCam services
2017-11-08 00:35:44 -05:00
Bryan Housel
2947dcc2fb Add tests for Openstreetcam service and Mapillary sequences 2017-11-06 23:11:00 -05:00
Bryan Housel
00b30e29f0 WIP: Add OpenStreetCam support
todo: Need to figure out API issue with bbox, then imageviewer
2017-11-02 22:04:47 -04:00
Bryan Housel
a5d04cc2f1 Fix the highway=pedestrian + area=yes test 2017-10-31 16:56:55 -04:00
Nikita Mashukov
92374f7af9 tests for merge_way_nodes action 2017-10-30 22:32:48 +07:00
Bryan Housel
c40f242b82 Depend on bhousel/node-diff3 which includes fix for hunk sorting bug
(closes #3544, closes #3058)
2017-10-24 15:38:52 -04:00
Bryan Housel
b3842d97f4 Remove lodash from the test suite
(closes #4378)
2017-10-18 14:37:39 -04:00
Bryan Housel
8abc39461b Fallback Area preset should preserve the area=yes tag
(closes #4424)
2017-10-10 20:54:41 -04:00
Bryan Housel
b5168c1070 Restore the global d3 (needed so tests use the same d3.event as iD?) 2017-09-27 10:39:03 -04:00
Bryan Housel
9f1d476594 Attempt to remove d3, lodash from bundle, but leave available for tests 2017-09-26 14:19:14 -04:00
Bryan Housel
6eb392f147 Merge branch 'esri-vintage' of https://github.com/jgravois/iD into jgravois-esri-vintage 2017-09-12 09:45:18 -04:00
john gravois
5f341366e7 display additional metadata from Esri World Imagery
* getVintage() becomes getMetadata()
* ignore a couple unrelated lint nags
* add source description, resolution and accuracy info to debug panel
2017-09-11 09:51:07 -07:00
Bryan Housel
0d35c5ed59 Give preset priority in preset list when search matches name exactly
(closes #4325)
2017-09-10 12:56:14 -04:00
Bryan Housel
b7d98b94fb loadEntity loadEntityVersion and loadMultiple all should ignore entityCache 2017-08-24 21:00:39 -04:00
Bryan Housel
cd05c51432 loadEntity can use entityCache, but loadEntityVersion should not 2017-08-24 15:02:12 -04:00
Bryan Housel
99a3741b0c Better isolation of services, to avoid hitting network during test runs
1. All services are disabled in testing now to prevent network accesses
2. Only services are enabled when needed to test something
3. Many changes throughout code to allow iD to run with services disabled
   (e.g. check for osm service instead of assuming context.connection() will work)
4. Actually export the services so we can disable and enable them
2017-08-09 22:04:09 -04:00
Bryan Housel
b7958415b3 Don't remove all the divs under body when testing 2017-08-09 22:02:58 -04:00
Bryan Housel
94662a34e3 Restore scrolling in the test results screen 2017-08-09 22:01:59 -04:00
Bryan Housel
c7044bec3a Better mock for select mode, fixes false test failures 2017-08-09 11:09:08 -04:00
Bryan Housel
10659505e2 Add code to treat a few special tags as areas instead of lines
even in the absense of a proper `area=yes` or `areaKeys` tag.
(closes #4194)
2017-08-06 23:39:58 -04:00
Bryan Housel
bde4d6510f Update mapillary tests 2017-07-14 00:53:44 -04:00
Bryan Housel
01bfc67ea5 After splitting a way, update all matching relation members
(closes #4140)
2017-07-10 18:35:30 -04:00
Bryan Housel
b6c2645409 Add history urls to osm service and more URL tests 2017-06-30 00:52:05 -04:00
Bryan Housel
1c303edf18 Add generic reverse geocoder function to nominatim service 2017-06-29 01:23:33 -04:00
Bryan Housel
e8bd6bff6c Fix wikidata clearing, failed lookup when entity no longer selected
(closes #3987)
(closes #3684)
(related #3929)
2017-06-23 16:37:13 -04:00
Bryan Housel
2d665dbc1b Ignore Ctrl and Alt if both are present (e.g. AltGr on Windows)
(see #4096)
2017-06-09 11:42:35 -04:00
Bryan Housel
70d0a68c6d Use context.asset() to generate path to Mapillary image sprite 2017-06-09 10:53:48 -04:00
Bryan Housel
274552205d Merge pull request #4050 from mapillary/mapillary-api-v3
Update to Mapillary API v3 and add new traffic signs
2017-06-09 10:37:30 -04:00
Nikola Plesa
9c772a1058 Update to Mapillary API v3, use traffic signs from Mapillary sprites 2017-05-17 11:18:46 +02:00
Bryan Housel
89013627fb Don't consider untagged multipolygons as old multipolygons
Also add a lot of old-style multipolygon tests
(closes #4009)
2017-05-04 12:16:04 -04:00
Bryan Housel
ef95db8524 Add ability to history.pop n times
This is a little better than just calling pop a bunch of times because
it avoids dispatching extra history change events
2017-05-03 16:03:56 -04:00
Bryan Housel
2ebfcd174e Don't redo into un-annotated edit states
(closes #4006)
2017-05-03 00:21:37 -04:00
Bryan Housel
5ca4246a6d If drawing a way, don't hover on a node that was just placed
(closes #3974)
2017-04-26 13:33:21 -04:00
Bryan Housel
fb4c64bf70 Fix isConnected tests 2017-04-26 00:54:45 -04:00
Bryan Housel
3b54743f86 Add more d3.timerFlush to avoid false test failures (hopefully) 2017-04-24 16:15:41 -04:00
Bryan Housel
b803730a4b More modal and confirm tests, d3.timerFlush to avoid false failures 2017-04-24 14:57:47 -04:00