16273 Commits

Author SHA1 Message Date
Quincy Morgan 50fcff6ec9 Only check the edge nodes for almost junction merge fix 2019-02-06 14:12:19 -05:00
Quincy Morgan 7765baf03b Make merge threshold consistent for almost_junction and tag_suggests_area connection fixes 2019-02-06 13:12:58 -05:00
Quincy Morgan 88ecbcc069 Make the tag_suggests_area connection fix always use the location of the first node 2019-02-06 13:10:22 -05:00
Quincy Morgan 703d560a94 Merge branch 'master' into validation 2019-02-06 12:49:59 -05:00
Quincy Morgan b25d75a6cc Use existing nodes where possible in almost junction connection fix 2019-02-06 12:47:12 -05:00
Bryan Housel 601524c47c Use color instead of fill for the badge icon
re: 7fe0380d7

Now that the icons are all using `fill=currentColor` this is the way to do it
2019-02-06 11:54:45 -05:00
Quincy Morgan 8545ebde8e Add self-intersection check before flagging almost junction issues 2019-02-06 11:29:58 -05:00
greenkeeper[bot] d958844bc0 chore(package): update mapillary-js to version 2.16.0 2019-02-06 10:42:24 -05:00
Bryan Housel 640730d38b Change focus to existing key instead of suffixing it with _1
(re: #3625, re: #2896)
2019-02-06 10:29:09 -05:00
Quincy Morgan 4595a822dc Add code tests for more missing_tag cases 2019-02-06 10:08:28 -05:00
Quincy Morgan 21967d2654 Show the area preset browser rather than editor upon selecting multipolygon from the relation preset browser 2019-02-06 09:48:45 -05:00
Quincy Morgan 33d02cdba0 Add different messages for no tags vs. no descriptive tags warnings
Add warning for relation without a "type" tag
2019-02-06 09:38:33 -05:00
Quincy Morgan 6383fa7ea0 Merge branch 'master' into validation 2019-02-06 08:58:13 -05:00
Quincy Morgan 011f82239b Add new icons for Butcher, Cheese Shop, Copy Store, Dairy Shop, and Mexican Restaurant presets
Add Chess Table and Mexican Fast Food presets
2019-02-06 08:55:59 -05:00
Chad Rockey 31a5264c37 Add Golf Cartpath Multipurpose 2019-02-05 22:55:38 -08:00
Chad Rockey 25cc522333 Update to avoid connectivity errors 2019-02-05 22:20:16 -08:00
Quincy Morgan c1df48ce0f Simplify crossing ways warning message 2019-02-05 17:25:34 -05:00
Quincy Morgan 0aa3ce2cee Fix issue with Issues section appearance if the sidebar was loaded with the section closed 2019-02-05 16:57:34 -05:00
SilentSpike a566d58f81 Fix error on ImproveOSM issues with no comments 2019-02-05 21:48:06 +00:00
SilentSpike 0346d8060f Retrieve ImproveOSM comments only once
This additionally fixes the comment box not clearing on submission as I
wasn't updating the error in the cache (to remove the newComment
property).
2019-02-05 21:46:17 +00:00
Quincy Morgan 2aa285c378 Merge branch 'master' into validation 2019-02-05 16:38:02 -05:00
Quincy Morgan 26dd7a4148 Use error for missing tags on all newly added features 2019-02-05 16:19:43 -05:00
Bryan Housel b87ae4e98b Exclude existing keys from auto-completion in raw tag editor
(closes #3625)
2019-02-05 16:14:18 -05:00
SilentSpike 78111955dd Fix user URL on ImproveOSM comments 2019-02-05 21:06:19 +00:00
Quincy Morgan 1055c239ed Merge branch 'master' into validation 2019-02-05 16:03:19 -05:00
Quincy Morgan beab323b20 Use warning severity for missing_tag validation if the user has not edited the feature 2019-02-05 15:58:20 -05:00
SilentSpike c095600635 Use more appropriate new comment header string 2019-02-05 20:44:04 +00:00
SilentSpike 5fc87fb0a4 Pacify eslint
(I really need to start running npm test more often before pushing)
2019-02-05 20:23:02 +00:00
SilentSpike f7bef29b92 Fix date conversion on ImproveOSM comments 2019-02-05 20:03:55 +00:00
SilentSpike fa87ed75ae Display ImproveOSM comments oldest to newest 2019-02-05 19:57:22 +00:00
SilentSpike 2c7b689b47 Add comments display to ImproveOSM issues 2019-02-05 19:52:44 +00:00
Bryan Housel 51af1f3b13 Don't re-sort the keys in the raw tag editor when tabbing
(closes #5857)
2019-02-05 14:52:13 -05:00
SilentSpike 28bb12b7ae Add function to retrieve ImproveOSM comments
Just need to have the UI make this call and use the data next.
2019-02-05 19:31:30 +00:00
Quincy Morgan bfefea422b Use iD's area tag logic for the tag_suggests_area validation 2019-02-05 13:55:59 -05:00
Chad Rockey c34f010e05 Remove golf tags 2019-02-05 10:44:20 -08:00
Quincy Morgan 4f68e71094 Merge endpoints rather than add segment if ends are close together in tag_suggest_area fix 2019-02-05 13:21:39 -05:00
Quincy Morgan 7dd337383a Add quick fix for connecting the endpoints of a line where tags suggest area if it won't create self-intersection 2019-02-05 12:16:46 -05:00
Chad Rockey 0bc5c13b88 Cleanup according to comments 2019-02-05 09:14:07 -08:00
SilentSpike 448119324f Add ability to comment on ImproveOSM issues 2019-02-05 17:11:37 +00:00
Quincy Morgan a80aaf65db Improve performance when checking way for self-intersection when drawing 2019-02-05 11:42:45 -05:00
Quincy Morgan 8771a33716 Merge branch 'master' into validation 2019-02-05 11:30:24 -05:00
Quincy Morgan 3808685ee3 Rewrote tag as disconnected fix undo message to be more consistent 2019-02-05 11:29:09 -05:00
Bryan Housel 13e9e99c4a Allow "Monitoring Station" preset on vertex geometry
(closes #5827)
2019-02-05 11:21:37 -05:00
Quincy Morgan d09e76ccad Merge branch 'master' into validation 2019-02-05 11:18:59 -05:00
Bryan Housel 5c10aa397f Merge branch 'SilentSpike-unify' 2019-02-05 11:18:19 -05:00
Quincy Morgan 23ab1b66fb Revert "Update places of worship to use field inheritance"
This reverts commit 44d4f2378d.
2019-02-05 11:06:31 -05:00
Bryan Housel e71eddd138 Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify 2019-02-05 10:41:08 -05:00
Quincy Morgan 7763626b02 Add access_simple field to library preset
Update Website field placeholder to use https
2019-02-05 10:22:43 -05:00
Quincy Morgan 44d4f2378d Update places of worship to use field inheritance
Add website to defaults fields for places of worship
Add presets for common place of worship denominations
2019-02-05 10:16:22 -05:00
greenkeeper[bot] 91285bc4f0 chore(package): update esm to version 3.2.1 2019-02-05 10:00:15 -05:00