16273 Commits

Author SHA1 Message Date
Quincy Morgan 6a9bb2d138 Add crossing tags when connecting paths crossing roads with the quick fix 2019-02-11 12:03:56 -05:00
Quincy Morgan 99e1203d46 Zoom to entity when opening an issue without a specific location in the entity editor 2019-02-11 11:48:21 -05:00
Quincy Morgan 149e1b3e4d Removed unused string 2019-02-11 11:41:18 -05:00
Quincy Morgan 47ec58e5fc Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan 01b0c618d1 Don't highlight the selected entity when hovering over issues in the entity editor 2019-02-11 10:58:47 -05:00
Quincy Morgan ceee3c1a4b Merge branch 'master' into validation 2019-02-11 10:23:50 -05:00
Bryan Housel 151e2685d4 Force selectedIDs to be visible
(re: #5880)
2019-02-11 10:01:54 -05:00
Quincy Morgan 11dc86ca9b Add check for entity geometry type in allowsVertex function (re: #5875) 2019-02-11 09:59:43 -05:00
Quincy Morgan 83f8cd97f6 Add feature highlighting when hovering over their corresponding issues 2019-02-11 09:45:33 -05:00
Quincy Morgan db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
Bryan Housel ba44c80076 Force visible any entities related to a selected error
(closes #5880)
2019-02-10 23:29:49 -05:00
Bryan Housel 6e45796be7 Merge pull request #5875 from openstreetmap/dont-snap-non-vertices
Dont snap to non-vertices
2019-02-10 22:13:09 -05:00
Bryan Housel 26368522c9 Batch changes from raw tag editor so blur/remove tag don't conflict
(closes #5878)
2019-02-10 22:08:13 -05:00
Bryan Housel d64a4c5654 Don't pan map when resizing sidebar on right-to-left layout
(closes #5881)
2019-02-09 15:48:55 -05:00
Bryan Housel 65fc1437dc Fix wiki image float and margins on rtl layout 2019-02-09 15:30:57 -05:00
Bryan Housel d055f34be8 Add sitelinks to result from wikidata getDocs 2019-02-09 15:18:32 -05:00
Bryan Housel 29ce6cb30c Use proper errbacks
(re: #5823)
2019-02-09 14:51:37 -05:00
Bryan Housel fac9c2dadc Merge pull request #5879 from SilentSpike/3rd-party
Fix negative number of trips in ImproveOSM issues
2019-02-09 14:13:32 -05:00
SilentSpike 24022416cb Fix negative number of trips in ImproveOSM issues
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
Bryan Housel 48d001dcb9 Don't capitalize first letter of error message in Persian
(closes #5877, re: #5679)
2019-02-09 10:21:13 -05:00
Bryan Housel 6ff381cb28 Drop "from this key" jargon 2019-02-08 17:01:54 -05:00
Bryan Housel a2b140e92b Remove unnecessary ternary 2019-02-08 16:38:40 -05:00
Bryan Housel fbe584c7ec Lookup docs for some presets on wikidata, not wikibase
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
Bryan Housel 2a7fec46fe Fetch somewhat higher resolution images
(100x100 was really too small)
2019-02-08 13:36:39 -05:00
Bryan Housel b050c2f442 Avoid keeping focus on the documentation lookup button 2019-02-08 13:34:29 -05:00
Bryan Housel 32c42073c6 Add support for Relation type documentation lookups from wikibase
(closes #5860)
2019-02-08 13:24:58 -05:00
Quincy Morgan ff6860693a Merge branch 'master' into validation 2019-02-08 13:21:46 -05:00
Bryan Housel e0459279bb Move implementation details from uiTagReference to wikibase service 2019-02-08 12:08:36 -05:00
Bryan Housel 71f2bd5900 Fix key sorting between hover/select
(this is a better fix for #5857)
2019-02-08 09:37:51 -05:00
Quincy Morgan d70c02ee6d Replace use of Set object in validator 2019-02-08 09:33:17 -05:00
Quincy Morgan 55f71f5a7d Replace Set objects in crossing ways validation 2019-02-08 09:20:41 -05:00
Quincy Morgan 1564f73de6 Merge branch 'master' into validation 2019-02-07 20:51:21 -05:00
Bryan Housel a363f5175f Fix tabbing beyond last row of raw tag editor in Firefox
(closes #5847)

- removed the stopPropagation from the combobox keydown handler
  to make sure that the raw_tag_editor keydown handler will run

- increased timeout from 1ms to 10ms for Firefox
  This is related to Firefox's newish time budgeting approach that they
  started using around Firefox 55.  As a result, very fast timers (<4ms?)
  may run synchronously instead of yielding and running asynchronously
  https://blog.wanderview.com/blog/2017/03/13/firefox-52-settimeout-changes/

  (note similar code in ui/fields/combo.js to delay focus changes and
  redraws 10ms after the tag changes and other events have completed)
2019-02-07 15:56:49 -05:00
Bryan Housel 02790fcc5c Also make sure you can delete the new row in the raw tag editor
(re #5840)
2019-02-07 15:04:16 -05:00
Bryan Housel 2aa409d5a9 Fix crash when deleting rows in raw tag editor
(closes #5840)

This didn't always trigger a crash, but it can.  It attempted to remove the
row containing the key/value input fields, however this ilne is unnecessary
because the change event will trigger a redraw and d3 will handle the removing
milliseconds later.
2019-02-07 14:10:04 -05:00
Bryan Housel d2735ab40c Fix misspelling 2019-02-07 13:41:06 -05:00
Bryan Housel 492bb5b37e Eliminate magic scale numbers from tests, add loadNotes test xml 2019-02-07 11:31:32 -05:00
Bryan Housel 3875ea565b Remove mvt querystring parameter that we never used 2019-02-07 10:48:19 -05:00
Bryan Housel 8ec426bd9d Increase contrast between waterways and ski pistes
we can do:
- waterways are more on the green/teal side of blue,
- pistes are more on the red/magenta side of blue
2019-02-07 10:36:44 -05:00
Bryan Housel bb0a47b255 Remove kr and keepRight for styles used generically
(it was weird to see these classes in improveOSM components)
2019-02-07 10:35:50 -05:00
Bryan Housel f4b9abe474 Merge pull request #5867 from SilentSpike/iOSM-comments
Add comments to ImproveOSM issues
2019-02-07 09:46:57 -05:00
Quincy Morgan d3bbdfab7e Merge branch 'master' into validation 2019-02-07 07:01:36 -05:00
Bryan Housel 043b827cc7 Remove linear water_hazard and lateral_water_hazard presets
From reviewing wiki, these seem like not a thing - they are always areas.
re: https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course
2019-02-06 22:07:07 -05:00
Bryan Housel ce3b33e374 Add style for golf walking paths and cartpaths
Also
- use field inheritance to simplify presets
- rename multipurpose to "Golf Cartpath / Service Road"
  (I think users would understand this better)
- add `maxspeed` to "Golf Cartpath / Service Road"
2019-02-06 21:56:22 -05:00
Bryan Housel e045c0f178 Merge pull request #5862 from chadrockey/golf_paths
Presets for golf paths and cartpaths and driving ranges
2019-02-06 21:17:30 -05:00
Chad Rockey 90115b55ca Update track to service 2019-02-06 14:31:11 -08:00
Quincy Morgan a702281fb6 Add "remove" tooltip to raw tag editor remove button 2019-02-06 15:56:12 -05:00
Quincy Morgan 7036523bfc Merge branch 'master' into validation 2019-02-06 15:37:03 -05:00
Quincy Morgan 5b8fea9e87 Use existing nodes where possible in the crossing ways connection fix
Fix a lint warning
2019-02-06 15:03:29 -05:00
Bryan Housel e0a41656a1 Allow value to be entered before key in raw tag editor
(closes #5872)

This commit also hardens the 'key=value' splitting behavior to actually
check the split result length and avoid overwriting a readonly key
(re: #5024)
2019-02-06 15:03:03 -05:00