Commit Graph

10153 Commits

Author SHA1 Message Date
Bryan Housel 15c0b82eb2 First attempt to run tests with minimal preset config 2019-01-30 10:25:40 -05:00
Bryan Housel 17bbc3d5a2 Slightly improve suggestion placement, preset search performance
- avoid lodash _filter when native filter is ok for arrays
- for suggestions use `originalName` instead of adding/removing the en-dash
- bump up importance of leading suggestions, but do a strict leading search

more on that last point:
For normal presets, we count a string as leading if it follows a space.
e.g. "office" will match "Law Office"
We don't really want this for suggestion presets though
e.g. "bell" should not match "Taco Bell"
2019-01-29 21:56:23 -05:00
Bryan Housel a4eab24117 Merge pull request #5744 from SilentSpike/javascript-eol
Update .gitattributes to use lf eol for .js files
2019-01-29 15:14:20 -05:00
Bryan Housel 7e3f08b31a Restore missing paths_intersect string needed for #5745 2019-01-29 15:09:49 -05:00
Bryan Housel 7aea67fcfe Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self
Add check to stop joining ways if resulting way intersects itself
2019-01-29 14:07:34 -05:00
Bryan Housel 0f41913b04 pacify eslint 2019-01-29 14:04:36 -05:00
Bryan Housel a2212a732b Merge pull request #5816 from SilentSpike/mapillary-icon
Fix street imagery hover and selection behaviour
2019-01-29 13:59:28 -05:00
Bryan Housel ad3f491116 Replace maki "M" museum icon
(closes #5751)
2019-01-29 13:51:34 -05:00
Bryan Housel d3c0d1a7b7 Merge pull request #5826 from SilentSpike/reverse-turns
Fix turn:lanes changing when way is reversed
2019-01-29 09:31:41 -05:00
SilentSpike 20d629ac9e Fix turn:lanes changing when way is reversed 2019-01-29 14:19:35 +00:00
Quincy Morgan b1de70c63f Add Sundial preset (close #5771) 2019-01-29 09:13:25 -05:00
Quincy Morgan b2e57c37e9 Add Minaret preset (close #5817) 2019-01-29 09:04:27 -05:00
Quincy Morgan 28f49d3015 Add Bell Tower preset (close #5772)
Update tower presets to use field inheritance
2019-01-29 08:55:11 -05:00
Quincy Morgan c9fef9e3fe Add Climbing Gym preset (close #5749) 2019-01-29 08:41:45 -05:00
Quincy Morgan a6636a2f44 Add Salt and Tidal fields to water presets (close #5822) 2019-01-29 08:29:21 -05:00
SilentSpike 129c28fb25 Fix street imagery selection highlight persistence
Root cause was the `select` mode removing the "selected" class from all
elements upon `exit()`. Easy fix is to use a different class (here
"currentView") for street imagery elements.
2019-01-29 13:26:53 +00:00
SilentSpike 99f7a90387 Fix imagery layers resetting eachother's classes
Fixes:
- Selecting a bubble then enabling a second imagery layer removes the hovered and selected highlighting
- If multiple imagery layers are enabled and you select a bubble it only temporarily becomes highlighted
- If multiple imagery layers are enabled and a bubble is highlighted, hovering over another imagery layer's bubble will remove the selected and hovered highlighting

Basically these all came down to style updates resetting all layers for
cases other than when the viewport was changed (where doing so makes
sense because the selected bubble/sequence needs to update as a result).

See #5494
2019-01-29 13:25:47 +00:00
SilentSpike da41d9d921 Fix mouseover events on imagery layer bubbles
This is just a minor thing that doesn't usually alter visible behaviour.

The mouseover and mouseout events would fire when moving between child
elements of the svg group which was unnecessary.
2019-01-29 13:24:01 +00:00
Quincy Morgan 02ccd7cfd6 v2.13.1 2019-01-28 17:38:05 -05:00
Quincy Morgan 78a7869cd9 npm run translations 2019-01-28 17:37:13 -05:00
Bryan Housel f952422695 Update Changelog with combobox bugfixes 2019-01-28 16:35:10 -05:00
Bryan Housel af8fb1d758 Show combobox if we are moving from a different active combobox
(closes #5752)

Previously it would go down the `hide()` branch anytime an existing combobox
was active.
2019-01-28 16:22:37 -05:00
Quincy Morgan 34ecd14da8 Update name-suggestion-index to 1.0.4 2019-01-28 16:03:40 -05:00
Bryan Housel 49442afe0c In raw member editor, cancel combobox on blur if it hasn't been accepted 2019-01-28 15:41:50 -05:00
Quincy Morgan 10ee54d624 Update changelog for v2.13.1 2019-01-28 15:16:58 -05:00
Bryan Housel d0021f77ca Handle possibility of combobox blurring without dispatching accept 2019-01-28 13:43:40 -05:00
Quincy Morgan 34e21e2fe9 Update release instructions 2019-01-28 13:16:20 -05:00
Quincy Morgan 67b3b92cdf Add name and intermittent fields to natural/water preset
Update natural/water/... presets to use field inheritance
2019-01-28 12:38:27 -05:00
Bryan Housel 623eb3c2b9 Show covered field on drive-through preset 2019-01-28 12:11:31 -05:00
Quincy Morgan b73ad48802 Add the covered field to more presets
Add "water fountain" and synonyms as terms to amenity/drinking_water preset
2019-01-28 11:45:34 -05:00
Bryan Housel 87ddfa68dc Revert 55715a482 - caused raw_tag_editor combos to not blur in Safari 2019-01-28 11:20:32 -05:00
Quincy Morgan 4ef46a4b1d Fix issue where Chrome would attempt to autofill fields (close #5818) 2019-01-28 11:15:59 -05:00
Quincy Morgan 3903e9347e Add covered field to moreFields of various rail presets 2019-01-28 09:04:36 -05:00
Quincy Morgan 1066f8f788 Fix issue where preset browser would show after continuing a line (close #5770) 2019-01-28 08:52:20 -05:00
Quincy Morgan 3a48b3b57c Add inscription field to the bench preset
Add building_area field to the attraction/carousel and attraction/dark_ride presets
2019-01-28 08:32:03 -05:00
Bryan Housel 7cdca993e8 Move "Name" from fields to moreFields on Other vertex preset
(closes #5812)
2019-01-27 20:53:47 -05:00
Bryan Housel 9febb34b53 Add "riverbank" for search term for River area preset 2019-01-27 13:23:04 -05:00
Bryan Housel 1a3a411507 Restore basin preset
(closes #5758)
2019-01-27 13:19:16 -05:00
Bryan Housel b9444ab991 Restore hand cursor on dropdown carat
(closes #5769)

This change allows pointer events to flow to the caret, and forwards
them back to the combo input.  Also renames several event handlers
for clarity, and increases the double-click detection threshold.
2019-01-26 13:22:31 -05:00
Bryan Housel 18d71448be pacify eslint 2019-01-25 16:23:46 -05:00
Bryan Housel 5d6e331635 Don't erase name field when tabbing from it
(closes #5760)
2019-01-25 16:16:07 -05:00
Bryan Housel 55715a4827 Try to dispatch an accept event on blur
(re: #5752 - but does not close it)
2019-01-25 14:47:17 -05:00
Quincy Morgan 8f5ab67a9c Add roof:colour field to moreFields of building presets 2019-01-25 14:02:57 -05:00
Quincy Morgan eb9c516b2c Add architect field to moreFields of building presets 2019-01-25 13:57:45 -05:00
Quincy Morgan f2f4c2d9c7 Make optional multiCombo fields appear if a value exists (closes #5764) 2019-01-25 09:43:07 -05:00
Quincy Morgan 82274a2c3c Add Hours field to atm (close #5750)
Add Hours field to toilets (cc #5755)
2019-01-25 08:55:03 -05:00
Quincy Morgan decba8f215 Fix cycleway field to appear if "cycleway" tag present but not "cycleway:left" nor "cycleway:right" (close #5756) 2019-01-25 08:39:15 -05:00
Quincy Morgan 5eda112bfa Move Hours field from moreFields to fields of shop presets
Add Currency Types field to moreFields of shop presets
2019-01-25 08:15:55 -05:00
Bryan Housel df87374042 Add {leftclick} icon to help section about adjusting imagery offset 2019-01-23 23:55:07 -05:00
Bryan Housel 23087755ce Add more forestry terms
re: transifex https://www.transifex.com/openstreetmap/id-editor/translate/#ta/$/14390187?q=issue%3Aopen
2019-01-23 23:47:07 -05:00