Commit Graph

10256 Commits

Author SHA1 Message Date
Quincy Morgan 19a2a60bf4 Add tooltip to disabled upload button to specify what is blocking the upload 2019-01-30 13:20:56 -05:00
Quincy Morgan 4048cdaf3b Merge branch 'master' into validation 2019-01-30 10:30:14 -05:00
Bryan Housel 17bbc3d5a2 Slightly improve suggestion placement, preset search performance
- avoid lodash _filter when native filter is ok for arrays
- for suggestions use `originalName` instead of adding/removing the en-dash
- bump up importance of leading suggestions, but do a strict leading search

more on that last point:
For normal presets, we count a string as leading if it follows a space.
e.g. "office" will match "Law Office"
We don't really want this for suggestion presets though
e.g. "bell" should not match "Taco Bell"
2019-01-29 21:56:23 -05:00
Quincy Morgan 3782acfc88 Merge branch master into validation 2019-01-29 16:52:59 -05:00
Quincy Morgan 6df2c24b14 Add Continue and Delete quick fixes for disconnected highway issue 2019-01-29 16:45:28 -05:00
Bryan Housel a4eab24117 Merge pull request #5744 from SilentSpike/javascript-eol
Update .gitattributes to use lf eol for .js files
2019-01-29 15:14:20 -05:00
Bryan Housel 7e3f08b31a Restore missing paths_intersect string needed for #5745 2019-01-29 15:09:49 -05:00
Quincy Morgan 0b19d5f93a Merge branch master into validation 2019-01-29 14:51:59 -05:00
Quincy Morgan 94c8f9f9f7 Update text for features to edit 2019-01-29 14:48:18 -05:00
Quincy Morgan fedad280b4 Use different messages for crossing tunnels and bridges if they are connectable 2019-01-29 14:30:42 -05:00
Bryan Housel 7aea67fcfe Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self
Add check to stop joining ways if resulting way intersects itself
2019-01-29 14:07:34 -05:00
Bryan Housel 0f41913b04 pacify eslint 2019-01-29 14:04:36 -05:00
Bryan Housel a2212a732b Merge pull request #5816 from SilentSpike/mapillary-icon
Fix street imagery hover and selection behaviour
2019-01-29 13:59:28 -05:00
Bryan Housel ad3f491116 Replace maki "M" museum icon
(closes #5751)
2019-01-29 13:51:34 -05:00
Quincy Morgan ccfba8ba0d Don't validate crossing ways with area tags
Don't show connection fix for highway/waterway intersection if the highway is a major road
2019-01-29 13:44:37 -05:00
Quincy Morgan 742147c62b Don't validate water areas or specific highway, waterway, or railway features 2019-01-29 13:31:02 -05:00
Quincy Morgan b1e5b4f3ec Check to see if ways can be connected before offering that quick fix 2019-01-29 13:05:11 -05:00
Quincy Morgan 907c4d9616 Rename fix function from action to onClick 2019-01-29 12:18:02 -05:00
Quincy Morgan 80c7aedb39 Fix bug with issues pane 2019-01-29 11:59:01 -05:00
Quincy Morgan fcc7606089 Update crossing_ways fix to not use the context within the action 2019-01-29 11:47:24 -05:00
Quincy Morgan b787af56a6 Add grayscale hover styling to entity issues 2019-01-29 11:33:48 -05:00
Quincy Morgan 226c4f88e1 Re-run validation automatically upon merging fetched remote data into the history 2019-01-29 11:10:12 -05:00
Quincy Morgan 2051dc4ca8 Update id of remove generic name fix 2019-01-29 10:45:48 -05:00
Quincy Morgan f89c18e65d Added quick fix for tag_suggest_area validation to remove the suggesting tags 2019-01-29 10:40:08 -05:00
Quincy Morgan b48445b29a Make the first issue's fix list appear by default 2019-01-29 09:56:44 -05:00
Bryan Housel d3c0d1a7b7 Merge pull request #5826 from SilentSpike/reverse-turns
Fix turn:lanes changing when way is reversed
2019-01-29 09:31:41 -05:00
SilentSpike 20d629ac9e Fix turn:lanes changing when way is reversed 2019-01-29 14:19:35 +00:00
Quincy Morgan 0866110d77 Merge branch 'master' into validation 2019-01-29 09:16:06 -05:00
Quincy Morgan b1de70c63f Add Sundial preset (close #5771) 2019-01-29 09:13:25 -05:00
Quincy Morgan b2e57c37e9 Add Minaret preset (close #5817) 2019-01-29 09:04:27 -05:00
Quincy Morgan 28f49d3015 Add Bell Tower preset (close #5772)
Update tower presets to use field inheritance
2019-01-29 08:55:11 -05:00
Quincy Morgan c9fef9e3fe Add Climbing Gym preset (close #5749) 2019-01-29 08:41:45 -05:00
Quincy Morgan a6636a2f44 Add Salt and Tidal fields to water presets (close #5822) 2019-01-29 08:29:21 -05:00
SilentSpike 129c28fb25 Fix street imagery selection highlight persistence
Root cause was the `select` mode removing the "selected" class from all
elements upon `exit()`. Easy fix is to use a different class (here
"currentView") for street imagery elements.
2019-01-29 13:26:53 +00:00
SilentSpike 99f7a90387 Fix imagery layers resetting eachother's classes
Fixes:
- Selecting a bubble then enabling a second imagery layer removes the hovered and selected highlighting
- If multiple imagery layers are enabled and you select a bubble it only temporarily becomes highlighted
- If multiple imagery layers are enabled and a bubble is highlighted, hovering over another imagery layer's bubble will remove the selected and hovered highlighting

Basically these all came down to style updates resetting all layers for
cases other than when the viewport was changed (where doing so makes
sense because the selected bubble/sequence needs to update as a result).

See #5494
2019-01-29 13:25:47 +00:00
SilentSpike da41d9d921 Fix mouseover events on imagery layer bubbles
This is just a minor thing that doesn't usually alter visible behaviour.

The mouseover and mouseout events would fire when moving between child
elements of the svg group which was unnecessary.
2019-01-29 13:24:01 +00:00
Quincy Morgan 02ccd7cfd6 v2.13.1 2019-01-28 17:38:05 -05:00
Quincy Morgan 78a7869cd9 npm run translations 2019-01-28 17:37:13 -05:00
Bryan Housel f952422695 Update Changelog with combobox bugfixes 2019-01-28 16:35:10 -05:00
Bryan Housel af8fb1d758 Show combobox if we are moving from a different active combobox
(closes #5752)

Previously it would go down the `hide()` branch anytime an existing combobox
was active.
2019-01-28 16:22:37 -05:00
Quincy Morgan 34ecd14da8 Update name-suggestion-index to 1.0.4 2019-01-28 16:03:40 -05:00
Bryan Housel 49442afe0c In raw member editor, cancel combobox on blur if it hasn't been accepted 2019-01-28 15:41:50 -05:00
Quincy Morgan 10ee54d624 Update changelog for v2.13.1 2019-01-28 15:16:58 -05:00
Bryan Housel d0021f77ca Handle possibility of combobox blurring without dispatching accept 2019-01-28 13:43:40 -05:00
Quincy Morgan 34e21e2fe9 Update release instructions 2019-01-28 13:16:20 -05:00
Quincy Morgan 67b3b92cdf Add name and intermittent fields to natural/water preset
Update natural/water/... presets to use field inheritance
2019-01-28 12:38:27 -05:00
Quincy Morgan a06b8e4306 Add water=intermittent, water=riverbank, water=salt, and water=tidal to deprecated tags list 2019-01-28 12:24:34 -05:00
Quincy Morgan f25a80c48c Merge branch 'master' into validation 2019-01-28 12:14:04 -05:00
Bryan Housel 623eb3c2b9 Show covered field on drive-through preset 2019-01-28 12:11:31 -05:00
Quincy Morgan b73ad48802 Add the covered field to more presets
Add "water fountain" and synonyms as terms to amenity/drinking_water preset
2019-01-28 11:45:34 -05:00