Commit Graph

346 Commits

Author SHA1 Message Date
Quincy Morgan
3a933de876 Don't add tags to connection node when connecting crossing line/area 2020-04-13 18:57:26 -07:00
Quincy Morgan
513b344012 Fix code tests 2020-04-03 13:33:54 -07:00
Quincy Morgan
ca1e2031e7 Flag issues with crossing highway areas (close #7455)
Don't show add bridge/tunnel fixes for highway areas (close #7472)
2020-04-03 12:30:07 -07:00
Quincy Morgan
0120b009fa Take a graph parameter in utilDisplayLabel instead of the context 2020-04-01 13:29:17 -07:00
Quincy Morgan
60f7dc7c0b Replace presets property of context with singleton
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan
a58abe3c6f Move localStorage interface from a property of coreContext to a corePreferences function 2020-04-01 11:00:48 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
a7cba6a694 Don't show the tunnel fix for features crossing waterways (re: #7447) 2020-03-23 10:13:21 -07:00
Quincy Morgan
1041f89716 Fix line continuing 2020-03-16 13:43:24 -07:00
Quincy Morgan
4a6baccad3 Merge branch '2.x' into endpoints-fix 2020-02-27 12:59:00 -08:00
Quincy Morgan
3e7ac18701 Use the lowest closeness threshold when flagging shared very close points (close #7379) 2020-02-24 11:53:16 -08:00
SilentSpike
142126f7fe Store node for quick fix in data not entityIds
Realised these are used for highlighting and should remain as is.
2020-02-11 16:10:46 +00:00
SilentSpike
0b4a690a08 Move close endpoint handling into quick fix
Just a bit more optimised since this is only relevant to check when the
quick fix is used
2020-02-11 16:10:45 +00:00
SilentSpike
006e692449 Convert to 2 space indentation 2020-02-11 16:10:45 +00:00
SilentSpike
3c7b092534 Update almost junction validation with ES6 syntax 2020-02-11 16:10:45 +00:00
SilentSpike
ec6ad0000b Show derivation of close node thresholds in code 2020-02-11 16:10:44 +00:00
SilentSpike
6976251ac2 Handle almost junction where end node are close
Based on distances at which nodes are joined by the quickfix and the
validation extends ahead of an end node, if both ways have close end
nodes and joining them would result in a small change of angle for the
edited way then they will be joined.

Closes #7201
2020-02-11 16:10:44 +00:00
Bryan Housel
0fe766d9a4 WIP on external presets
- preset data is no longer bundled into iD.js
- some code pathways commented out re: external presets
- many changes so that tests can run without presets at start, or async
- still need to make sure fallbacks are always there (point, line, area, etc)
2020-02-05 09:38:26 -05:00
Bryan Housel
fe5ca6867c Fix error in generating outdated_tags messgae 2020-02-04 13:00:14 -05:00
Bryan Housel
06eac7c9d0 Don't bundle the nsi brands anymore, fetch from CDN at runtime
(re: #4994)
2020-02-01 17:40:56 -05:00
Bryan Housel
743dc0a83a Don't bundle the nsi brands anymore, fetch from CDN at runtime
(re: #4994)
2020-01-31 22:07:21 -05:00
Bryan Housel
567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Quincy Morgan
45d22261fc Don't leave an extra junction segment when the end node of the crossing edge is only the endpoint of two lines (re: #7202)
Make the length of added crossing structures much closer to the intended spherical length
2020-01-16 17:55:13 -05:00
Quincy Morgan
3340d05502 Add Solar Farm and Wind Farm presets 2020-01-14 20:50:00 -05:00
Quincy Morgan
0eb9912e01 Don't flag empty name tag as mistaken (close #7153) 2020-01-13 14:47:05 -05:00
Quincy Morgan
6c30ae2664 Where possible, leave a segment between structures and intersections when applying the "add a bridge/tunnel" fix (close #7202) 2020-01-09 11:36:19 -05:00
Quincy Morgan
4adecbb6ac Account for the angle of the crossing in the length of structures when applying "add a bridge/tunnel" fixes 2020-01-08 14:11:27 -05:00
Quincy Morgan
09ad21a26f Improve "add a bridge/tunnel" fixes by basing the structure length on the crossed feature type, not a fixed constant (re: #7202) 2020-01-08 12:03:30 -05:00
Quincy Morgan
03cea6435a Update unsquare way fix annotations 2019-12-12 17:02:55 -05:00
Quincy Morgan
9d936b4aea Rename rendererMap.editable function to more precise rendererMap.editableDataEnabled
Make coreContext.editable function also account for whether user is in modeSave
2019-12-12 16:06:28 -05:00
Quincy Morgan
a7dd6db8a7 Use tunnel=culvert on waterways when using the "add a tunnel" crossing ways fix (re: #6617) 2019-12-11 10:31:33 -05:00
Quincy Morgan
394396326c Update to temaki 3.4.0 (close #7102) 2019-12-09 12:44:17 -05:00
Bryan Housel
16ff2b1373 Upgrade country-coder to scoped package @ideditor/country-coder 2019-12-02 13:51:04 -05:00
Quincy Morgan
be6e69c2e2 Always flag tags as incomplete rather than outdated when the changes are purely additive 2019-11-25 11:14:59 -05:00
Quincy Morgan
9f8e88a2ff Don't cache point-as-vertex extraction fix 2019-11-25 10:49:16 -05:00
Quincy Morgan
6f09c3f4cc Flag unknown roads that are also members of relations 2019-11-22 17:51:39 -05:00
Quincy Morgan
b62162b191 Add check to ensure osm service is available before calling isDataLoaded 2019-11-22 16:08:41 -05:00
Quincy Morgan
62865db740 Fix issue where crossing ways layer fix would set layer tag as a number instead of a string (re: #6911) 2019-11-22 15:50:40 -05:00
Quincy Morgan
22266c66b1 Suggest noexit fix for almost junctions even if the endpoint has uninteresting tags 2019-11-22 15:47:34 -05:00
Quincy Morgan
7945f5d6ff Don't flag missing tags for nodes on unloaded tiles 2019-11-22 15:32:27 -05:00
Quincy Morgan
59f0c04e13 Don't flag unclosed parts of multipolygons with undownloaded members (re: #2223) 2019-11-22 15:00:43 -05:00
Quincy Morgan
45ac186a68 Flag unclosed multipolygon parts (close #2223) 2019-11-22 14:55:51 -05:00
Quincy Morgan
588fa36a3a Restore fixes for generic name warnings 2019-11-21 11:53:40 -05:00
Quincy Morgan
7cd57789fe Improve "add a bridge/tunnel" fix variable names somewhat (re: #7055)
Add a minimum structure length as derived from the crossing feature's width
2019-11-20 16:58:42 -05:00
Quincy Morgan
ff6eb88957 Update add a bridge/tunnel fix icons 2019-11-20 16:04:10 -05:00
Quincy Morgan
e791b7514c Use existing vertices for "add a bridge/tunnel" endpoints if the edge is too short to add a new vertex (re: #7055)
Avoid creating very short edges from splitting too close to another node when adding a bridge or tunnel via fix
Fix possible "entity not found" error
2019-11-20 15:44:14 -05:00
Quincy Morgan
5640d7867a Simplify some "add bridge or tunnel" fix code (re: #7055)
Add endpoint to actionSplit to get the created ways after running the action
Change "Use bridge" or "tunnel" fix labels to "Add a bridge" or "tunnel"
Add layer tags on structure feature when adding a bridge or tunnel via a fix
Select all components of the split way when adding a bridge or tunnel via a fix
Don't recommend adding a bridge to a waterway
Don't show "change layers" fixes along with "add structure" fixes
Don't split or change the tags of coincident ways when adding a bridge or tunnel
2019-11-20 13:09:27 -05:00
Katarzyna Król
5ed22cce21 create bridge or tunnel when crossed ways 2019-11-20 12:54:43 -05:00
Quincy Morgan
d2c73f8a86 Restore fixes for very close vertices issues 2019-11-18 12:07:48 -05:00
Quincy Morgan
96c8bcb152 Add tooltip to delete feature fix explaining if it's disabled (close #6588) 2019-11-13 14:52:57 -05:00