46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
49d62721d8
Fix background layer UI bugs
...
Add semicolon
2019-01-30 16:10:01 -05:00
77c4d41855
Restore many deletions warning with tooltip and nicer message
...
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
19a2a60bf4
Add tooltip to disabled upload button to specify what is blocking the upload
2019-01-30 13:20:56 -05:00
94c8f9f9f7
Update text for features to edit
2019-01-29 14:48:18 -05:00
907c4d9616
Rename fix function from action to onClick
2019-01-29 12:18:02 -05:00
80c7aedb39
Fix bug with issues pane
2019-01-29 11:59:01 -05:00
b48445b29a
Make the first issue's fix list appear by default
2019-01-29 09:56:44 -05:00
0866110d77
Merge branch 'master' into validation
2019-01-29 09:16:06 -05:00
af8fb1d758
Show combobox if we are moving from a different active combobox
...
(closes #5752 )
Previously it would go down the `hide()` branch anytime an existing combobox
was active.
2019-01-28 16:22:37 -05:00
49442afe0c
In raw member editor, cancel combobox on blur if it hasn't been accepted
2019-01-28 15:41:50 -05:00
d0021f77ca
Handle possibility of combobox blurring without dispatching accept
2019-01-28 13:43:40 -05:00
f25a80c48c
Merge branch 'master' into validation
2019-01-28 12:14:04 -05:00
87ddfa68dc
Revert 55715a482 - caused raw_tag_editor combos to not blur in Safari
2019-01-28 11:20:32 -05:00
b9444ab991
Restore hand cursor on dropdown carat
...
(closes #5769 )
This change allows pointer events to flow to the caret, and forwards
them back to the combo input. Also renames several event handlers
for clarity, and increases the double-click detection threshold.
2019-01-26 13:22:31 -05:00
18d71448be
pacify eslint
2019-01-25 16:23:46 -05:00
5d6e331635
Don't erase name field when tabbing from it
...
(closes #5760 )
2019-01-25 16:16:07 -05:00
55715a4827
Try to dispatch an accept event on blur
...
(re: #5752 - but does not close it)
2019-01-25 14:47:17 -05:00
314e822a84
Merge master into validation
2019-01-25 10:03:40 -05:00
f2f4c2d9c7
Make optional multiCombo fields appear if a value exists ( closes #5764 )
2019-01-25 09:43:07 -05:00
decba8f215
Fix cycleway field to appear if "cycleway" tag present but not "cycleway:left" nor "cycleway:right" ( close #5756 )
2019-01-25 08:39:15 -05:00
33ae009936
Clarify wording of old_multipolygon issue and tooltip
...
Add quick fix for old_multipolygon issue
2019-01-24 11:01:41 -05:00
01e2370cbd
Add background color to the issue pane list
2019-01-24 08:37:46 -05:00
7b288ef95d
Add basic zoom-to-clicked-issue behavior
2019-01-23 15:25:55 -05:00
e69f2a0389
Merge branch 'master' into validation
2019-01-23 13:15:33 -05:00
fa1edc86a1
Another place where we should delimit name suggestion on en-dash
...
see 20bcfc573
2019-01-23 09:57:43 -05:00
20bcfc5730
Delimit name-suggestion-preset names on en-dash, not hyphen
...
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
2019-01-23 09:44:24 -05:00
4583e2d4d7
Make sure all combo event listeners can handle accept/cancel w/o datum
...
(re: #5637 , re: #5618 )
This can happen if the user enters a value that is not matched to
one of the combo suggestions.
Also make sure to set `this` to the input field. It might not be
already if the event was triggered from a keypress instead of a click.
2019-01-22 23:14:34 -05:00
0c7b9a631e
Improve combobox event handling and avoid overwriting typed data
...
(closes #5722 , re: #5637 , re: #5618 )
dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)
Fix for this coming in next commit.
2019-01-22 22:26:27 -05:00
1323ec3d5a
Map Data and Background panes no longer reload hidden sections
2019-01-21 15:52:58 -05:00
35ac247ff0
Fixes an issue where panel sections wouldn't render when toggled if hidden on page load ( closes #5743 )
2019-01-21 15:22:50 -05:00
a7e713da15
Fixed an issue in the Areas walkthrough chapter where the user could not proceed after adding the Description field
2019-01-21 11:51:25 -05:00
2df39c1dc7
Escape all .s in imagery identifiers, not just the first one
...
(closes #5737 )
2019-01-19 10:53:09 -05:00
1ec5b708fc
Restore default click behaviors on mousedown of a combobox
...
(closes #5732 )
2019-01-18 23:23:35 -05:00
087c38e8fd
Avoid calling changeRole recursively
...
(closes #5731 )
2019-01-18 18:20:47 -05:00
4e3def9ce8
Fix the width of the add-tag and add-relation buttons
...
(closes #5729 )
2019-01-18 13:48:17 -05:00
46beb31e74
Removed extra padding in comboboxes when the caret is hidden
2019-01-18 11:59:40 -05:00
bf2574f4e3
Hide the dropdown arrow in combo fields if there are no suggestions from tagInfo ( closes #5730 )
2019-01-18 11:21:31 -05:00
bc81a62a58
Made the value chips in the Destinations semiCombo field full-width to mimic the layout of highway signs (re: #4178 )
...
The input and combobox caret elements in the multicombo field value list are now wrapped in a li element for consistency
2019-01-18 10:41:51 -05:00
77cfde7913
combo, multiCombo, and semiCombo fields now correctly submit the typed value upon pressing enter/return without deselecting the feature ( closes #5725 )
2019-01-17 15:42:35 -05:00
e37dbbd3e1
Style preset icon fill with building if it has a building_area field
...
These are presets that default to `building=yes` so they should look like
buildings.
2019-01-17 14:28:57 -05:00
90637bdcfa
Fixed an issue where the cycleway field would throw an error when added from the "Add field:" dropdown
2019-01-17 12:32:14 -05:00
9f7ef21e5c
The additional fields dropdown now mixes universal and moreFields and is sorted alphabetically
2019-01-17 11:37:05 -05:00
3e12a85fa1
Merge pull request #5717 from nyurik/wikilink
...
Add wiki links from tag description
2019-01-17 00:10:45 -05:00
a9ac1bda97
Fix issues causing mode/undo/save buttons to be missing disabled style
2019-01-17 00:06:57 -05:00
3caf6eabed
remove non local non en wiki links
2019-01-16 15:00:20 -05:00
54b4a798b1
Localize language name
2019-01-16 14:35:47 -05:00
3fe6c0dbe7
Support more eased transitions, cleanup code
...
(re: #3967 , #5169 , #5407 )
2019-01-16 13:42:32 -05:00
c1049b620b
Merge branch 'master' into validation
2019-01-16 08:57:21 -05:00
460d144c66
Use centerZoomEase for smoother walkthrough transitions
2019-01-16 01:32:15 -05:00
Quincy Morgan