94f89f67c2
Adjacent segments should only be nope'd on the active (drawing) way
...
(closes #4713 )
2018-01-20 00:09:04 -05:00
3838b02739
Add detect.cssfilters, fallback to opacity only on IE11/Edge
...
(re: #4711 )
2018-01-19 17:28:35 -05:00
b0cba113e9
Fix directional vertices on IE11/Edge
...
(closes #4710 )
2018-01-19 20:32:45 +00:00
467de651f7
Guard code from 9b99115b3 needs to be in undo_redo.js too
2018-01-19 13:49:20 -05:00
835d45ed6d
Never let mouseCoordinates return NaN (fallback to map center)
2018-01-19 11:53:14 -05:00
9b99115b3e
Guard code for context.mode
...
In case this is somehow called before initialization is complete
It happens rarely when restoring the initial changes and deferring rendering
2018-01-19 11:44:14 -05:00
1cfda3ec86
Only store zoomPan event in mousemove if it has a source event
...
(closes #4706 )
d3 transitioned events don't have a source event,
causing mousemove to go null
2018-01-19 11:42:18 -05:00
1697c48360
Fix flickering and drag-node breakage in line endpoint walkthrough step
2018-01-18 22:02:56 -05:00
efc2678610
Fix feature list / current view searching
...
(closes #4690 )
2018-01-18 17:55:14 -05:00
44234ede66
Make Help pane slightly wider
...
(re: "claustrophobia" on #4651 , #4686 )
2018-01-18 17:31:26 -05:00
40dc938580
Merge pull request #4693 from openstreetmap/doubled_back_routes
...
Fixes for joining and splitting bugs
2018-01-18 17:01:38 -05:00
7c918ba161
Allow Relation.replaceMember to optionally preserve duplicates
...
(closes #4696 )
2018-01-18 16:52:23 -05:00
be9bbd9271
Add tests for member ordering: node, way, relation
2018-01-18 15:21:38 -05:00
8f9a46b75a
Change actionAddMember to rearrange indexed members in place
...
This allows it to work around issues where a relation may
not be completely downloaded
2018-01-17 22:59:55 -05:00
8c9a0eb2c1
Fix doubleclick on line to create a point
...
(closes #4691 )
2018-01-17 09:23:09 -05:00
be46e85ec0
Move insert way pairing code from osmJoinWays to actionAddMember
...
(tests for actionAddMember now passing!)
2018-01-16 17:41:14 -05:00
221158e918
WIP: Add insertHint to actionAddMember, actionSplit
2018-01-15 23:13:59 -05:00
03fa6e7be9
Add tryInsert option to osmJoinWays
2018-01-15 22:02:43 -05:00
dd0a88c245
fix failing npm test
2018-01-15 11:17:51 +01:00
0382ce7d4b
Updated function doc
2018-01-14 21:45:25 -05:00
33817af2b7
Describe relation in tooltip in add membership list
2018-01-14 13:19:35 -08:00
075b85c81d
Apply reversal actions in actionJoin
...
(closes #4688 )
2018-01-14 14:49:57 -05:00
8dbb6eb20c
Return reversal actions performed by osmJoinWays
...
(see #4688 )
2018-01-13 01:45:46 -05:00
0fd801d750
Prefer to join member ways in a way that preserves their order
...
(re #4589 )
Strongly prefer to generate a forward path that preserves the order
of the members array. For multipolygons and most relations, member
order does not matter - but for routes, it does. If we started this
sequence backwards (i.e. next member way attaches to the start node
and not the end node), reverse the initial way before continuing.
2018-01-12 17:23:56 -05:00
c796a9de12
Increase GPX labels readability
2018-01-10 15:42:56 +01:00
f0a27bc1ec
Simplify way segmentation and fix bug with adjacent segment type
...
(closes #4669 )
Now instead of creating MultiLineString targets, we just create a bunch of
LineString targets. This makes the code simpler, and anyway the entity is
still there in `properties` for drawing code to decide what to do with the target.
Incidentally, this change allows iD to support an extrusion operation.
(Because each way segment has its own unique GeoJSON target now)
2018-01-09 10:12:29 -05:00
ea7339f49a
Fixed geometry type word order
...
In many languages, the word for “closed” would follow the word for “line” or “area”, not precede it. Additionally, the word for “closed” may differ depending on what it modifies.
2018-01-09 03:30:14 -08:00
702e3d2a90
DMS coordinates
2018-01-09 03:25:55 -08:00
fe8c218fb3
Localized geocoded coordinate formatting
2018-01-09 02:24:03 -08:00
a1e0d4fc08
Consolidated unit formatting into util module
2018-01-09 02:00:44 -08:00
d75aa7d04a
Internationalized measurement panel
2018-01-09 00:58:58 -08:00
bc5cbc7dfd
Generalized unit keys
2018-01-09 00:13:49 -08:00
1d8d7a74a3
Made scale legend localizable
2018-01-09 00:10:19 -08:00
e661281e38
Prevent self intersecting lines without a junction node
...
(closes #4646 )
2018-01-08 19:17:50 -05:00
49eb46fefb
Add epsilon parameter to geoVecEqual
2018-01-08 17:04:56 -05:00
ea9643e08b
Allow Alt/option key to disable geometry check and nope cursor
...
(re: #4646 )
2018-01-08 15:47:29 -05:00
58eaca2aa0
Ignore area closing segment during move when validating geometry
...
(closes #4655 )
2018-01-08 12:09:17 -05:00
8472f99347
Zooming out should not exit save mode
...
(closes #4664 )
2018-01-08 09:49:32 -05:00
1b973f3c9b
Be more careful about enter/update selection in conflict resolution ui
...
This fixes one of the issues in #4351 where the radio button was not
selected. This was likely introduced during the upgrade to d3 v4, now
that enter selections do not automatically flow into update anymore.
(the fix is to add a `merge` to ensure that the `selection.each` actually
has some things to iterate over)
2018-01-07 23:46:54 -05:00
590487d237
Fix escape keybind when conflicts ui is active
...
(re: 4351)
2018-01-06 23:16:48 -05:00
a22cfe64b8
Avoid loading circular relations by storing ids in _loaded object
...
(re: #3056 )
2018-01-06 00:30:26 -05:00
ac86869b4a
Add conflict checking progress, guard code for user authentication
2018-01-05 18:11:49 -05:00
a63c4a72fe
Improvements to save flow
...
- Attempt fast save first, only perform conflict resolution if necessary (re: #3056 )
- Block reentry of save, and dont keep focus on save button (closes #4641 )
- Refactor modeSave() for code clarity (avoid shared state in closure variables)
2018-01-05 15:11:44 -05:00
437893ebb8
Don't reenter putChangeset, allow reuse of open changeset id
...
We are going to start trying an opportunistic save, then only
start the conflict resolution stuff if the server returns a 409.
Reusing an already open changeset makes sense in this situation.
2018-01-04 23:27:00 -05:00
8914d1ce36
Variable cleanups and formatting
2018-01-04 16:13:13 -05:00
286c09366a
Remove unused var (eslint)
2018-01-04 15:55:53 -05:00
b2eb982044
Add support for oneway alternating/reversible to oneway check fields
...
Also allow checkbox field to display non-standard values
(i.e. not 'yes' or 'no) in the field label
2018-01-04 13:41:35 -05:00
c908807f64
Render oneway=alternating, oneway=reversible with dual arrows
...
(closes #4291 )
2018-01-04 13:40:49 -05:00
1111c6b0c1
Fallback to event.keyCode if event.key is outside ISO-Latin-1
...
(closes #4618 )
2018-01-03 23:37:35 -05:00
99a21d1117
Render points as vertices at zoom >= 18 (was > 18)
...
(closes #4642 )
2018-01-03 16:52:29 -05:00
Bryan Housel