Commit Graph

2154 Commits

Author SHA1 Message Date
Quincy Morgan
5e586419fa Remove unnecessary float styles and cleanup CSS in the preset list 2019-02-12 16:29:52 -05:00
Quincy Morgan
82f6bd73ae Account for all tags added upon choosing a preset, not just those in the preset's tags property 2019-02-12 15:16:02 -05:00
Quincy Morgan
2efe2adec9 Restore previous behavior of features hidden and autoHidden but accounting for 0 count features 2019-02-12 15:05:02 -05:00
Quincy Morgan
9007ccb8fd Disable preset buttons for hidden layers 2019-02-12 14:43:04 -05:00
Quincy Morgan
19e262643d Fix issue where "other" ways were not sorted into the "other" category for hiding purposes 2019-02-11 13:38:37 -05:00
Quincy Morgan
e1da28bcd6 Hide lines that are members of boundary relations when boundaries are hidden (close #5601) 2019-02-11 13:22:20 -05:00
Bryan Housel
151e2685d4 Force selectedIDs to be visible
(re: #5880)
2019-02-11 10:01:54 -05:00
Quincy Morgan
11dc86ca9b Add check for entity geometry type in allowsVertex function (re: #5875) 2019-02-11 09:59:43 -05:00
Bryan Housel
ba44c80076 Force visible any entities related to a selected error
(closes #5880)
2019-02-10 23:29:49 -05:00
Bryan Housel
6e45796be7 Merge pull request #5875 from openstreetmap/dont-snap-non-vertices
Dont snap to non-vertices
2019-02-10 22:13:09 -05:00
Bryan Housel
26368522c9 Batch changes from raw tag editor so blur/remove tag don't conflict
(closes #5878)
2019-02-10 22:08:13 -05:00
Bryan Housel
d64a4c5654 Don't pan map when resizing sidebar on right-to-left layout
(closes #5881)
2019-02-09 15:48:55 -05:00
Bryan Housel
d055f34be8 Add sitelinks to result from wikidata getDocs 2019-02-09 15:18:32 -05:00
Bryan Housel
29ce6cb30c Use proper errbacks
(re: #5823)
2019-02-09 14:51:37 -05:00
SilentSpike
24022416cb Fix negative number of trips in ImproveOSM issues
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
Bryan Housel
a2b140e92b Remove unnecessary ternary 2019-02-08 16:38:40 -05:00
Bryan Housel
fbe584c7ec Lookup docs for some presets on wikidata, not wikibase
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
Bryan Housel
2a7fec46fe Fetch somewhat higher resolution images
(100x100 was really too small)
2019-02-08 13:36:39 -05:00
Bryan Housel
b050c2f442 Avoid keeping focus on the documentation lookup button 2019-02-08 13:34:29 -05:00
Bryan Housel
32c42073c6 Add support for Relation type documentation lookups from wikibase
(closes #5860)
2019-02-08 13:24:58 -05:00
Bryan Housel
e0459279bb Move implementation details from uiTagReference to wikibase service 2019-02-08 12:08:36 -05:00
Bryan Housel
71f2bd5900 Fix key sorting between hover/select
(this is a better fix for #5857)
2019-02-08 09:37:51 -05:00
Bryan Housel
a363f5175f Fix tabbing beyond last row of raw tag editor in Firefox
(closes #5847)

- removed the stopPropagation from the combobox keydown handler
  to make sure that the raw_tag_editor keydown handler will run

- increased timeout from 1ms to 10ms for Firefox
  This is related to Firefox's newish time budgeting approach that they
  started using around Firefox 55.  As a result, very fast timers (<4ms?)
  may run synchronously instead of yielding and running asynchronously
  https://blog.wanderview.com/blog/2017/03/13/firefox-52-settimeout-changes/

  (note similar code in ui/fields/combo.js to delay focus changes and
  redraws 10ms after the tag changes and other events have completed)
2019-02-07 15:56:49 -05:00
Bryan Housel
02790fcc5c Also make sure you can delete the new row in the raw tag editor
(re #5840)
2019-02-07 15:04:16 -05:00
Bryan Housel
2aa409d5a9 Fix crash when deleting rows in raw tag editor
(closes #5840)

This didn't always trigger a crash, but it can.  It attempted to remove the
row containing the key/value input fields, however this ilne is unnecessary
because the change event will trigger a redraw and d3 will handle the removing
milliseconds later.
2019-02-07 14:10:04 -05:00
Bryan Housel
d2735ab40c Fix misspelling 2019-02-07 13:41:06 -05:00
Bryan Housel
3875ea565b Remove mvt querystring parameter that we never used 2019-02-07 10:48:19 -05:00
Bryan Housel
bb0a47b255 Remove kr and keepRight for styles used generically
(it was weird to see these classes in improveOSM components)
2019-02-07 10:35:50 -05:00
Bryan Housel
f4b9abe474 Merge pull request #5867 from SilentSpike/iOSM-comments
Add comments to ImproveOSM issues
2019-02-07 09:46:57 -05:00
Bryan Housel
ce3b33e374 Add style for golf walking paths and cartpaths
Also
- use field inheritance to simplify presets
- rename multipurpose to "Golf Cartpath / Service Road"
  (I think users would understand this better)
- add `maxspeed` to "Golf Cartpath / Service Road"
2019-02-06 21:56:22 -05:00
Quincy Morgan
a702281fb6 Add "remove" tooltip to raw tag editor remove button 2019-02-06 15:56:12 -05:00
Bryan Housel
e0a41656a1 Allow value to be entered before key in raw tag editor
(closes #5872)

This commit also hardens the 'key=value' splitting behavior to actually
check the split result length and avoid overwriting a readonly key
(re: #5024)
2019-02-06 15:03:03 -05:00
Bryan Housel
640730d38b Change focus to existing key instead of suffixing it with _1
(re: #3625, re: #2896)
2019-02-06 10:29:09 -05:00
SilentSpike
a566d58f81 Fix error on ImproveOSM issues with no comments 2019-02-05 21:48:06 +00:00
SilentSpike
0346d8060f Retrieve ImproveOSM comments only once
This additionally fixes the comment box not clearing on submission as I
wasn't updating the error in the cache (to remove the newComment
property).
2019-02-05 21:46:17 +00:00
Bryan Housel
b87ae4e98b Exclude existing keys from auto-completion in raw tag editor
(closes #3625)
2019-02-05 16:14:18 -05:00
SilentSpike
78111955dd Fix user URL on ImproveOSM comments 2019-02-05 21:06:19 +00:00
SilentSpike
c095600635 Use more appropriate new comment header string 2019-02-05 20:44:04 +00:00
SilentSpike
5fc87fb0a4 Pacify eslint
(I really need to start running npm test more often before pushing)
2019-02-05 20:23:02 +00:00
SilentSpike
f7bef29b92 Fix date conversion on ImproveOSM comments 2019-02-05 20:03:55 +00:00
SilentSpike
fa87ed75ae Display ImproveOSM comments oldest to newest 2019-02-05 19:57:22 +00:00
SilentSpike
2c7b689b47 Add comments display to ImproveOSM issues 2019-02-05 19:52:44 +00:00
Bryan Housel
51af1f3b13 Don't re-sort the keys in the raw tag editor when tabbing
(closes #5857)
2019-02-05 14:52:13 -05:00
SilentSpike
28bb12b7ae Add function to retrieve ImproveOSM comments
Just need to have the UI make this call and use the data next.
2019-02-05 19:31:30 +00:00
SilentSpike
448119324f Add ability to comment on ImproveOSM issues 2019-02-05 17:11:37 +00:00
Bryan Housel
e71eddd138 Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify 2019-02-05 10:41:08 -05:00
SilentSpike
b55830485d Fix use of old variable name 2019-02-04 22:55:47 +00:00
SilentSpike
781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
SilentSpike
ddf44377e8 Fix errors without templates not working 2019-02-04 18:12:21 +00:00
Bryan Housel
7fe0380d7d Make sure icon fill colors can be overridden 2019-02-04 13:01:35 -05:00