Commit Graph

4197 Commits

Author SHA1 Message Date
Milos Brzakovic
b0e3c3c56b Merge pull request #8627 from openstreetmap/nsi_route_master
Treat route_master relations like route relations for matching to NSI
2021-08-09 19:27:38 +02:00
Milos Brzakovic
d0577b0364 Merge pull request #8626 from openstreetmap/validator
Validator improvements
2021-08-09 18:07:01 +02:00
Bryan Housel
0f913113c7 Match a 'route_master' as if it were a 'route'
This code just treats `type=route_master` relations as if they were `type=route`
so they will match the transit networks in NSI.

(closes https://github.com/osmlab/name-suggestion-index/issues/5184)
2021-08-05 22:05:11 -04:00
Bryan Housel
15ee63e875 Improve code for keeping only interesting key/value pairs
Before it was not actually checking that the osmvalue was in the vmap,
so we were testing a bunch of pairs like `highway/crossing` and
`highway/residential` that would never match a NSI category.
2021-08-05 16:59:07 -04:00
Bryan Housel
a46a345647 Only expand a validation set to include parent multipolygon relations
The previous code was grabbing _all_ parent relations, which is too much.
For example: if a user changed a road, the validator was treating it like
the user had changed bus and highway routes along that road.

(closes #8613)
(helps a lot #8612)
2021-08-05 14:49:14 -04:00
Bryan Housel
3b0a850400 If undo'd back to the base graph, don't show head issues as user issues 2021-08-05 12:47:52 -04:00
Bryan Housel
9f58f1fb5c Improve code for focusing a validation issue on a relation
The "center" of the issue might be a spot of map that doesn't contain the relation.
This code chooses a piece of the relation that has been downloaded and focuses on that.
2021-08-05 12:47:40 -04:00
Milos Brzakovic
c8aedcbb79 minor trailing spaces 2021-08-05 18:36:25 +02:00
Milos Brzakovic
bc0c1895f7 bing imagery fallback url template update 2021-08-05 18:17:58 +02:00
Milos Brzakovic
3d24736b8f trailing spaces 2021-08-05 17:36:48 +02:00
Milos Brzakovic
750b4e023f crossing_ways fixing - specially handle crossing nodes 2021-08-05 14:50:38 +02:00
Milos Brzakovic
021d777c9d changelog instead of ideditor.blog 2021-08-03 20:02:37 +02:00
Bryan Housel
0085c41876 Store whether a result is provisional before filtering it
Filtering returns a new array, which was clobbering the "provisional" flag.
This was causing provisionally results to not be reprocessed later,
which meant that certain "outdated_tags" results would not be in the baseCache.
(cache of issues _before_ user edits).
2021-08-02 17:15:25 -04:00
Bryan Housel
857b9c9adf Exclude 'fixme'/'help_request' warnings from changeset tags.
They still appear in the issue list and in the entity editor.
(closes #8603)
2021-08-02 14:34:18 -04:00
Bryan Housel
1d5c8253be NSI matcher shouldn't treat old_name like a name tag
(closes #8617)
2021-08-02 12:21:34 -04:00
Bryan Housel
bd97df6aac In general, preserve existing values for tags that can be toplevel
We'll only _replace_ the tag value if this tag is the toplevel/defining tag for the matched item (`k`)
(closes #8615)
2021-08-02 12:07:13 -04:00
Milos Brzakovic
c6df2a0a6c Set development version number 2021-07-23 16:30:56 +02:00
Milos Brzakovic
33a012e007 v2.20.0 2021-07-23 15:53:43 +02:00
Milos Brzakovic
f9804bd1ca Small reverting on bing imagery api
- Reasoning: concern on traffic amount for p2/josm key
- next release will resolve this properly
2021-07-22 19:03:19 +02:00
Milos Brzakovic
416799ceb6 selectChild as standalone.
Keyboard shortcuts new section - way selected
Moved 'help' section to left in keyboard section
2021-07-14 17:43:54 +02:00
Milos Brzakovic
c8f162b8f0 select - differentiate parent/child selection
introduce more accessible shortcuts
2021-07-13 19:51:32 +02:00
Milos Brzakovic
49abb78251 bing imagery template to https 2021-07-12 20:29:57 +02:00
Milos Brzakovic
70a8a1df25 Merge pull request #8570 from openstreetmap/bingImagery-EnsureFreshness
Bing imagery - ensure freshness
2021-07-12 18:56:03 +02:00
Milos Brzakovic
a64e49b064 small fix - whitespace 2021-07-12 18:44:22 +02:00
Milos Brzakovic
b135da504d oci v5.1 + get package version for file_fetcher 2021-07-08 20:05:29 +02:00
Milos Brzakovic
c248aece7b typo 2021-07-07 20:57:54 +02:00
Milos Brzakovic
887938c406 some bing imagery docs comments 2021-07-07 20:56:04 +02:00
Milos Brzakovic
81ce43e055 minor revert catch log 2021-07-07 19:23:20 +02:00
Milos Brzakovic (E-Search)
3f9fee0c05 Merge branch 'develop' into validation_queryparams_conflict_resolve 2021-07-06 19:07:07 +02:00
Milos Brzakovic (E-Search)
358335cf4e bingImagery strict n param.
Fallback url tempalate to latest
2021-07-05 14:06:57 +02:00
Milos Brzakovic (E-Search)
d2036996e3 Merge conflicts resolved 2021-07-05 10:26:44 +02:00
Milos Brzakovic (E-Search)
2d2ec4a9c3 Bing imagery - Ensure freshness 2021-07-02 17:25:07 +02:00
Bryan Housel
ba016762ca Remove unnecessary context argument 2021-07-02 10:32:45 -04:00
Bryan Housel
8db1c1f7f5 Construct URL to match version number that package.json has
https://github.com/openstreetmap/iD/pull/8305#discussion_r663037548
2021-07-02 10:27:50 -04:00
Bryan Housel
bfb36d572d If locationSet is missing include, default to worldwide include
https://github.com/openstreetmap/iD/pull/8305#discussion_r662344647
2021-07-02 10:03:44 -04:00
Nikola Pleša
eba6fe056c Bring map map feature tooltips 2021-06-29 11:54:02 +02:00
Nikola Pleša
8e46b1b141 Remove unused map feature title 2021-06-28 15:26:20 +02:00
Nikola Pleša
6a35533147 Merge develop into mapillary-vector-tiles 2021-06-25 13:07:05 +02:00
Bryan Housel
896d14ba80 Upgrade to name-suggestion-index v6
Also bump country-coder and location-conflation
2021-06-24 16:41:50 -04:00
Milos Brzakovic
7cb2ff7f54 Merge pull request #8442 from openstreetmap/8441-move-rotate
In move/rotate cancel, check whether graph has changed before popping
2021-06-22 11:15:56 +02:00
Milos Brzakovic
70b95e4fc8 Merge pull request #8341 from jleedev/fix-centroid
Fix centroid calculation in measurement panel.
2021-06-21 19:47:46 +02:00
Milos Brzakovic
83509f98de Merge pull request #8473 from mbrzakovic/8472-crossEditableZoom
CrossEditableZoom event firing fix - Use fresh zoom level value to determine if event should be fired
2021-06-21 16:54:22 +02:00
Nikola Pleša
d8670ac383 Remove debugging code 2021-06-15 10:56:55 +02:00
Nikola Pleša
87a823f093 Fix traffic sign rendering and geometry conversion 2021-06-15 10:56:08 +02:00
Nikola Pleša
7a0d8adb7b Switch to Mapillary API v4 2021-06-15 10:13:07 +02:00
Bryan Housel
42f286b064 Switch to osm-community-index v4.0.0 2021-04-30 15:57:15 -04:00
Bryan Housel
b47952b369 Move the complicated linkification code from iD to resolveStrings
It's easier to insert the links there, and then the HTML strings are availble for anyone who wants them
2021-04-30 11:26:24 -04:00
Bryan Housel
25bf950458 Upgrade to osm-community-index (oci) v4
The main differences here is:
- oci now supports default strings and exports a "resolveStrings" function
- this makes linkifying any urls embedded in descriptions a bit more complicated
  because urls and descriptions might need resolution, we can't use iD's normal
  t() function to do the token replacement like before
2021-04-29 17:53:53 -04:00
Milos Brzakovic (E-Search)
92a9ef2061 Move CrossEditableZoom event firing.
It should happen after projection is transformed.
2021-04-27 14:10:13 +02:00
Bryan Housel
2651e7ddc9 In move/rotate cancel, check whether graph has changed before popping
(closes #8441)
2021-04-02 09:48:41 -04:00