CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 17:52:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,487 Commits 2 Branches 0 Tags
6849a2fb41d577d574a380cc4fd699a67e1ff1e3
Commit Graph

2845 Commits

Author SHA1 Message Date
Quincy Morgan
3a78cf512c Move connect ways fix to its own function 
Make the edges and connection tags part of the crossing ways issue ID
 2019-05-08 10:32:25 -04:00
Bryan Housel
41f3bb9c07 Only include relation members that are visible, if extent supplied 
followup to b0d5f0dd4
 2019-05-08 09:23:04 -04:00
Bryan Housel
b0d5f0dd48 Include multipolygon members in complete() 
(closes #3613)
 2019-05-08 00:49:33 -04:00
Bryan Housel
289c75fee1 When showing tooltip, update disabled in case disabled states disagree 
(closes #6296)
 2019-05-07 17:53:22 -04:00
Bryan Housel
58cae43b9b Use parentNode instead of parentElement for IE 2019-05-07 17:48:56 -04:00
Quincy Morgan
3d9f7244f0 Update issue messages after merge instead of by invalidating issues 2019-05-07 16:38:08 -04:00
Quincy Morgan
73467d53b4 Don't flag highways connected to amenity=parking_entrance nodes as disconnected 
Don't flag oneways with entrance endpoints as impossible
 2019-05-07 14:55:57 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Quincy Morgan
5160754dcc Display issues for disabled rules in the commit UI 
Allow errors for disabled rules to block upload
Include warnings for disabled rules in the changeset tags (re: #6325)
 2019-05-07 13:07:31 -04:00
Quincy Morgan
4a379480ad Merge branch 'master' of https://github.com/openstreetmap/iD 2019-05-07 12:29:11 -04:00
Quincy Morgan
fd35e10aa7 Make the very close nodes validation work for any way (close #6326) 2019-05-07 12:28:59 -04:00
Bryan Housel
901cab57da Remove _disabled caches for operations 
(re: #6296, reverts 81127d7)
see https://github.com/openstreetmap/iD/issues/6296#issuecomment-489259027
(I'll find another way to deal with the menu not matching the tooltip)
 2019-05-07 10:32:12 -04:00
Bryan Housel
d3a53309b7 Allow uppercase taginfo results for _ref tags 
(closes #6324)
 2019-05-07 09:32:13 -04:00
Bryan Housel
966f5c3586 Add explicit validation calls to each operation 
This is cleaner than adding hooks to transitionable actions, or performing validation
on every history change.  We want validation to run after each operation, but not
while the user is drawing lines or typing in fields.
 2019-05-06 14:49:46 -04:00
Bryan Housel
7551dd9093 fix typo 2019-05-06 13:04:00 -04:00
Bryan Housel
e3ea4b8484 Additional improvements to unsquare_way validation 
(re: #6288)

- use default params for actionOrthogonalize, not relaxed epsilon
- only allow autofix if there are no extra tags on the building (e.g. source)
 2019-05-06 12:58:40 -04:00
Bryan Housel
4608e9598c Adjust thresholds for unsquare_way detection 
(re: #6288)

I'd like to keep the angle threshold the same as what the action does
for UI consistency, but use a larger epsilon, so that fewer nearly-orthogonal
errors are reported.

With previous constants, it was strange that very orthogonal buildings
were being flagged, and very not-orthogonal buildings were not.
 2019-05-06 11:42:57 -04:00
Bryan Housel
59c34e2537 Perform orthagonalization fixes without a transition 
We can just set `action.transitionable = false` to make the action instant.
Also removes the `onCompletion` handlers. They shouldn't really be needed,
because the validator will run after the fix is applied (and at other times).
 2019-05-06 10:23:30 -04:00
Bryan Housel
77801a3ecd Merge pull request #6284 from Bonkles/id-5869 
Improve validation for disconnected highways #5869
 2019-05-05 22:17:12 -04:00
Bryan Housel
659240d9fa Disclosure should unhide before rendering content 
(closes #6312)

In case something in the content can't cope with `display: none`
 2019-05-05 15:56:56 -04:00
Bryan Housel
8f9dc7afb4 Improve localization of "Thank you for editing the map around.." 
(closes #6269)
 2019-05-04 13:24:46 -04:00
Quincy Morgan
e71470acf6 Remove disabled state cacheing for the delete operation 2019-05-03 13:31:28 -07:00
Quincy Morgan
a772808e04 Remove cacheing of disabled state for certain operations to avoid stale state (close #6296) 2019-05-03 13:23:24 -07:00
Quincy Morgan
4afd071a00 Add "Connect this feature" fix to disconnected ways if continuing drawing isn't possible 2019-05-03 12:59:18 -07:00
Quincy Morgan
dbc3978d71 Add non-actionable fix recommendation to move very close points apart 2019-05-03 12:15:26 -07:00
Bryan Housel
ddc9d16b62 Merge pull request #6302 from openstreetmap/text-raw-tag-editor 
Text raw tag editor / Copy-paste tags
 2019-05-03 14:53:08 -04:00
Bryan Housel
16ec25753d Support escaping of tricky characters, support quoted strings 
keys or values can be quoted or unquoted:
- leisure=park
- leisure="park"
- "leisure"=park
- "leisure"="park"
 2019-05-03 14:42:35 -04:00
Quincy Morgan
cc85897348 Fix map pane animation on RTL layout (close #6290) 2019-05-03 11:05:10 -07:00
Quincy Morgan
b1d00db874 Show very close node issues on the parent way as well as on the points themselves (close #6304) 2019-05-03 10:40:12 -07:00
Bryan Housel
22b7e03d3b Disable spellcheck in the tag textarea 2019-05-03 10:39:38 -04:00
Bryan Housel
8a4e822fd7 If All Fields section is hidden, focus textarea and put cursor at end 2019-05-03 10:33:50 -04:00
Bryan Housel
fbe5389ecb Set textarea height to fit content 2019-05-03 10:14:53 -04:00
Bryan Housel
c95860f36d Convert changes in the textarea back to tag changes 2019-05-02 23:01:33 -04:00
Bryan Housel
7b4a9a43b0 Change utilTagDiff to return an object with details 2019-05-02 22:59:41 -04:00
Quincy Morgan
672966426f Merge branch 'master' of https://github.com/openstreetmap/iD 2019-05-02 16:26:48 -07:00
Quincy Morgan
bfc944e30a Fix two potential exceptions and one lint warning 2019-05-02 16:26:33 -07:00
Bryan Housel
ff1eea43a8 Remove Google Analytics, also actually export iD.utilDetect 2019-05-02 19:12:39 -04:00
Quincy Morgan
ba9fd58fa9 Don't flag roads connected only to ferry routes as disconnected (close #6287) 
Use common routable highway tag list for disconnected way check
 2019-05-02 14:49:27 -07:00
Quincy Morgan
0a71fd1e4f Fix false positive for impossible oneway when connected way is circular 2019-05-02 12:18:21 -07:00
Quincy Morgan
752bc72e7c Fix issue where close nodes validation may not detect issues in some cases 2019-05-02 12:03:09 -07:00
Quincy Morgan
424f6ca72d Don't skip other validations even if there are missing tag issues 2019-05-02 11:51:01 -07:00
Quincy Morgan
b4dacdad2a Reduce very close nodes validation threshold (close #6292) 
Use spherical distances for very close nodes validation
Don't flag very close nodes from different ways
Don't flag very close nodes if both have interesting tags
Update very close nodes validation reference string
 2019-05-02 11:39:12 -07:00
Bryan Housel
61819058d3 Avoid frequent reflow from setting scrollTop 
(possibly re: #6289)
 2019-05-02 14:21:57 -04:00
Bryan Housel
b17e4e4f1d Add 'list'/'text' toggle buttons 2019-05-02 13:49:26 -04:00
Bryan Housel
cebe4ced8a Preserve user's preference for 'list'/'text' view for the raw tag editor 2019-05-02 11:17:06 -04:00
Bryan Housel
ed9a436318 Move common tag diffing code from validators into utilTagDiff 2019-05-02 11:16:15 -04:00
Bryan Housel
af97f09150 Remove "key=value" pasting into raw tag editor key 
(Reverts: #6211, #5070, #5024)

The old code allows users to circumvent the readonly tag protection
see https://github.com/openstreetmap/iD/issues/6185#issuecomment-488692351

We'll offer a text-mode instead, with stricter checks on which keys can be modified.
 2019-05-02 10:22:37 -04:00
Quincy Morgan
d061ec6b61 Don't add ignore fix more than once 
Tweak hidden issues text
 2019-05-01 20:21:47 -07:00
Quincy Morgan
a180c794cb Merge branch 'master' into ignoring-issues 2019-05-01 20:13:49 -07:00
Quincy Morgan
712f8bcb03 Avoid having hidden issues strings for both singular and multiple variations 2019-05-01 20:13:09 -07:00