Commit Graph

10495 Commits

Author SHA1 Message Date
Bryan Housel
6a560861b2 Add notification badge to Issue pane icon 2019-02-13 16:56:17 -05:00
Bryan Housel
5bca360f50 Don't show the entity_issues section if there are no issues
(I think it worked this way before)
2019-02-13 13:57:46 -05:00
Bryan Housel
c292a32a66 Better message padding, remove double tooltip 2019-02-13 13:47:00 -05:00
Bryan Housel
c4fe42653a s/coordinates/loc and replace legacy names in tests
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Bryan Housel
448fe498bd Only recenter view if necessary, select after delay, fix maprules type 2019-02-12 17:25:54 -05:00
Bryan Housel
14896b0ce5 Documentation, and move validation type up to top of each file 2019-02-12 16:07:08 -05:00
Bryan Housel
9ebc9a22e9 perf: use Object instead of Array for lookup, cache on osmEntity.key 2019-02-12 14:23:50 -05:00
Bryan Housel
4e6ade08b1 Comment out cache in getIssuesForEntityWithID
It seems like entity editor draws before the validator runs so the
rendered list is often one history change behind.
2019-02-12 00:22:24 -05:00
Bryan Housel
6cb1656cac Animate expand fix menus 2019-02-12 00:00:12 -05:00
Bryan Housel
81bd734849 WIP uiEntityIssues cleanups, simplify
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00
Bryan Housel
f4ccd8a3dc Update issue text/icon on update selection 2019-02-11 16:22:24 -05:00
Quincy Morgan
c8a556697d Remove bridge tag deprecation warnings 2019-02-11 15:48:42 -05:00
Quincy Morgan
fffdffead1 Fix deprecated tag replacement key spelling 2019-02-11 14:58:19 -05:00
Quincy Morgan
742e04b363 Alphabetize and update deprecated tags list 2019-02-11 14:55:55 -05:00
Bryan Housel
c083d1d0af More nitpicky code formatting issues
- no multiline var declarations
- avoid lodash unless necessary
- linefeeds for readability
2019-02-11 14:51:21 -05:00
Clarisse Abalos
d457a0a31b Merge remote-tracking branch 'iD/validation' into validation 2019-02-11 14:21:06 -05:00
Clarisse Abalos
aca699ecca add osmose Items 4010 and 3030 to deprecated.json 2019-02-11 14:20:59 -05:00
Bryan Housel
9d58c4d0a2 Alphabetic 2019-02-11 14:11:35 -05:00
Bryan Housel
251a83ff7a Nitpicky code formatting stuff
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
2019-02-11 13:55:58 -05:00
Bryan Housel
a6e05b8ac5 Rename for consistency - these are called "annotations" elsewhere 2019-02-11 13:36:02 -05:00
Bryan Housel
ac23ac8fd2 Periods in non-sentence message headings look strange 2019-02-11 13:30:28 -05:00
Bryan Housel
b34dceeeb1 Tooltips should not receive pointer events
It was possible to scroll through a list of issues quickly and end up
with the mouse over a stale tooltip, then tooltip would not dismiss.
2019-02-11 13:13:26 -05:00
Bryan Housel
70cafda8ba Group issues in a container like fields
(we should probably do this for all the sidebar things)
2019-02-11 13:08:59 -05:00
Bryan Housel
a5ffec5665 utilHighlightEntities accept an array instead of calling it in a loop 2019-02-11 12:40:23 -05:00
Quincy Morgan
0826050b55 Only zoom to the clicked issue in the entity sidebar if it isn't visible 2019-02-11 12:10:57 -05:00
Quincy Morgan
6a9bb2d138 Add crossing tags when connecting paths crossing roads with the quick fix 2019-02-11 12:03:56 -05:00
Quincy Morgan
99e1203d46 Zoom to entity when opening an issue without a specific location in the entity editor 2019-02-11 11:48:21 -05:00
Quincy Morgan
149e1b3e4d Removed unused string 2019-02-11 11:41:18 -05:00
Quincy Morgan
47ec58e5fc Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan
01b0c618d1 Don't highlight the selected entity when hovering over issues in the entity editor 2019-02-11 10:58:47 -05:00
Quincy Morgan
ceee3c1a4b Merge branch 'master' into validation 2019-02-11 10:23:50 -05:00
Bryan Housel
151e2685d4 Force selectedIDs to be visible
(re: #5880)
2019-02-11 10:01:54 -05:00
Quincy Morgan
11dc86ca9b Add check for entity geometry type in allowsVertex function (re: #5875) 2019-02-11 09:59:43 -05:00
Quincy Morgan
83f8cd97f6 Add feature highlighting when hovering over their corresponding issues 2019-02-11 09:45:33 -05:00
Quincy Morgan
db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
Bryan Housel
ba44c80076 Force visible any entities related to a selected error
(closes #5880)
2019-02-10 23:29:49 -05:00
Bryan Housel
6e45796be7 Merge pull request #5875 from openstreetmap/dont-snap-non-vertices
Dont snap to non-vertices
2019-02-10 22:13:09 -05:00
Bryan Housel
26368522c9 Batch changes from raw tag editor so blur/remove tag don't conflict
(closes #5878)
2019-02-10 22:08:13 -05:00
Bryan Housel
d64a4c5654 Don't pan map when resizing sidebar on right-to-left layout
(closes #5881)
2019-02-09 15:48:55 -05:00
Bryan Housel
65fc1437dc Fix wiki image float and margins on rtl layout 2019-02-09 15:30:57 -05:00
Bryan Housel
d055f34be8 Add sitelinks to result from wikidata getDocs 2019-02-09 15:18:32 -05:00
Bryan Housel
29ce6cb30c Use proper errbacks
(re: #5823)
2019-02-09 14:51:37 -05:00
Bryan Housel
fac9c2dadc Merge pull request #5879 from SilentSpike/3rd-party
Fix negative number of trips in ImproveOSM issues
2019-02-09 14:13:32 -05:00
SilentSpike
24022416cb Fix negative number of trips in ImproveOSM issues
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
Bryan Housel
48d001dcb9 Don't capitalize first letter of error message in Persian
(closes #5877, re: #5679)
2019-02-09 10:21:13 -05:00
Bryan Housel
6ff381cb28 Drop "from this key" jargon 2019-02-08 17:01:54 -05:00
Bryan Housel
a2b140e92b Remove unnecessary ternary 2019-02-08 16:38:40 -05:00
Bryan Housel
fbe584c7ec Lookup docs for some presets on wikidata, not wikibase
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
Bryan Housel
2a7fec46fe Fetch somewhat higher resolution images
(100x100 was really too small)
2019-02-08 13:36:39 -05:00
Bryan Housel
b050c2f442 Avoid keeping focus on the documentation lookup button 2019-02-08 13:34:29 -05:00