CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 01:02:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,155 Commits 2 Branches 0 Tags
71b2d2c6b7b08fef8e405fa133c6ca7cf66b8378
Commit Graph

2058 Commits

Author SHA1 Message Date
Bryan Housel
7138acc652 Properly export areaKeys, fix preset and maprules tests 2019-01-30 15:29:37 -05:00
Bryan Housel
17bbc3d5a2 Slightly improve suggestion placement, preset search performance 
- avoid lodash _filter when native filter is ok for arrays
- for suggestions use `originalName` instead of adding/removing the en-dash
- bump up importance of leading suggestions, but do a strict leading search

more on that last point:
For normal presets, we count a string as leading if it follows a space.
e.g. "office" will match "Law Office"
We don't really want this for suggestion presets though
e.g. "bell" should not match "Taco Bell"
 2019-01-29 21:56:23 -05:00
Bryan Housel
7aea67fcfe Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self 
Add check to stop joining ways if resulting way intersects itself
 2019-01-29 14:07:34 -05:00
Bryan Housel
0f41913b04 pacify eslint 2019-01-29 14:04:36 -05:00
Bryan Housel
a2212a732b Merge pull request #5816 from SilentSpike/mapillary-icon 
Fix street imagery hover and selection behaviour
 2019-01-29 13:59:28 -05:00
SilentSpike
20d629ac9e Fix turn:lanes changing when way is reversed 2019-01-29 14:19:35 +00:00
SilentSpike
129c28fb25 Fix street imagery selection highlight persistence 
Root cause was the `select` mode removing the "selected" class from all
elements upon `exit()`. Easy fix is to use a different class (here
"currentView") for street imagery elements.
 2019-01-29 13:26:53 +00:00
SilentSpike
99f7a90387 Fix imagery layers resetting eachother's classes 
Fixes:
- Selecting a bubble then enabling a second imagery layer removes the hovered and selected highlighting
- If multiple imagery layers are enabled and you select a bubble it only temporarily becomes highlighted
- If multiple imagery layers are enabled and a bubble is highlighted, hovering over another imagery layer's bubble will remove the selected and hovered highlighting

Basically these all came down to style updates resetting all layers for
cases other than when the viewport was changed (where doing so makes
sense because the selected bubble/sequence needs to update as a result).

See #5494
 2019-01-29 13:25:47 +00:00
SilentSpike
da41d9d921 Fix mouseover events on imagery layer bubbles 
This is just a minor thing that doesn't usually alter visible behaviour.

The mouseover and mouseout events would fire when moving between child
elements of the svg group which was unnecessary.
 2019-01-29 13:24:01 +00:00
Quincy Morgan
02ccd7cfd6 v2.13.1 2019-01-28 17:38:05 -05:00
Bryan Housel
af8fb1d758 Show combobox if we are moving from a different active combobox 
(closes #5752)

Previously it would go down the `hide()` branch anytime an existing combobox
was active.
 2019-01-28 16:22:37 -05:00
Bryan Housel
49442afe0c In raw member editor, cancel combobox on blur if it hasn't been accepted 2019-01-28 15:41:50 -05:00
Bryan Housel
d0021f77ca Handle possibility of combobox blurring without dispatching accept 2019-01-28 13:43:40 -05:00
Bryan Housel
87ddfa68dc Revert 55715a482 - caused raw_tag_editor combos to not blur in Safari 2019-01-28 11:20:32 -05:00
Quincy Morgan
4ef46a4b1d Fix issue where Chrome would attempt to autofill fields (close #5818) 2019-01-28 11:15:59 -05:00
Quincy Morgan
1066f8f788 Fix issue where preset browser would show after continuing a line (close #5770) 2019-01-28 08:52:20 -05:00
Bryan Housel
b9444ab991 Restore hand cursor on dropdown carat 
(closes #5769)

This change allows pointer events to flow to the caret, and forwards
them back to the combo input.  Also renames several event handlers
for clarity, and increases the double-click detection threshold.
 2019-01-26 13:22:31 -05:00
Bryan Housel
18d71448be pacify eslint 2019-01-25 16:23:46 -05:00
Bryan Housel
5d6e331635 Don't erase name field when tabbing from it 
(closes #5760)
 2019-01-25 16:16:07 -05:00
Bryan Housel
55715a4827 Try to dispatch an accept event on blur 
(re: #5752 - but does not close it)
 2019-01-25 14:47:17 -05:00
Quincy Morgan
f2f4c2d9c7 Make optional multiCombo fields appear if a value exists (closes #5764) 2019-01-25 09:43:07 -05:00
Quincy Morgan
decba8f215 Fix cycleway field to appear if "cycleway" tag present but not "cycleway:left" nor "cycleway:right" (close #5756) 2019-01-25 08:39:15 -05:00
Quincy Morgan
24b6e9aeec v2.13.0 2019-01-23 11:33:23 -05:00
Bryan Housel
a873c0f2ca Remove unused, add maprules documentation 2019-01-23 11:08:19 -05:00
Bryan Housel
fa1edc86a1 Another place where we should delimit name suggestion on en-dash 
see 20bcfc573
 2019-01-23 09:57:43 -05:00
Bryan Housel
20bcfc5730 Delimit name-suggestion-preset names on en-dash, not hyphen 
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
 2019-01-23 09:44:24 -05:00
Bryan Housel
b3953e4a31 Don't mix up inflight tile requests with inflight keepright updates 
(closes #5748)
 2019-01-22 23:20:17 -05:00
Bryan Housel
4583e2d4d7 Make sure all combo event listeners can handle accept/cancel w/o datum 
(re: #5637, re: #5618)

This can happen if the user enters a value that is not matched to
one of the combo suggestions.

Also make sure to set `this` to the input field.  It might not be
already if the event was triggered from a keypress instead of a click.
 2019-01-22 23:14:34 -05:00
Bryan Housel
0c7b9a631e Improve combobox event handling and avoid overwriting typed data 
(closes #5722, re: #5637, re: #5618)

dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)

Fix for this coming in next commit.
 2019-01-22 22:26:27 -05:00
Quincy Morgan
949337249b Improved performance of multipolygon line-as-area rendering check 2019-01-22 14:10:42 -05:00
Quincy Morgan
e83bdbb181 Fixed an issue where non-trivial line components of multipolygons were not rendered as lines 2019-01-22 13:51:44 -05:00
Quincy Morgan
0499a76443 Fixed an entity not found error when restoring new ways that reference unloaded nodes (closed #4108, closed #5194) 2019-01-22 12:56:37 -05:00
J Guthrie
bc430e4926 Fix loop index bug 2019-01-22 14:50:13 +00:00
J Guthrie
274eaa2e47 Fix eslint issue 2019-01-22 14:39:21 +00:00
J Guthrie
6a3a0251d0 Fix bug where end nodes being on top of each other gave false positive 2019-01-22 14:29:45 +00:00
J Guthrie
631ace27d5 Add check to stop joining ways if resulting way intersects itself 
- Includes new test case
 2019-01-22 03:07:38 +00:00
Quincy Morgan
1323ec3d5a Map Data and Background panes no longer reload hidden sections 2019-01-21 15:52:58 -05:00
Quincy Morgan
35ac247ff0 Fixes an issue where panel sections wouldn't render when toggled if hidden on page load (closes #5743) 2019-01-21 15:22:50 -05:00
Quincy Morgan
a7e713da15 Fixed an issue in the Areas walkthrough chapter where the user could not proceed after adding the Description field 2019-01-21 11:51:25 -05:00
Minh Nguyễn
9e3d49efb7 Replace wkid/w/s/n/e in WMS URL templates 2019-01-19 15:42:22 -08:00
Bryan Housel
2df39c1dc7 Escape all .s in imagery identifiers, not just the first one 
(closes #5737)
 2019-01-19 10:53:09 -05:00
Bryan Housel
1ec5b708fc Restore default click behaviors on mousedown of a combobox 
(closes #5732)
 2019-01-18 23:23:35 -05:00
Bryan Housel
087c38e8fd Avoid calling changeRole recursively 
(closes #5731)
 2019-01-18 18:20:47 -05:00
Bryan Housel
4e3def9ce8 Fix the width of the add-tag and add-relation buttons 
(closes #5729)
 2019-01-18 13:48:17 -05:00
Quincy Morgan
46beb31e74 Removed extra padding in comboboxes when the caret is hidden 2019-01-18 11:59:40 -05:00
Quincy Morgan
bf2574f4e3 Hide the dropdown arrow in combo fields if there are no suggestions from tagInfo (closes #5730) 2019-01-18 11:21:31 -05:00
Quincy Morgan
bc81a62a58 Made the value chips in the Destinations semiCombo field full-width to mimic the layout of highway signs (re: #4178) 
The input and combobox caret elements in the multicombo field value list are now wrapped in a li element for consistency
 2019-01-18 10:41:51 -05:00
Quincy Morgan
77cfde7913 combo, multiCombo, and semiCombo fields now correctly submit the typed value upon pressing enter/return without deselecting the feature (closes #5725) 2019-01-17 15:42:35 -05:00
Quincy Morgan
bb4d0a9282 Fixes false error when a preset inherits fields from a preset with no fields 2019-01-17 15:40:42 -05:00
Bryan Housel
e37dbbd3e1 Style preset icon fill with building if it has a building_area field 
These are presets that default to `building=yes` so they should look like
buildings.
 2019-01-17 14:28:57 -05:00