8815b878c5
Fix issue where selected way could not be disconnected if the connection point occurred more than once in the way ( close #6149 )
2019-04-07 12:47:20 -07:00
34792d7fbf
Don't add field defaults when upgrading tags to a specific replacement
2019-04-03 10:57:42 -07:00
cda8f657ac
Swap fast-deep-equal for lodash isEqual
...
(re: #6087 )
2019-03-29 22:17:29 -04:00
3673a7c7e7
Remove lodash cloneDeep
...
(re #6087 )
- some were able to do a different approach
(validations/almost_junction, and settings/*)
- some were replaced with custom speedy cloners
(in orthogonalize clonePoints and osm.js cloneNoteCache)
- some just replaced with JSON.parse(JSON.stringify()))
2019-03-29 17:18:40 -04:00
d5abe468b9
Remove rest of the lodash iterators: map, reduce, forEach
...
(re: #6087 )
2019-03-29 15:14:21 -04:00
3896b2282f
Remove lodash isNaN, isNumber, isString, bind, uniqBy
...
(re: 6087)
2019-03-27 23:11:45 -04:00
3d80e6505f
Remove lodash chunk, groupBy
...
(re: #6087 )
2019-03-27 16:18:41 -04:00
8d210e8adb
Remove lodash indexOf
...
(re: 6087)
2019-03-27 09:45:53 -04:00
5b4aa529de
Replace lodash uniq
...
(re: 6087)
2019-03-27 02:43:25 -04:00
5e1ff74199
Replace lodash difference, intersects, union
...
(re: 6087)
2019-03-27 01:22:11 -04:00
4821bf0a68
Remove lodash omit
...
(re: #6087 )
2019-03-26 14:12:45 -04:00
1ce4f0ad6a
Remove lodash without
...
(re: #6087 )
2019-03-25 21:56:54 -04:00
5280d07bad
Remove lodash reject (re: #6087 )
2019-03-23 12:51:13 -04:00
76e0d13729
Remove lodash every and filter
...
(re: #6087 )
2019-03-23 01:22:56 -04:00
7a6c63fcc5
Remove lodash extend (re: #6087 )
2019-03-23 00:38:39 -04:00
7e6f68a1b2
Remove lodash some
...
(re: #6087 )
2019-03-23 00:07:52 -04:00
0e90167513
Remove lodash clone
...
(re: #6087 )
2019-03-22 23:18:25 -04:00
f6c284a3be
Minor code cleanups, swap some math for existing functions
2019-03-22 15:29:48 -04:00
97dc659b0f
Fixed linting - moved function out of loop
2019-03-22 15:29:48 -04:00
470d6c257d
Update to work on ways going in opposite directions
2019-03-22 15:29:48 -04:00
e786bd54b1
Minor syntax improvement
2019-03-22 15:29:48 -04:00
a3930c35a3
Fixed sort to sort by integer
2019-03-22 15:29:48 -04:00
d07418c654
Enforce either 0 or 2 selected vertices
2019-03-22 15:29:47 -04:00
04da13dae3
Added 2-vertex straighten to actionStraighten
...
- Split selectedIDs between nodes and ways
- Slice the length of nodes to be straighten to between the 2 selected nodes
2019-03-22 15:29:47 -04:00
c28f0a77fe
Implement new functionality
2019-03-22 15:29:47 -04:00
c7e375cbd7
Preserve directionality of sided way when joining to non-sided ways
...
(closes #6033 )
2019-03-21 22:19:05 -04:00
0781b70f38
Add drag-and-drop reordering of relation members ( close #2283 )
2019-03-15 12:22:24 -04:00
93df5d42d9
Flag and upgrade deprecated tags in a semicolon-delimited tag value ( close #6038 )
2019-03-11 10:22:28 -04:00
3f8911c149
Merge pull request #5999 from openstreetmap/squarish
...
Improve orthogonalization action
2019-03-01 23:28:23 -05:00
fab6bd1d33
Support orthogonalizing a single vertex, add tests
...
(closes #2205 )
2019-03-01 23:20:50 -05:00
cb51c16c8f
Expand actionOrthogonalize tests, fix abs issue in canOrthogonalize
2019-03-01 13:45:00 -05:00
b47ab4ac50
Change orthogonalize to support degenerate shapes, non-closed ways
...
Also adds a handful of useful vector math functions to geo module
2019-02-28 22:52:45 -05:00
1f21b029fd
Move tag upgrade fix to an action and add unit tests
2019-02-26 10:42:12 -05:00
e44dfcb5e3
Add geoVecNormalizedDot
2019-02-25 23:07:03 -05:00
c3ac083b32
Reuse math code, add geoVecNormalize, code cleanups
2019-02-25 21:15:20 -05:00
e161db0301
Remove unused deprecate_tags action
2019-02-20 09:05:34 -05:00
b25d75a6cc
Use existing nodes where possible in almost junction connection fix
2019-02-06 12:47:12 -05:00
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
7aea67fcfe
Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self
...
Add check to stop joining ways if resulting way intersects itself
2019-01-29 14:07:34 -05:00
0f41913b04
pacify eslint
2019-01-29 14:04:36 -05:00
20d629ac9e
Fix turn:lanes changing when way is reversed
2019-01-29 14:19:35 +00:00
bc430e4926
Fix loop index bug
2019-01-22 14:50:13 +00:00
274eaa2e47
Fix eslint issue
2019-01-22 14:39:21 +00:00
6a3a0251d0
Fix bug where end nodes being on top of each other gave false positive
2019-01-22 14:29:45 +00:00
631ace27d5
Add check to stop joining ways if resulting way intersects itself
...
- Includes new test case
2019-01-22 03:07:38 +00:00
84f96574d7
Add index property to cloned object, not actual member object
...
(closes #5458 )
This code was adding an `index` property to each member in the relation.
Although the `index` property is ignored by the code that saves to OSM,
the extra property would make the member changed when compared by
`coreDifference`.
2018-12-12 02:07:03 -05:00
ea9e3008a5
addTags() -> setTags() / removeTags() -> unsetTags()
...
This avoids overriding the `addTags` and `removeTags` objects with functions
2018-11-21 12:59:43 -05:00
2e6799ac60
Don't reverse cardinal direction roles on relations anymore
...
re: https://github.com/openstreetmap/iD/pull/2004#issuecomment-407995998
Per thread https://twitter.com/bhousel/status/1025805098063208448
JOSM has stopped doing this too
2018-08-04 21:55:14 -04:00
a406da953d
Remove actionMoveNote
...
Notes aren't stored in the graph, so moving them isn't an action
2018-07-24 14:26:25 -04:00
e1cb25d824
merge from 'master'
2018-07-23 18:24:02 -04:00
Quincy Morgan