CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-03-19 09:33:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,954 Commits 2 Branches 0 Tags
8a6fa241df1b32a4fe32ebd33dfa256b04483c18
Commit Graph

75 Commits

Author SHA1 Message Date
Quincy Morgan
070cfec7c7 Specify that connecting waterways and highways with the fix will add a ford (close #6734) 2019-08-09 09:34:35 -05:00
Quincy Morgan
1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
Quincy Morgan
e599488121 Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374) 
Flag very close nodes in indoor features but with an extremely small threshold
 2019-05-20 11:21:50 -04:00
Quincy Morgan
99565e8457 Don't flag crossing waterways and pier highways 2019-05-14 15:39:04 -04:00
Quincy Morgan
3a78cf512c Move connect ways fix to its own function 
Make the edges and connection tags part of the crossing ways issue ID
 2019-05-08 10:32:25 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Quincy Morgan
a4ebbaf7f5 Don't use the issue loc as a differentiator for all issues 2019-04-30 13:16:03 -07:00
Quincy Morgan
26f1e29072 Merge branch 'master' into ignoring-issues 
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
 2019-04-30 13:05:07 -07:00
Quincy Morgan
9d6b461d0e Apply the crossing tag of the path to the node even if it's not a footpath when connecting crossing ways 2019-04-30 11:53:03 -07:00
Quincy Morgan
07573091ad Don't add a "crossing" tag to ambiguous crossings when connecting crossing ways via the quick fix (re: #6244) 2019-04-30 11:46:15 -07:00
Quincy Morgan
375779882d Add ability to ignore warnings 
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
 2019-04-29 17:52:32 -07:00
Quincy Morgan
ecc217f5d8 Add validation rule to flag impossible oneway highways and waterways (close #6216) 2019-04-26 12:04:43 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
2ebbb68604 Restore tooltips on rule checkboxes, separate 'tip' and 'reference' 
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
 2019-04-19 13:24:55 -04:00
Bryan Housel
01d2e3eaf3 Replace validator tooltip with reference function, add tag diff 2019-04-16 17:07:53 -04:00
Bryan Housel
294ce00211 substitute 'info' for 'data' (so I can use 'info' for an info drawer) 2019-04-15 16:56:21 -04:00
Bryan Housel
6508edf820 Avoid anonymous functions as validators 
Givnig them names makes it easier to understand in the profiler
 2019-04-05 09:50:22 -04:00
Bryan Housel
8b1c0551cc WIP: understand state held by the validator, avoid translations 
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
  (graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
 2019-04-05 09:28:36 -04:00
Quincy Morgan
d5d4323c02 Replace "Use different layers" non-actionable quick fix with actionable quick fixes for setting a higher or lower layer (close #5943) 2019-04-01 11:52:04 -04:00
Quincy Morgan
d075dac2be Add crossing=unmarked when connecting ambiguous crossings highways 2019-03-14 09:46:45 -04:00
Quincy Morgan
5ce788f6a3 Add bus_guideway as whitelisted value for checking crossing highways 2019-03-05 10:06:50 -05:00
Quincy Morgan
604ff29593 Use whitelist instead of blacklist for affected highways in crossing ways validation 2019-03-05 10:01:16 -05:00
Quincy Morgan
7d8453b1fb Remove service road exception for adding highway=crossing during crossing way fix (re: #5976) 2019-02-26 08:12:42 -05:00
Quincy Morgan
7f58454958 Don't tag connection nodes of paths crossing service or track roads as highway=crossing in crossing ways quick fix (re: #5976) 2019-02-25 11:39:03 -05:00
Quincy Morgan
10e73fc15c Explicitly include certain railways for crossing validation instead of excluding some 
Don't flag abandoned or razed railway crossings
 2019-02-21 15:09:13 -05:00
Quincy Morgan
02d3097d8d Fix a cacheing issue 2019-02-21 13:34:51 -05:00
Quincy Morgan
51972ea78f Cache issues in crossing ways validation to avoid checking the same pairs twice 2019-02-21 11:49:31 -05:00
Quincy Morgan
2d6c49b92b Ignore proposed features for crossings ways, almost junction, and disconnected way validations (close #5922) 2019-02-21 10:14:25 -05:00
Quincy Morgan
cdc4557da5 Minor performance improvement in crossing ways by removing use of lodash and avoiding a concat within a reduce 2019-02-20 09:50:53 -05:00
Quincy Morgan
ba68d921fe Add icons for crossing ways fixes and almost junction connection fix 2019-02-20 09:02:05 -05:00
Quincy Morgan
6d397e89c6 Account for waterway bridges and implicit layers in crossing ways validation 2019-02-19 15:28:27 -05:00
Quincy Morgan
f536706763 Refactor crossing ways validation for performance 2019-02-19 14:40:54 -05:00
Quincy Morgan
b766f82cbd Improve crossing ways performance slightly by avoiding clone 2019-02-19 13:25:02 -05:00
Quincy Morgan
12a44421c3 Account for indoor features in crossing ways validation 
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
 2019-02-19 11:43:05 -05:00
Quincy Morgan
66db6f3f2c Make building crossing validation only create one issue per feature pair (re: #5891) 2019-02-18 10:43:19 -05:00
Quincy Morgan
94cb9faaa2 Don't check for self-intersection in the crossing ways validation 2019-02-18 10:16:22 -05:00
Quincy Morgan
7021985aec Don't suggest connection fix for highway-building crossings (re: #5891) 2019-02-18 10:12:47 -05:00
Quincy Morgan
397097ac1f Tweak issue and fix strings 
Different strings for one vs. a combination of deprecated tags
 2019-02-15 14:24:11 -05:00
Quincy Morgan
1821c3e955 Update fixes UI for icons, link styling, and non-actionable fixes 
Fix several bugs
 2019-02-14 15:56:04 -05:00
Bryan Housel
c4fe42653a s/coordinates/loc and replace legacy names in tests 
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
 2019-02-12 21:18:25 -05:00
Bryan Housel
14896b0ce5 Documentation, and move validation type up to top of each file 2019-02-12 16:07:08 -05:00
Bryan Housel
251a83ff7a Nitpicky code formatting stuff 
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
 2019-02-11 13:55:58 -05:00
Bryan Housel
a6e05b8ac5 Rename for consistency - these are called "annotations" elsewhere 2019-02-11 13:36:02 -05:00
Quincy Morgan
6a9bb2d138 Add crossing tags when connecting paths crossing roads with the quick fix 2019-02-11 12:03:56 -05:00
Quincy Morgan
55f71f5a7d Replace Set objects in crossing ways validation 2019-02-08 09:20:41 -05:00
Quincy Morgan
5b8fea9e87 Use existing nodes where possible in the crossing ways connection fix 
Fix a lint warning
 2019-02-06 15:03:29 -05:00
Quincy Morgan
d3946894e8 Standardize deprecated_tag and missing_tag rule type ids 
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
 2019-02-04 16:29:29 -05:00
Quincy Morgan
01c4c46918 Improve crossing ways validation performance by reducing garbage collection 2019-02-04 15:41:22 -05:00
Quincy Morgan
4921a32be1 Improve performance of crossing ways validation 2019-02-04 15:22:07 -05:00
Quincy Morgan
451704ca7b Remove check to see if ways were already checked in the crossing ways validation 2019-02-04 15:07:37 -05:00