Commit Graph

1174 Commits

Author SHA1 Message Date
Bryan Housel
9b200cf514 Code cleanups, changes to replaceMovedVertex in moveAction
Trying to eliminate the minimum 10m distance for replacing the original
junction vertex - this is a small threshold.  When _not_ replacing this
vertex, the unzorro code will wreck havok on a traffic circle.
(If there is no suitable vertex to use, it will snap to a point between
the nearest vertices, see #4146)
2018-01-28 23:56:03 -05:00
Bryan Housel
f54d201eb2 Stop sequence from playing when the Mapillary viewer is hidden
(closes #4707)
2018-01-26 16:59:32 -05:00
Bryan Housel
db2d165a17 Support fallback mode for Mapillary when WebGL disabled
(closes #3804)
2018-01-26 16:27:48 -05:00
Bryan Housel
9ebf3b11a4 Don't initialize Mapillary viewer with a key
(closes #4536)

This avoids binding the viewer to an image key that might not be
fully processed, which gets the viewer into a bad state.

Instead, we initialize the viewer with a `null` image key and
issue `moveToKey` immediately.

This commit also adds exception handling for moveToKey.
2018-01-26 15:45:53 -05:00
Bryan Housel
db96246ddf Create fake entities for nominatim serach results, so they can be localized
(closes #4725)
2018-01-26 00:41:04 -05:00
Bryan Housel
d5bf2d9762 Add geoHasLineIntersections, better for testing multipolygon rings
(closes #4741)
2018-01-24 23:16:51 -05:00
Bryan Housel
fb196bee8c Persist area-fill-toggle so we can toggle out of wireframe
(closes #4740)
2018-01-24 14:53:30 -05:00
Bryan Housel
300616819d Don't use the same keybind id for modeSave (esc dialog) and uiSave (Ctrl+S)
(closes #4728)
2018-01-24 13:46:01 -05:00
Bryan Housel
0bb812c916 Merge pull request #4672 from openstreetmap/1ec5-num-format-3597
Localize numbers, units in scale, info panels
2018-01-23 18:05:37 -05:00
Bryan Housel
9cf3630439 Merge pull request #4694 from openstreetmap/1ec5-membership-title-4565
Describe relation in tooltip in add membership list
2018-01-23 17:32:46 -05:00
Gautier Pelloux-Prayer
58a4699508 Restore area fill from local storage including wireframe 2018-01-23 20:20:16 +01:00
Bryan Housel
ffc68d1cd6 Merge pull request #4720 from bagage/master
Restore last imageries used and disable features from local storage
2018-01-23 11:03:52 -05:00
Bryan Housel
6570365413 Use dark halo around text, switch to svgPath to get viewport clipping 2018-01-23 00:29:07 -05:00
Bryan Housel
34c170f6ca Merge pull request #4678 from nnodot/increase-gpxlabels-readability
Increase GPX labels readability
2018-01-22 23:32:43 -05:00
Bryan Housel
b35f6f3f15 highway=motorway_link no longer implies oneway=yes
(closes #4727)

iD still explicitly set the tag, and default it to `oneway=yes`
2018-01-22 21:45:14 -05:00
Gautier Pelloux-Prayer
b3da51b032 Restore user disabled features from local storage 2018-01-22 22:51:02 +01:00
Bryan Housel
de488e252f Draw covered/underground lines beneath areas
(closes #4718)
2018-01-22 15:06:58 -05:00
Gautier Pelloux-Prayer
5077f88a4d Restore latest imagery used from local storage 2018-01-21 23:04:16 +01:00
Bryan Housel
a508ec3c09 v2.6.0 2018-01-21 10:45:32 -05:00
Bryan Housel
24eba5c1b0 Preventing snapping at viewport edge also prevented finishing ways 2018-01-20 22:45:03 -05:00
Bryan Housel
d00bdc69a5 Fix vertex hovering (targets are GeoJSON now) 2018-01-20 01:20:29 -05:00
Bryan Housel
94f89f67c2 Adjacent segments should only be nope'd on the active (drawing) way
(closes #4713)
2018-01-20 00:09:04 -05:00
Bryan Housel
3838b02739 Add detect.cssfilters, fallback to opacity only on IE11/Edge
(re: #4711)
2018-01-19 17:28:35 -05:00
Bryan Housel
b0cba113e9 Fix directional vertices on IE11/Edge
(closes #4710)
2018-01-19 20:32:45 +00:00
Bryan Housel
467de651f7 Guard code from 9b99115b3 needs to be in undo_redo.js too 2018-01-19 13:49:20 -05:00
Bryan Housel
835d45ed6d Never let mouseCoordinates return NaN (fallback to map center) 2018-01-19 11:53:14 -05:00
Bryan Housel
9b99115b3e Guard code for context.mode
In case this is somehow called before initialization is complete
It happens rarely when restoring the initial changes and deferring rendering
2018-01-19 11:44:14 -05:00
Bryan Housel
1cfda3ec86 Only store zoomPan event in mousemove if it has a source event
(closes #4706)

d3 transitioned events don't have a source event,
causing mousemove to go null
2018-01-19 11:42:18 -05:00
Bryan Housel
1697c48360 Fix flickering and drag-node breakage in line endpoint walkthrough step 2018-01-18 22:02:56 -05:00
Bryan Housel
efc2678610 Fix feature list / current view searching
(closes #4690)
2018-01-18 17:55:14 -05:00
Bryan Housel
44234ede66 Make Help pane slightly wider
(re: "claustrophobia" on #4651, #4686)
2018-01-18 17:31:26 -05:00
Bryan Housel
40dc938580 Merge pull request #4693 from openstreetmap/doubled_back_routes
Fixes for joining and splitting bugs
2018-01-18 17:01:38 -05:00
Bryan Housel
7c918ba161 Allow Relation.replaceMember to optionally preserve duplicates
(closes #4696)
2018-01-18 16:52:23 -05:00
Bryan Housel
be9bbd9271 Add tests for member ordering: node, way, relation 2018-01-18 15:21:38 -05:00
Bryan Housel
8f9a46b75a Change actionAddMember to rearrange indexed members in place
This allows it to work around issues where a relation may
not be completely downloaded
2018-01-17 22:59:55 -05:00
Bryan Housel
8c9a0eb2c1 Fix doubleclick on line to create a point
(closes #4691)
2018-01-17 09:23:09 -05:00
Bryan Housel
be46e85ec0 Move insert way pairing code from osmJoinWays to actionAddMember
(tests for actionAddMember now passing!)
2018-01-16 17:41:14 -05:00
Bryan Housel
221158e918 WIP: Add insertHint to actionAddMember, actionSplit 2018-01-15 23:13:59 -05:00
Bryan Housel
03fa6e7be9 Add tryInsert option to osmJoinWays 2018-01-15 22:02:43 -05:00
Nicolas Decoster
dd0a88c245 fix failing npm test 2018-01-15 11:17:51 +01:00
Bryan Housel
0382ce7d4b Updated function doc 2018-01-14 21:45:25 -05:00
Minh Nguyễn
33817af2b7 Describe relation in tooltip in add membership list 2018-01-14 13:19:35 -08:00
Bryan Housel
075b85c81d Apply reversal actions in actionJoin
(closes #4688)
2018-01-14 14:49:57 -05:00
Bryan Housel
8dbb6eb20c Return reversal actions performed by osmJoinWays
(see #4688)
2018-01-13 01:45:46 -05:00
Bryan Housel
0fd801d750 Prefer to join member ways in a way that preserves their order
(re #4589)

Strongly prefer to generate a forward path that preserves the order
of the members array. For multipolygons and most relations, member
order does not matter - but for routes, it does. If we started this
sequence backwards (i.e. next member way attaches to the start node
and not the end node), reverse the initial way before continuing.
2018-01-12 17:23:56 -05:00
Nicolas Decoster
c796a9de12 Increase GPX labels readability 2018-01-10 15:42:56 +01:00
Bryan Housel
f0a27bc1ec Simplify way segmentation and fix bug with adjacent segment type
(closes #4669)

Now instead of creating MultiLineString targets, we just create a bunch of
LineString targets.  This makes the code simpler, and anyway the entity is
still there in `properties` for drawing code to decide what to do with the target.

Incidentally, this change allows iD to support an extrusion operation.
(Because each way segment has its own unique GeoJSON target now)
2018-01-09 10:12:29 -05:00
Minh Nguyễn
ea7339f49a Fixed geometry type word order
In many languages, the word for “closed” would follow the word for “line” or “area”, not precede it. Additionally, the word for “closed” may differ depending on what it modifies.
2018-01-09 03:30:14 -08:00
Minh Nguyễn
702e3d2a90 DMS coordinates 2018-01-09 03:25:55 -08:00
Minh Nguyễn
fe8c218fb3 Localized geocoded coordinate formatting 2018-01-09 02:24:03 -08:00