Commit Graph

2824 Commits

Author SHA1 Message Date
Bryan Housel 8f9dc7afb4 Improve localization of "Thank you for editing the map around.."
(closes #6269)
2019-05-04 13:24:46 -04:00
Quincy Morgan e71470acf6 Remove disabled state cacheing for the delete operation 2019-05-03 13:31:28 -07:00
Quincy Morgan a772808e04 Remove cacheing of disabled state for certain operations to avoid stale state (close #6296) 2019-05-03 13:23:24 -07:00
Quincy Morgan 4afd071a00 Add "Connect this feature" fix to disconnected ways if continuing drawing isn't possible 2019-05-03 12:59:18 -07:00
Quincy Morgan dbc3978d71 Add non-actionable fix recommendation to move very close points apart 2019-05-03 12:15:26 -07:00
Bryan Housel ddc9d16b62 Merge pull request #6302 from openstreetmap/text-raw-tag-editor
Text raw tag editor / Copy-paste tags
2019-05-03 14:53:08 -04:00
Bryan Housel 16ec25753d Support escaping of tricky characters, support quoted strings
keys or values can be quoted or unquoted:
- leisure=park
- leisure="park"
- "leisure"=park
- "leisure"="park"
2019-05-03 14:42:35 -04:00
Quincy Morgan cc85897348 Fix map pane animation on RTL layout (close #6290) 2019-05-03 11:05:10 -07:00
Quincy Morgan b1d00db874 Show very close node issues on the parent way as well as on the points themselves (close #6304) 2019-05-03 10:40:12 -07:00
Bryan Housel 22b7e03d3b Disable spellcheck in the tag textarea 2019-05-03 10:39:38 -04:00
Bryan Housel 8a4e822fd7 If All Fields section is hidden, focus textarea and put cursor at end 2019-05-03 10:33:50 -04:00
Bryan Housel fbe5389ecb Set textarea height to fit content 2019-05-03 10:14:53 -04:00
Bryan Housel c95860f36d Convert changes in the textarea back to tag changes 2019-05-02 23:01:33 -04:00
Bryan Housel 7b4a9a43b0 Change utilTagDiff to return an object with details 2019-05-02 22:59:41 -04:00
Quincy Morgan 672966426f Merge branch 'master' of https://github.com/openstreetmap/iD 2019-05-02 16:26:48 -07:00
Quincy Morgan bfc944e30a Fix two potential exceptions and one lint warning 2019-05-02 16:26:33 -07:00
Bryan Housel ff1eea43a8 Remove Google Analytics, also actually export iD.utilDetect 2019-05-02 19:12:39 -04:00
Quincy Morgan ba9fd58fa9 Don't flag roads connected only to ferry routes as disconnected (close #6287)
Use common routable highway tag list for disconnected way check
2019-05-02 14:49:27 -07:00
Quincy Morgan 0a71fd1e4f Fix false positive for impossible oneway when connected way is circular 2019-05-02 12:18:21 -07:00
Quincy Morgan 752bc72e7c Fix issue where close nodes validation may not detect issues in some cases 2019-05-02 12:03:09 -07:00
Quincy Morgan 424f6ca72d Don't skip other validations even if there are missing tag issues 2019-05-02 11:51:01 -07:00
Quincy Morgan b4dacdad2a Reduce very close nodes validation threshold (close #6292)
Use spherical distances for very close nodes validation
Don't flag very close nodes from different ways
Don't flag very close nodes if both have interesting tags
Update very close nodes validation reference string
2019-05-02 11:39:12 -07:00
Bryan Housel 61819058d3 Avoid frequent reflow from setting scrollTop
(possibly re: #6289)
2019-05-02 14:21:57 -04:00
Bryan Housel b17e4e4f1d Add 'list'/'text' toggle buttons 2019-05-02 13:49:26 -04:00
Bryan Housel cebe4ced8a Preserve user's preference for 'list'/'text' view for the raw tag editor 2019-05-02 11:17:06 -04:00
Bryan Housel ed9a436318 Move common tag diffing code from validators into utilTagDiff 2019-05-02 11:16:15 -04:00
Bryan Housel af97f09150 Remove "key=value" pasting into raw tag editor key
(Reverts: #6211, #5070, #5024)

The old code allows users to circumvent the readonly tag protection
see https://github.com/openstreetmap/iD/issues/6185#issuecomment-488692351

We'll offer a text-mode instead, with stricter checks on which keys can be modified.
2019-05-02 10:22:37 -04:00
Quincy Morgan d061ec6b61 Don't add ignore fix more than once
Tweak hidden issues text
2019-05-01 20:21:47 -07:00
Quincy Morgan a180c794cb Merge branch 'master' into ignoring-issues 2019-05-01 20:13:49 -07:00
Quincy Morgan 712f8bcb03 Avoid having hidden issues strings for both singular and multiple variations 2019-05-01 20:13:09 -07:00
Bryan Housel ea40634ac6 Add list<->text toggle for raw tag editor 2019-05-01 21:53:43 -04:00
Bryan Housel 087f252b18 When removing a tag, remove it from _indexedKeys too
(re: d026f2f / #5927)

So that if the user decides to put it back, it will be sorted to the
end and not inserted back at its original position in the middle
2019-05-01 19:17:59 -04:00
Bryan Housel 382e0a7dd6 Merge pull request #6270 from westnordost/patch-10
inherit preset.removeTags from preset.addTags if not defined [Ready for Review]
2019-05-01 19:15:24 -04:00
Quincy Morgan eeaad79cb1 Display info about hidden issues in the "no issues" UI 2019-05-01 14:50:56 -07:00
Quincy Morgan 1c15338bd5 Make reset ignored button consistent with enable/disable all rules buttons 2019-05-01 12:13:10 -07:00
Quincy Morgan 56544303ca Merge branch 'master' into ignoring-issues 2019-05-01 11:58:39 -07:00
Bryan Housel d7a569c425 Merge branch 'defer-select-for-6028' 2019-05-01 14:49:31 -04:00
Bryan Housel 37557a7c98 Defer processing clicks in behaviorSelect
(closes #6028) (I hope?)

Because this click may trigger a blur event,
and the blur event may trigger a tag change,
and we really want that tag change to go to the already selected entity
and not the one that we are about to select with the click  #6028, #5878

(Be very careful entering modeSelect anywhere that might also blur a field!)
2019-05-01 14:47:29 -04:00
Quincy Morgan 949b57d118 Ensure that relations are called before ways when categorizing fetched features (close #6277) 2019-05-01 11:33:39 -07:00
Quincy Morgan 907df1c10e Include relation members when forcing relations visible in all cases, not just selection (re: 6eeaf94076) 2019-05-01 11:08:52 -07:00
Bryan Housel d3f767d6f4 Code cleanups, prefix state variables with _ 2019-05-01 13:48:36 -04:00
Quincy Morgan 52d92f125c Add button to reset ignored issues
Don't cache issue extent
2019-04-30 16:32:36 -07:00
Bryan Housel d026f2f296 Add index property to tag rows, don't reorder on modifying key
(closes #5927)
2019-04-30 18:22:11 -04:00
Tobias Zwick 446dc1097d Merge branch 'master' into patch-10
# Conflicts:
#	data/presets/presets/highway/crossing/unmarked-raised.json
#	data/presets/presets/highway/crossing/unmarked.json
2019-04-30 22:20:05 +02:00
Quincy Morgan a4ebbaf7f5 Don't use the issue loc as a differentiator for all issues 2019-04-30 13:16:03 -07:00
Quincy Morgan 26f1e29072 Merge branch 'master' into ignoring-issues
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
2019-04-30 13:05:07 -07:00
Quincy Morgan 9d6b461d0e Apply the crossing tag of the path to the node even if it's not a footpath when connecting crossing ways 2019-04-30 11:53:03 -07:00
Quincy Morgan 07573091ad Don't add a "crossing" tag to ambiguous crossings when connecting crossing ways via the quick fix (re: #6244) 2019-04-30 11:46:15 -07:00
Quincy Morgan 942d55a4bf Update strings for duplicate node validation
Use routable highway tags for duplicate node validation instead of any highway tag
2019-04-30 10:18:22 -07:00
Quincy Morgan ddae6641b3 Fix issue where preset list would not appear when adding new features (close #6271) 2019-04-30 09:42:24 -07:00