Commit Graph

14579 Commits

Author SHA1 Message Date
Martin Raifer a3e65e553b Merge branch 'colour-preview' into develop 2021-12-01 12:16:42 +01:00
Martin Raifer 5761f53c41 fix eslint warning 2021-12-01 12:16:19 +01:00
Martin Raifer e4008b4229 show native colour picker when clicking on colour preview
further tweaks:
* hide the box on invalid colours
* only affect field with a tag key that included "colour" separated by ":"
2021-12-01 12:11:13 +01:00
Martin Raifer ae004a15c5 update changelog 2021-11-30 16:30:49 +01:00
Martin Raifer d062c1b0da emphasise when split affects multiple ways
* new icon with two "sciscors" indicates that there will be more than one split perfomed
* the tooltip mentions that one can limit to a single line

closes #8818
2021-11-30 16:27:56 +01:00
Martin Raifer eec5032251 fix labeling of "reverse" button 2021-11-30 16:22:13 +01:00
Martin Raifer 27ec86c64f fix rendering of validation issues 2021-11-30 15:30:13 +01:00
Martin Raifer 7015fae91c only allow to click on valid website URLs
closes #8827
2021-11-30 15:30:02 +01:00
Martin Raifer 195e287923 fix rendering of combobox items 2021-11-30 13:49:24 +01:00
Martin Raifer 344a903170 Merge branch 'nsi_primary_match' into develop 2021-11-30 13:16:58 +01:00
Martin Raifer be873f9d06 add to changelog 2021-11-30 13:13:27 +01:00
Martin Raifer e66edcbc99 Merge pull request #8817 from openstreetmap/issue-8813
reduce direct html injection, add escaping where necessary
2021-11-30 12:38:45 +01:00
Martin Raifer e5aedb249f add basic test case for t.append method 2021-11-30 11:31:58 +01:00
Martin Raifer 4bef27db82 add to changelog, mark t.html as deprecated 2021-11-30 10:33:55 +01:00
Bryan Housel 3b3f80f690 Improve the checking of results from the NSI matcher..
(fixes: https://github.com/osmlab/name-suggestion-index/issues/5693)

Previously the code would accept the first useful match, however this match
might be an "alternate" match.  Now we keep iterating until we find a "primary"
match.

This bug could cause the validator to suggest upgrading well-tagged features to
a less wanted feature type.  For example a "Tesla Supercharger" would flip to
a "Tesla Destination Charger" if it had "Tesla" anywhere in its list of tags
(because `short_name=Tesla` is an "alternate" match for both destination
chargers and super chargers)
2021-11-29 16:49:36 -05:00
Martin Raifer 9f3f8e1366 rename method 2021-11-29 19:26:18 +01:00
Martin Raifer 54886339f6 fix code lint issue, move additional logic into display methods 2021-11-29 19:21:29 +01:00
Martin Raifer f3d05e4b01 fix restrictions field and global search results 2021-11-29 19:09:10 +01:00
Martin Raifer a21a985db5 fix html injecting/rendering in help pane 2021-11-29 17:31:11 +01:00
Martin Raifer d78c357588 replace raw html injection of localized texts
by using d3 to insert the localized text spans directly into the DOM
2021-11-26 18:51:45 +01:00
Martin Raifer ca0b131542 fix html formatting 2021-11-26 18:48:56 +01:00
Martin Raifer ca07e33a3e Merge branch 'develop' into issue-8813 2021-11-23 18:28:14 +01:00
Martin Raifer f6cbc65cdc always detect source type for custom background sources.
fixes #8057
2021-11-23 15:05:00 +01:00
Martin Raifer 770a43bd08 Merge pull request #8823 from openstreetmap/1ec5-validator-attach-8812
Clarify validator warning about standalone node
2021-11-23 14:18:15 +01:00
Minh Nguyễn 105d7b84b4 Clarified validator warning about standalone node 2021-11-20 09:32:39 -08:00
Martin Raifer b5fdb145f5 add more explicit html formatting of translated texts 2021-11-19 12:23:45 +01:00
Martin Raifer 68098489af add quotes back to separate tag key from message text 2021-11-19 12:10:05 +01:00
Martin Raifer f91ae8902f build asset 2021-11-19 12:00:57 +01:00
Martin Raifer 8fa1c3aff7 drop unused translation string
which is not used since commit fc497f16d8

see https://github.com/openstreetmap/iD/issues/1167
2021-11-19 11:57:01 +01:00
Martin Raifer 040257fd44 replace unnecessary setting of raw "html" with "text" 2021-11-18 18:53:33 +01:00
Martin Raifer 12f546d6e6 escape raw osm usernames displayed in note comments 2021-11-18 15:36:35 +01:00
Martin Raifer 8892b437a1 escape and format conflict details as localized html strings
these are in html because they contain links to osm user profiles
2021-11-18 13:09:57 +01:00
Martin Raifer 8bbae82caa localizer: escape placeholder replacement values in html output mode 2021-11-18 13:09:16 +01:00
Martin Raifer e1dda082e0 escape user name displayed in the history panel 2021-11-18 13:09:05 +01:00
Minh Nguyễn 3956b4415f Escape user name in profile URL 2021-11-17 18:18:08 -08:00
Minh Nguyễn 3f09ebee59 Corrected language code for undefined language 2021-11-17 18:17:24 -08:00
Minh Nguyễn e2a5345c7f Fixed KartaView link
https://github.com/openstreetmap/iD/issues/8807#issuecomment-970743880
2021-11-16 14:39:23 -08:00
Martin Raifer c854564389 introduce allowlist for disconnectable relation types 2021-11-16 18:03:51 +01:00
Martin Raifer cb96257c63 explicit coloring of preset categories 2021-11-16 17:58:52 +01:00
Martin Raifer 0775c24c0a fix wording in changelog 2021-11-16 17:48:07 +01:00
Martin Raifer 25d4ff100f rename all openstreetcam references to kartaview
closes #8807
2021-11-16 17:42:53 +01:00
Martin Raifer 6a45b66294 Merge pull request #8810 from openstreetmap/issue-8805
start a running changelog
2021-11-16 17:06:15 +01:00
Martin Raifer db20d71c95 start with a running changelog 2021-11-16 16:58:25 +01:00
Martin Raifer de0a501271 tweak contributing instructions to keep a running changelog 2021-11-16 16:38:00 +01:00
Martin Raifer 8b23b0f413 add missing changelog entry for #8276 2021-11-16 16:37:59 +01:00
Martin Raifer 4f51ededfd fix eslint "no-implicit-coercion" warning
See https://eslint.org/docs/rules/no-implicit-coercion for this warning. However the implicit type conversion is unnecessary here, since `Number.toFixed` already returns a string, see https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed.
2021-11-16 11:20:01 +01:00
Stéphane Guillou f8210a9a86 clarify "disconnected_way" validation text (fixes #8760) (#8800)
As discussed in issue #8760, clarify that the ways that are considered routable by the validator need to be well represented among major routing software.

Co-authored-by: Martin Raifer <martin@raifer.tech>
2021-11-16 11:12:15 +01:00
Martin Raifer 1667f3e5f2 update list of communication channels and contacts
see also #8718
2021-11-16 09:12:04 +01:00
Martin Raifer f3e8852808 don't select option on ambiguous multi-key radio fields
this matches the behaviour of a multi-selection: all matching options are still highlighted, but the radio-option is not set.

also fixes a minor bug with multi-selections not taking `<key> = no` properly into account

closes #8796
2021-11-09 15:10:47 +01:00
Martin Raifer 2f9285e011 improve rendering of turn-restriction boxes in narrow sidebars
Previously the applied paddings were too large for narrow sidebars, causing the turn-restriction min-map view to be much more zoomed out than needed.
This tweaks the paddings such that even for the slimmest sidebar the rendering is still acceptable (i.e. no turn arrows to be rendered completely outside of the viewport) and at the same time allows generous margins for wider sidebars.

This also fixes a minor bug where the mini-map is not properly alligned vertically
2021-11-05 14:46:53 +01:00