Commit Graph

254 Commits

Author SHA1 Message Date
mxxcon
87819ed53f Adds nycdoitt:bin tag to list of tags to keep on building
When extracting a POI from a building or downgrading a building, this update keeps nycdoitt:bin= tag with the building, not extracts it to the node or deletes it.

resolves #8539
2023-11-14 09:42:32 +01:00
Martin Raifer
fa35f0e78d fix arguments of unsetTag call, fixes #9707 2023-07-07 18:39:44 +02:00
Martin Raifer
43784e2eff take entity loc into account when resolving fields via parent preset, fixes #9524
this necessary when a regional preset (e.g. from NSI) is supposed to inherit fields from a parent preset, but the direct parent does NOT apply at the location of the entity to be added/edited. In that case we need to search for a potential regional variant of the parent preset.
2023-05-25 19:19:09 +02:00
Martin Raifer
41aa127d23 reduce use of parseFloat
as it silently strips non-numeric suffixes (e.g. a value of "123 foo" is transformed into a numeric value of 123 by `parseFloat`, which is typically not what we desire)
2022-11-24 19:39:15 +01:00
Martin Raifer
fc75d5f2a1 fix another regression (in b72f3aa), add tests 2022-11-24 19:12:23 +01:00
Martin Raifer
b72f3aae19 fixes a regression in f573c37 2022-11-24 18:40:11 +01:00
Martin Raifer
f573c374c2 number field: improve +/- buttons
* Clamp degree values in `direction` fields between 0 and 359 degrees, fixes #9386
* Only match cardinal values to numbers in `direction` fields
* Disable increment/decrement buttons on number fields if the input value is not numeric or when there is a multi-selection with conflicting values
* Fix/implement reverse operation for semicolon delimited `direction` values
2022-11-24 15:16:49 +01:00
Martin Raifer
21e54f956d don't preserve preset's field tags if presets are sub-presets of each other
fixes #0372
2022-11-14 18:58:37 +01:00
Martin Raifer
96bac0650b on preset change: don't drop tags if ∃ a matching field in the new preset
closes #9341
closes #9104
2022-10-27 13:06:00 +02:00
Martin Raifer
46a386cae7 add #8839 to changelog, minor cleanup of unused imports 2021-12-07 11:57:38 +01:00
Thomas Petillon
3ff06f9045 Fix relation handling on way split
Depending on which way is the longest, the new way is inserted into the
relation before the existing one. This case must be explicitly handled
for the relation to remain correct.
2021-12-06 21:25:23 +01:00
Thomas Petillon
21f171863c Keep the oldest IDs alive when merging nodes into a way 2021-12-06 21:25:22 +01:00
Thomas Petillon
23b3bc27b6 Keep the oldest ID alive when merging polygons 2021-12-06 21:23:38 +01:00
Thomas Petillon
87ca2b09cc Keep the oldest interesting ID alive when merging nodes 2021-12-06 21:23:38 +01:00
Thomas Petillon
e9c7436289 Use utilOldestID() when joining ways 2021-12-06 21:23:38 +01:00
Martin Raifer
040257fd44 replace unnecessary setting of raw "html" with "text" 2021-11-18 18:53:33 +01:00
Martin Raifer
8892b437a1 escape and format conflict details as localized html strings
these are in html because they contain links to osm user profiles
2021-11-18 13:09:57 +01:00
Martin Raifer
c854564389 introduce allowlist for disconnectable relation types 2021-11-16 18:03:51 +01:00
John Firebaugh
3e082bb20e Fix typos 2021-10-24 11:01:44 -07:00
Kyle Hensel
3f12dd5107 keep the oldest Way when merging 2021-10-01 10:31:21 +13:00
John Firebaugh
1457759994 Add support for connectivity relations 2021-09-08 20:30:38 -07:00
John Firebaugh
a14cf49710 Disable merge operation when it would damage relations
The operation is disabled when attempting to join ways which don't belong to identical sets of relations. Restriction relations are excluded, because they are already handled with slightly different logic.

Fixes #8674
Fixes #8645
Fixes #3825
Fixes #1512
2021-09-04 15:42:07 -07:00
Quincy Morgan
af4acaec79 Don't clear power output tag when changing between power presets (close #8159) 2020-12-21 13:17:18 -05:00
Quincy Morgan
0a0e2dcf75 Fix issue where extracting points could results in off placements (close #8246) 2020-12-11 12:50:32 -05:00
Quincy Morgan
ba48a861bc Enable curly and block-spacing eslint rules 2020-11-10 14:19:11 -05:00
Quincy Morgan
ba4c1ef014 Account for instances where d3.geoCentroid returns incorrect results 2020-10-29 14:28:21 -04:00
Quincy Morgan
4059ee5118 Enable block-scoped-var eslint rule 2020-10-23 13:38:36 -04:00
Quincy Morgan
04b3a788f9 Add lint:fix script
Enable no-trailing-space eslint rule
2020-10-23 13:24:44 -04:00
Quincy Morgan
1a6e1b97cb Merge pull request #8083 from teymour-aldridge/develop
Tidy some things up.
2020-10-21 09:43:46 -04:00
teymour-aldridge
c259b32fbc Undo unnecessary formatting change. 2020-10-16 17:35:38 +01:00
teymour-aldridge
444c2c2c15 Apply further suggestions from code review. 2020-10-16 17:26:10 +01:00
Quincy Morgan
eaf6ff874e Support the Relations editor for multiple selected features (close #7753) 2020-10-15 11:31:32 -04:00
teymour-aldridge
b966ac318e Add back (and fix) an assignment. 2020-10-14 20:48:30 +01:00
teymour-aldridge
371a5dde0e Make a variable inline 2020-10-14 19:00:39 +01:00
teymour-aldridge
90d3f59aa6 Remove some unneeded variables.
These should theoretically actually slow down the JIT (if very marginally) so performance-wise it's better not to have them.
2020-10-14 19:00:10 +01:00
Quincy Morgan
bebd7db214 Fix potential JavaScript error 2020-10-09 10:24:53 -04:00
Quincy Morgan
d43fc62994 Divide up the step_count tag value proportionally when splitting ways (close #8069) 2020-10-09 09:48:52 -04:00
Quincy Morgan
476e929eec Support splitting areas at nodes connected to lines if the lines can't be split (close #6047) 2020-09-29 15:49:42 -04:00
Quincy Morgan
4ddd4a358b Deprecate vending=parcel_mail_in;parcel_pickup -> vending=parcel_pickup;parcel_mail_in (close #7988)
Enable upgrading of entire semicolon-delimited values
2020-09-28 16:07:11 -04:00
Quincy Morgan
c940d827e6 Enable the Split operation for multiple selected nodes (close #7990) 2020-09-24 15:13:05 -04:00
Quincy Morgan
45decdb54c Enable scaling the selection via hotkeys 2020-09-21 14:02:41 -04:00
Quincy Morgan
5ddcfb0ced Add parameter to specify which way should keep the history when splitting ways (re: #7795)
Fix code tests
2020-09-14 11:27:20 -04:00
Quincy Morgan
99c75b8f65 Keep the way history on the longer result when splitting a way (close #7795) 2020-09-14 10:01:47 -04:00
Quincy Morgan
484f54f982 Don't copy building part or indoor tags to node when extracting point from a way or relation (close #7862) 2020-08-16 17:18:16 -04:00
Peter Newman
4205ca1d07 Fix the seemingly safe spellings found by codespell
Untested, only checked by inspection.

(cherry picked from commit 2c47a11008)
2020-08-10 17:32:37 +01:00
Quincy Morgan
22df464e0d Fix issue where valid merge operations could be blocked
Disable merge when it'd create a redundant multipolygon or add a redundant membership
2020-06-29 10:51:12 -04:00
Quincy Morgan
0c95b12964 Fix issue with extracting relations 2020-06-28 14:46:49 -04:00
Quincy Morgan
e476321818 Use loops instead of functions in actionDisconnect.connections, for performance (re: #7706) 2020-06-16 13:18:59 -04:00
Quincy Morgan
8b258d2cbd Load the maximum nodes per way value from the OSM API and add a getter to the service object
Disable the Merge operation if the resultant way would have more than the maximum number of nodes (close #6030)
Simplify some code in operationMerge
2020-06-08 14:38:49 -04:00
Quincy Morgan
2e5e3791c5 Disable the straighten operation for selections that are already straight (close #7658) 2020-06-08 11:58:10 -04:00