Commit Graph

4571 Commits

Author SHA1 Message Date
Martin Raifer b266ec57ad treat "empty" numbers in semicolon separated "list" as invalid 2023-05-26 15:00:10 +02:00
Martin Raifer 6d01c05f76 allow numbers to be input in "raw" format 2023-05-26 13:44:50 +02:00
Martin Raifer 249771d747 fix variable declarations 2023-05-26 13:25:59 +02:00
Martin Raifer 6c362b6517 Merge branch 'develop' into 1ec5-number-field-format-3615 2023-05-26 13:06:09 +02:00
Martin Raifer 43784e2eff take entity loc into account when resolving fields via parent preset, fixes #9524
this necessary when a regional preset (e.g. from NSI) is supposed to inherit fields from a parent preset, but the direct parent does NOT apply at the location of the entity to be added/edited. In that case we need to search for a potential regional variant of the parent preset.
2023-05-25 19:19:09 +02:00
Martin Raifer 28630ae9fc don't repeat values from multi-selection in dropdown
as their state can now been toggled using the checkbox in the chip
2023-05-25 18:47:30 +02:00
Martin Raifer 805becfe3b support no and "other" states of options of multiCombo/manyCombo fields
closes https://github.com/openstreetmap/id-tagging-schema/issues/895 and #7427
2023-05-25 18:17:00 +02:00
Martin Raifer f517b867de add tests for #9650 2023-05-25 15:24:52 +02:00
Martin Raifer 9517d06d11 use lodash for object comparison 2023-05-25 13:22:39 +02:00
Minh Nguyễn e4641b581f Offer to connect sidewalk to service road without tagging crossing (#9650) 2023-05-25 13:17:34 +02:00
Kyℓe Hensel 077d9a5105 fix tag values with whitespace causing css bugs (#9637) 2023-05-23 23:21:41 +02:00
Martin Raifer 96c2670727 we can still use the full language for output (uselang) 2023-05-23 16:15:11 +02:00
Martin Raifer 862ca6522a retry wikidata api without lng's region subtag if an error is returned
closes #9638
2023-05-23 16:13:40 +02:00
Martin Raifer 559a4ba728 support input fields with multiple tag keys
requires upstream changes from tagging-schema v6.3, see https://github.com/openstreetmap/id-tagging-schema/issues/905
2023-05-23 15:22:58 +02:00
Martin Raifer bd98ff904b restrict taginfo suggestions in raw tag editor to ones which match the input string
this additinoal filtering is needed because of the caching performed by the services/taginfo.js module.
2023-05-16 17:10:30 +02:00
Martin Raifer 9779f320a8 Properly handle case sensitive tags in taginfo suggestion in raw tag editor, fixes #9640 2023-05-16 17:06:39 +02:00
Martin Raifer a35653d35d use all available option strings when setting value
this fixes where tag values of fields with referenced strings can become corrupted when the sub-field has restricted `options`, and an unavailable option is entered manually into the field.

important for openstreetmap/id-tagging-schema#891
2023-05-11 15:06:37 +02:00
Biswajit Kaushik 25cf4366d1 Fix wrongly flagged "incorrect geometry type" for features with lifecycle-prefixed tags (#9483) 2023-05-10 12:02:37 +02:00
Martin Raifer 140e56768e fix hiding of "Add" input on comboboxes with fixed options
the check for this needs to be done after the available options are actually refreshed
2023-05-02 14:10:48 +02:00
Martin Raifer 24e514fa99 defer loading of static combo options
fixes a bug where `multi/many/semiCombo` options are not selectable immediately after they were removed from a field, when the field does not use taginfo to fetch options
2023-05-02 13:01:32 +02:00
Martin Raifer 406c1a0690 bump streetview generation id to work around #9230
this is not a permanent fix; as explained in https://github.com/openstreetmap/iD/issues/8747#issuecomment-945669204 we should upgrade to Bing streetview's v8 API calls. Unfortunately, our API key is not enabled for that API, though.

closes #9230
2023-04-04 12:59:58 +02:00
archpdx e466ad4bf8 Update dependencies country-coder and location-conflation (#9546) 2023-03-30 12:53:38 +02:00
Martin Raifer 0334533aee render sidedness markers for man_made=quay
see https://github.com/openstreetmap/id-tagging-schema/pull/810#issuecomment-1464181204
2023-03-13 15:14:27 +01:00
Kyℓe Hensel 0ec1b45bf9 tweak regex when searching for a feature ID (#9520) 2023-03-06 13:58:48 +01:00
Minh Nguyễn ab442b76ac Preserve precision in raw tags 2023-03-04 23:43:40 -08:00
Minh Nguyễn 023907f9e2 Fixed incrementing/decrementing formatted numbers
The float formatter function now takes a number of fraction digits to return.
2023-03-04 18:36:06 -08:00
Minh Nguyễn 4e1129709c Fixed exception formatting nonexistent value
Co-authored-by: Martin Raifer <martin@raifer.tech>
2023-03-03 22:48:30 -08:00
Minh Nguyễn 6419def20f Fixed numeric fields in locales without literals 2023-03-03 22:42:15 -08:00
Minh Nguyễn 5d224a41cd Strip literal (bidi) characters when parsing numbers 2023-03-03 22:42:15 -08:00
Minh Nguyễn ecb7c20bbf Avoid truncation when formatting numbers 2023-03-03 22:42:14 -08:00
Minh Nguyễn 74fdf17477 More minor corrections from code review 2023-03-03 22:42:14 -08:00
Minh Nguyễn 9817894752 Apply suggestions from code review
Co-authored-by: Martin Raifer <martin@raifer.tech>
2023-03-03 22:42:14 -08:00
Minh Nguyễn 0dadd8b31c Clean roadheight value after concatenation 2023-03-03 22:42:14 -08:00
Minh Nguyễn 2ba7177080 Polyfill inadequate Intl support
Ensure that formatting is balanced with parsing to avoid truncating numbers.
2023-03-03 22:42:14 -08:00
Minh Nguyễn 252828bb4b Localize numbers in numeric fields 2023-03-03 22:42:14 -08:00
Kyℓe Hensel 43b4b4f02b render right-sided arrows for features with lifecycle prefixes (#9493) 2023-03-03 18:53:10 +01:00
Kyℓe Hensel d6b869fe7a add 4 tags which imply oneway=yes (#9492) 2023-03-03 18:48:22 +01:00
Kyℓe Hensel a17b5faf5f Send 'Accept-Language' header on Nominatim API calls (#9501) 2023-03-03 18:34:24 +01:00
Martin Raifer fc5b78ba0a show 'set to today' button also on 'survey:date' field 2023-01-27 17:10:02 +01:00
Martin Raifer 3238d3439c fix linter issues 2023-01-27 17:05:43 +01:00
Martin Raifer adcbdae6e8 implement date field, for #9477 2023-01-27 17:03:28 +01:00
Martin Raifer deb2b15cf4 load value icons in combo fields, increase their size slightly
as specified in the tagging schema [v6](https://github.com/ideditor/schema-builder/blob/main/CHANGELOG.md#600)

for #9477
2023-01-24 15:10:50 +01:00
Martin Raifer d9695f1cef update directionalCombo fields to tagging schema v6 schema
keeping a fallback to v5's `cycleway` field type for now

for #9477
2023-01-24 14:25:53 +01:00
Martin Raifer 98e9a11a51 add Röntgen icon set 2023-01-23 20:42:03 +01:00
Martin Raifer 73773b61f1 Fix context "edit" menu on touchscreens
* render labels properly, fixes #9425
* always open the touch-specific edit menu (the contextmenu event is always triggered by the browser on long presses, where we need to make sure that this event doesn't override the `isTouchMenu` property of the edit menu)
2023-01-19 18:27:02 +01:00
archpdx 81374c3735 Fix connect features with uncontrolled crossing (#9443) 2023-01-19 11:59:16 +01:00
Furkan Mutlu f7bd65ac8d fix: 🐛 Fix multiple appending debug vintage unknown label (#9458)
* fix: 🐛 Fix multiple appending debug vintage unknown label

* keep using t.append for accessibility

Co-authored-by: Martin Raifer <martin@raifer.tech>
2023-01-19 11:49:30 +01:00
Martin Raifer dc9b6a3acb only treat traffic_calming=island as an area tag
this is required for a proper fix of https://github.com/openstreetmap/id-tagging-schema/issues/733
2023-01-18 19:15:16 +01:00
Martin Raifer 4b83dceec1 don't split values in semiCombo fields split with , in descriptions
fixes #9471
2023-01-18 19:10:09 +01:00
Kamil Monicz 65da698886 Optimize oldTagIssues method by reordering the checks (#9434)
The hasInterestingTags skips most entities and is light to run - in contrary to presetManager.match
2022-12-20 18:53:09 +01:00